Consider all faces in TextureCubeMap::hasNonBaseLevels()
Not tested by dEQP (and unlikely to be, as we don't want to force
drivers to break existing content by adding new negative coverage in
general) but this was wrong.
Bug: b/141916742
Test: dEQP-EGL.functional.image.api.create_image_*
Change-Id: I774d197a9c5c47447c97d212b41e4c33ad963474
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36949
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
diff --git a/src/OpenGL/libGLESv2/Texture.cpp b/src/OpenGL/libGLESv2/Texture.cpp
index f193ef3..c906c75 100644
--- a/src/OpenGL/libGLESv2/Texture.cpp
+++ b/src/OpenGL/libGLESv2/Texture.cpp
@@ -1024,9 +1024,12 @@
{
for(int level = 1; level < IMPLEMENTATION_MAX_TEXTURE_LEVELS; level++)
{
- if (image[0][level])
+ for(int face = 0; face < 6; face++)
{
- return true;
+ if (image[face][level])
+ {
+ return true;
+ }
}
}
