Assert VkInstanceCreateInfo::flags is 0
VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR was being passed
directly from the application to the ICD by the Vulkan Loader, but is
intended only for the Loader itself. This was fixed in
https://github.com/KhronosGroup/Vulkan-Loader/issues/992 so we can now
be strict again about asserting there are no unsupported flags being
used.
Bug: Revert Vulkan Loader bug workaround. See link above.
Change-Id: I18194a0bfc9d675ad4aa0f075f4867ad908273f3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/67908
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
diff --git a/src/Vulkan/libVulkan.cpp b/src/Vulkan/libVulkan.cpp
index 8e8037e..87006a3 100644
--- a/src/Vulkan/libVulkan.cpp
+++ b/src/Vulkan/libVulkan.cpp
@@ -511,8 +511,7 @@
initializeLibrary();
- if(pCreateInfo->flags != 0 &&
- pCreateInfo->flags != VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR) // TODO(https://github.com/KhronosGroup/Vulkan-Loader/issues/992)
+ if(pCreateInfo->flags != 0)
{
// Vulkan 1.3: "flags is reserved for future use." "flags must be 0"
UNSUPPORTED("pCreateInfo->flags 0x%08X", int(pCreateInfo->flags));
