Remove superfluous incRef/decRef on graphics buffer.
Dequeuing and queuing the graphics buffer takes care of ownership, and
a previous patch ensured the buffer is unlocked before we queue it so
we don't need to hold a reference for longer.
Bug b/34981145
Bug b/35443034
Change-Id: I6cbaeff08f5d930dde8bdd1522052ac33a6ae9ac
Reviewed-on: https://swiftshader-review.googlesource.com/8849
Reviewed-by: Greg Hartman <ghartman@google.com>
Reviewed-by: Nicolas Capens <capn@google.com>
Tested-by: Greg Hartman <ghartman@google.com>
diff --git a/src/Main/FrameBufferAndroid.cpp b/src/Main/FrameBufferAndroid.cpp
index d156d3a..e574d82 100644
--- a/src/Main/FrameBufferAndroid.cpp
+++ b/src/Main/FrameBufferAndroid.cpp
@@ -75,8 +75,6 @@
}
queueBuffer(nativeWindow, buffer, -1);
-
- buffer->common.decRef(&buffer->common);
}
}
@@ -87,8 +85,6 @@
return nullptr;
}
- buffer->common.incRef(&buffer->common);
-
if(gralloc->lock(gralloc, buffer->handle,
GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_OFTEN,
0, 0, buffer->width, buffer->height, &locked) != 0)
