commit c92bee53bc541ee100872ba57c3723cce8ef59b7
author Nicolas Capens <capn@google.com> Sat Dec 07 10:20:58 2019 -0500
committer Nicolas Capens <nicolascapens@google.com> Mon Dec 09 13:11:00 2019 +0000
tree 3e0d55e8b674fc0e6f6a63cfdbcd73cff69cb752
parent 31916f494c2eca2ee3257733812ce21aa8f2e756

Remove coverage asserts for tested code

These asserts were put in place to warn us if they got test coverage.
They do since https://swiftshader-review.googlesource.com/38929. All
seven are hit by the new test.

Bug: b/145836207
Change-Id: I1aba531a1d005b48185d0b3ba72b923d2997a88e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39088
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: David Turner <digit@google.com>

third_party/subzero/src/IceTargetLoweringX86BaseImpl.h

diff --git a/third_party/subzero/src/IceTargetLoweringX86BaseImpl.h b/third_party/subzero/src/IceTargetLoweringX86BaseImpl.h
index a932e19..ebb49a5 100644
--- a/third_party/subzero/src/IceTargetLoweringX86BaseImpl.h
+++ b/third_party/subzero/src/IceTargetLoweringX86BaseImpl.h
@@ -6521,8 +6521,6 @@
           _movp(T, Src0R);
           _punpckl(T, Src1RM);
         } else if (Index0 == Index2 && Index1 == Index3) {
-          assert(false && "Following code is untested but likely correct; test "
-                          "and remove assert.");
           auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(
               Src0, Index0, Src1, Index1);
           T = lowerShuffleVector_AllFromSameSrc(
@@ -6558,8 +6556,6 @@
       }
       break;
       CASE_SRCS_IN(0, 1, 1, 1) : {
-        assert(false && "Following code is untested but likely correct; test "
-                        "and remove assert.");
         auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(Src0, Index0,
                                                                   Src1, Index1);
         T = lowerShuffleVector_TwoFromSameSrc(
@@ -6575,16 +6571,12 @@
       break;
       CASE_SRCS_IN(1, 0, 0, 1) : {
         if (Index0 == Index3 && Index1 == Index2) {
-          assert(false && "Following code is untested but likely correct; test "
-                          "and remove assert.");
           auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(
               Src1, Index0, Src0, Index1);
           T = lowerShuffleVector_AllFromSameSrc(
               Unified, UNIFIED_INDEX_0, UNIFIED_INDEX_1, UNIFIED_INDEX_1,
               UNIFIED_INDEX_0);
         } else {
-          assert(false && "Following code is untested but likely correct; test "
-                          "and remove assert.");
           auto *Unified0 = lowerShuffleVector_UnifyFromDifferentSrcs(
               Src1, Index0, Src0, Index1);
           auto *Unified1 = lowerShuffleVector_UnifyFromDifferentSrcs(
@@ -6621,8 +6613,6 @@
       }
       break;
       CASE_SRCS_IN(1, 0, 1, 1) : {
-        assert(false && "Following code is untested but likely correct; test "
-                        "and remove assert.");
         auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(Src1, Index0,
                                                                   Src0, Index1);
         T = lowerShuffleVector_TwoFromSameSrc(
@@ -6635,8 +6625,6 @@
       }
       break;
       CASE_SRCS_IN(1, 1, 0, 1) : {
-        assert(false && "Following code is untested but likely correct; test "
-                        "and remove assert.");
         auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(Src0, Index2,
                                                                   Src1, Index3);
         T = lowerShuffleVector_TwoFromSameSrc(Src1, Index0, Index1, Unified,
@@ -6651,8 +6639,6 @@
       }
       break;
       CASE_SRCS_IN(1, 1, 1, 1) : {
-        assert(false && "Following code is untested but likely correct; test "
-                        "and remove assert.");
         T = lowerShuffleVector_AllFromSameSrc(Src1, Index0, Index1, Index2,
                                               Index3);
       }