Remove erroneous ASSERT for format lists
VK_KHR_image_format_list is supported by SwiftShader, yet an ASSERT was
left in to guard against it being used. Nothing needs to replace the
ASSERT as SwiftShader does not benefit from knowing which formats are
used, and it's the job of a validation layer to ensure that a user isn't
using a format they said they wouldn't.
Bug: b/198327618
Change-Id: I6c8133f8fe57161fb2ce4757023861b052639510
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/56768
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Sean Risser <srisser@google.com>
Commit-Queue: Sean Risser <srisser@google.com>
diff --git a/src/Vulkan/libVulkan.cpp b/src/Vulkan/libVulkan.cpp
index c42ca2d4..2a49a55 100644
--- a/src/Vulkan/libVulkan.cpp
+++ b/src/Vulkan/libVulkan.cpp
@@ -3292,8 +3292,14 @@
{
case VK_STRUCTURE_TYPE_IMAGE_FORMAT_LIST_CREATE_INFO_KHR:
{
- // Explicitly ignored, since VK_KHR_image_format_list is not supported
- ASSERT(!hasDeviceExtension(VK_KHR_IMAGE_FORMAT_LIST_EXTENSION_NAME));
+ // Per the Vulkan spec on VkImageFormatListcreateInfo:
+ // "If the pNext chain of VkImageCreateInfo includes a
+ // VkImageFormatListCreateInfo structure, then that
+ // structure contains a list of all formats that can be
+ // used when creating views of this image"
+ // This limitation does not affect SwiftShader's behavior and
+ // the Vulkan Validation Layers can detect Views created with a
+ // format which is not included in that list.
}
break;
case VK_STRUCTURE_TYPE_IMAGE_STENCIL_USAGE_CREATE_INFO:
