commit bdb6807825ac8479b9dc3fe5fdc58caae294f21b
author Alexis Hetu <sugoi@google.com> Mon Apr 06 15:19:27 2020 -0400
committer Alexis Hétu <sugoi@google.com> Mon Apr 06 20:43:27 2020 +0000
tree 87f9ab3bf1cb44113519c6647801107917287643
parent 3942f5cbdde7fa79ad27bb13d759d9229752950d

Don't blend integer formats

True integer formats should not use blend modes.
This cl explicitly disables any blend operation
on render targets using integer formats.

Bug: b/153203552
Change-Id: Ia756953c61caef8e32e55aa31126044973ae1870
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43548
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

src/Pipeline/PixelRoutine.cpp

diff --git a/src/Pipeline/PixelRoutine.cpp b/src/Pipeline/PixelRoutine.cpp
index 26ed5b5..25325fb 100644
--- a/src/Pipeline/PixelRoutine.cpp
+++ b/src/Pipeline/PixelRoutine.cpp
@@ -1109,7 +1109,7 @@
 
 void PixelRoutine::alphaBlend(int index, const Pointer<Byte> &cBuffer, Vector4s &current, const Int &x)
 {
-	if(!state.blendState[index].alphaBlendEnable)
+	if(!state.blendState[index].alphaBlendEnable || vk::Format(state.targetFormat[index]).isUnnormalizedInteger())
 	{
 		return;
 	}
@@ -1869,7 +1869,7 @@
 
 void PixelRoutine::alphaBlend(int index, const Pointer<Byte> &cBuffer, Vector4f &oC, const Int &x)
 {
-	if(!state.blendState[index].alphaBlendEnable)
+	if(!state.blendState[index].alphaBlendEnable || vk::Format(state.targetFormat[index]).isUnnormalizedInteger())
 	{
 		return;
 	}