| // Copyright (c) 2015-2016 The Khronos Group Inc. | |
| // | |
| // Licensed under the Apache License, Version 2.0 (the "License"); | |
| // you may not use this file except in compliance with the License. | |
| // You may obtain a copy of the License at | |
| // | |
| // http://www.apache.org/licenses/LICENSE-2.0 | |
| // | |
| // Unless required by applicable law or agreed to in writing, software | |
| // distributed under the License is distributed on an "AS IS" BASIS, | |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| // See the License for the specific language governing permissions and | |
| // limitations under the License. | |
| // Validation tests for Control Flow Graph | |
| #include <array> | |
| #include <functional> | |
| #include <sstream> | |
| #include <string> | |
| #include <utility> | |
| #include <vector> | |
| #include "gmock/gmock.h" | |
| #include "source/spirv_target_env.h" | |
| #include "source/val/validate.h" | |
| #include "test/test_fixture.h" | |
| #include "test/unit_spirv.h" | |
| #include "test/val/val_fixtures.h" | |
| namespace spvtools { | |
| namespace val { | |
| namespace { | |
| using ::testing::HasSubstr; | |
| using ::testing::MatchesRegex; | |
| using ValidateCFG = spvtest::ValidateBase<spv::Capability>; | |
| using spvtest::ScopedContext; | |
| std::string nameOps() { return ""; } | |
| template <typename... Args> | |
| std::string nameOps(std::pair<std::string, std::string> head, Args... names) { | |
| return "OpName %" + head.first + " \"" + head.second + "\"\n" + | |
| nameOps(names...); | |
| } | |
| template <typename... Args> | |
| std::string nameOps(std::string head, Args... names) { | |
| return "OpName %" + head + " \"" + head + "\"\n" + nameOps(names...); | |
| } | |
| /// This class allows the easy creation of complex control flow without writing | |
| /// SPIR-V. This class is used in the test cases below. | |
| class Block { | |
| std::string label_; | |
| std::string body_; | |
| spv::Op type_; | |
| std::vector<Block> successors_; | |
| public: | |
| /// Creates a Block with a given label | |
| /// | |
| /// @param[in]: label the label id of the block | |
| /// @param[in]: type the branch instruction that ends the block | |
| explicit Block(std::string label, spv::Op type = spv::Op::OpBranch) | |
| : label_(label), body_(), type_(type), successors_() {} | |
| /// Sets the instructions which will appear in the body of the block | |
| Block& SetBody(std::string body) { | |
| body_ = body; | |
| return *this; | |
| } | |
| Block& AppendBody(std::string body) { | |
| body_ += body; | |
| return *this; | |
| } | |
| /// Converts the block into a SPIR-V string | |
| operator std::string() { | |
| std::stringstream out; | |
| out << std::setw(8) << "%" + label_ + " = OpLabel \n"; | |
| if (!body_.empty()) { | |
| out << body_; | |
| } | |
| switch (type_) { | |
| case spv::Op::OpBranchConditional: | |
| out << "OpBranchConditional %cond "; | |
| for (Block& b : successors_) { | |
| out << "%" + b.label_ + " "; | |
| } | |
| break; | |
| case spv::Op::OpSwitch: { | |
| out << "OpSwitch %one %" + successors_.front().label_; | |
| std::stringstream ss; | |
| for (size_t i = 1; i < successors_.size(); i++) { | |
| ss << " " << i << " %" << successors_[i].label_; | |
| } | |
| out << ss.str(); | |
| } break; | |
| case spv::Op::OpLoopMerge: { | |
| assert(successors_.size() == 2); | |
| out << "OpLoopMerge %" + successors_[0].label_ + " %" + | |
| successors_[0].label_ + "None"; | |
| } break; | |
| case spv::Op::OpReturn: | |
| assert(successors_.size() == 0); | |
| out << "OpReturn\n"; | |
| break; | |
| case spv::Op::OpUnreachable: | |
| assert(successors_.size() == 0); | |
| out << "OpUnreachable\n"; | |
| break; | |
| case spv::Op::OpBranch: | |
| assert(successors_.size() == 1); | |
| out << "OpBranch %" + successors_.front().label_; | |
| break; | |
| case spv::Op::OpKill: | |
| assert(successors_.size() == 0); | |
| out << "OpKill\n"; | |
| break; | |
| default: | |
| assert(1 == 0 && "Unhandled"); | |
| } | |
| out << "\n"; | |
| return out.str(); | |
| } | |
| friend Block& operator>>(Block& curr, std::vector<Block> successors); | |
| friend Block& operator>>(Block& lhs, Block& successor); | |
| }; | |
| /// Assigns the successors for the Block on the lhs | |
| Block& operator>>(Block& lhs, std::vector<Block> successors) { | |
| if (lhs.type_ == spv::Op::OpBranchConditional) { | |
| assert(successors.size() == 2); | |
| } else if (lhs.type_ == spv::Op::OpSwitch) { | |
| assert(successors.size() > 1); | |
| } | |
| lhs.successors_ = successors; | |
| return lhs; | |
| } | |
| /// Assigns the successor for the Block on the lhs | |
| Block& operator>>(Block& lhs, Block& successor) { | |
| assert(lhs.type_ == spv::Op::OpBranch); | |
| lhs.successors_.push_back(successor); | |
| return lhs; | |
| } | |
| const std::string& GetDefaultHeader(spv::Capability cap) { | |
| static const std::string shader_header = | |
| "OpCapability Shader\n" | |
| "OpCapability Linkage\n" | |
| "OpMemoryModel Logical GLSL450\n"; | |
| static const std::string kernel_header = | |
| "OpCapability Kernel\n" | |
| "OpCapability Linkage\n" | |
| "OpMemoryModel Logical OpenCL\n"; | |
| return (cap == spv::Capability::Shader) ? shader_header : kernel_header; | |
| } | |
| const std::string& types_consts() { | |
| static const std::string types = | |
| "%voidt = OpTypeVoid\n" | |
| "%boolt = OpTypeBool\n" | |
| "%intt = OpTypeInt 32 0\n" | |
| "%one = OpConstant %intt 1\n" | |
| "%two = OpConstant %intt 2\n" | |
| "%ptrt = OpTypePointer Function %intt\n" | |
| "%funct = OpTypeFunction %voidt\n"; | |
| return types; | |
| } | |
| INSTANTIATE_TEST_SUITE_P(StructuredControlFlow, ValidateCFG, | |
| ::testing::Values(spv::Capability::Shader, | |
| spv::Capability::Kernel)); | |
| TEST_P(ValidateCFG, LoopReachableFromEntryButNeverLeadingToReturn) { | |
| // In this case, the loop is reachable from a node without a predecessor, | |
| // but never reaches a node with a return. | |
| // | |
| // This motivates the need for the pseudo-exit node to have a node | |
| // from a cycle in its predecessors list. Otherwise the validator's | |
| // post-dominance calculation will go into an infinite loop. | |
| // | |
| // For more motivation, see | |
| // https://github.com/KhronosGroup/SPIRV-Tools/issues/279 | |
| std::string str = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %entry "entry" | |
| OpName %loop "loop" | |
| OpName %exit "exit" | |
| %voidt = OpTypeVoid | |
| %funct = OpTypeFunction %voidt | |
| %main = OpFunction %voidt None %funct | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %exit %loop None | |
| OpBranch %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()) << str; | |
| } | |
| TEST_P(ValidateCFG, LoopUnreachableFromEntryButLeadingToReturn) { | |
| // In this case, the loop is not reachable from a node without a | |
| // predecessor, but eventually reaches a node with a return. | |
| // | |
| // This motivates the need for the pseudo-entry node to have a node | |
| // from a cycle in its successors list. Otherwise the validator's | |
| // dominance calculation will go into an infinite loop. | |
| // | |
| // For more motivation, see | |
| // https://github.com/KhronosGroup/SPIRV-Tools/issues/279 | |
| // Before that fix, we'd have an infinite loop when calculating | |
| // post-dominators. | |
| std::string str = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %entry "entry" | |
| OpName %loop "loop" | |
| OpName %cont "cont" | |
| OpName %exit "exit" | |
| %voidt = OpTypeVoid | |
| %funct = OpTypeFunction %voidt | |
| %boolt = OpTypeBool | |
| %false = OpConstantFalse %boolt | |
| %main = OpFunction %voidt None %funct | |
| %entry = OpLabel | |
| OpReturn | |
| %loop = OpLabel | |
| OpLoopMerge %exit %cont None | |
| OpBranch %cont | |
| %cont = OpLabel | |
| OpBranchConditional %false %loop %exit | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()) | |
| << str << getDiagnosticString(); | |
| } | |
| TEST_P(ValidateCFG, Simple) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop", spv::Op::OpBranchConditional); | |
| Block cont("cont"); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) { | |
| loop.SetBody("OpLoopMerge %merge %cont None\n"); | |
| } | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("loop", "entry", "cont", "merge", | |
| std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| str += loop >> std::vector<Block>({cont, merge}); | |
| str += cont >> loop; | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_P(ValidateCFG, Variable) { | |
| Block entry("entry"); | |
| Block cont("cont"); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%var = OpVariable %ptrt Function\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps(std::make_pair("func", "Main")) + types_consts() + | |
| " %func = OpFunction %voidt None %funct\n"; | |
| str += entry >> cont; | |
| str += cont >> exit; | |
| str += exit; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_P(ValidateCFG, VariableNotInFirstBlockBad) { | |
| Block entry("entry"); | |
| Block cont("cont"); | |
| Block exit("exit", spv::Op::OpReturn); | |
| // This operation should only be performed in the entry block | |
| cont.SetBody("%var = OpVariable %ptrt Function\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps(std::make_pair("func", "Main")) + types_consts() + | |
| " %func = OpFunction %voidt None %funct\n"; | |
| str += entry >> cont; | |
| str += cont >> exit; | |
| str += exit; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_ERROR_INVALID_DATA, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("All OpVariable instructions in a function must be the " | |
| "first instructions in the first block")); | |
| } | |
| TEST_P(ValidateCFG, BlockSelfLoopIsOk) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop", spv::Op::OpBranchConditional); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) loop.SetBody("OpLoopMerge %merge %loop None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("loop", "merge", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| // loop branches to itself, but does not trigger an error. | |
| str += loop >> std::vector<Block>({merge, loop}); | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()) << getDiagnosticString(); | |
| } | |
| TEST_P(ValidateCFG, BlockAppearsBeforeDominatorBad) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block cont("cont"); | |
| Block branch("branch", spv::Op::OpBranchConditional); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) branch.SetBody("OpSelectionMerge %merge None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("cont", "branch", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += cont >> merge; // cont appears before its dominator | |
| str += branch >> std::vector<Block>({cont, merge}); | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| MatchesRegex("Block '.\\[%cont\\]' appears in the binary " | |
| "before its dominator '.\\[%branch\\]'\n" | |
| " %branch = OpLabel\n")); | |
| } | |
| TEST_P(ValidateCFG, MergeBlockTargetedByMultipleHeaderBlocksBad) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop"); | |
| Block selection("selection", spv::Op::OpBranchConditional); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) loop.SetBody(" OpLoopMerge %merge %loop None\n"); | |
| // cannot share the same merge | |
| if (is_shader) selection.SetBody("OpSelectionMerge %merge None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("merge", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| str += loop >> selection; | |
| str += selection >> std::vector<Block>({loop, merge}); | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| MatchesRegex("Block '.\\[%merge\\]' is already a merge block " | |
| "for another header\n" | |
| " %Main = OpFunction %void None %9\n")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, MergeBlockTargetedByMultipleHeaderBlocksSelectionBad) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop", spv::Op::OpBranchConditional); | |
| Block selection("selection", spv::Op::OpBranchConditional); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) selection.SetBody(" OpSelectionMerge %merge None\n"); | |
| // cannot share the same merge | |
| if (is_shader) loop.SetBody(" OpLoopMerge %merge %loop None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("merge", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> selection; | |
| str += selection >> std::vector<Block>({merge, loop}); | |
| str += loop >> std::vector<Block>({loop, merge}); | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| MatchesRegex("Block '.\\[%merge\\]' is already a merge block " | |
| "for another header\n" | |
| " %Main = OpFunction %void None %9\n")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, BranchTargetFirstBlockBadSinceEntryBlock) { | |
| Block entry("entry"); | |
| Block bad("bad"); | |
| Block end("end", spv::Op::OpReturn); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("entry", "bad", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> bad; | |
| str += bad >> entry; // Cannot target entry block | |
| str += end; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| MatchesRegex("First block '.\\[%entry\\]' of function " | |
| "'.\\[%Main\\]' is targeted by block '.\\[%bad\\]'\n" | |
| " %Main = OpFunction %void None %10\n")); | |
| } | |
| TEST_P(ValidateCFG, BranchTargetFirstBlockBadSinceValue) { | |
| Block entry("entry"); | |
| entry.SetBody("%undef = OpUndef %boolt\n"); | |
| Block bad("bad"); | |
| Block end("end", spv::Op::OpReturn); | |
| Block badvalue("undef"); // This references the OpUndef. | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("entry", "bad", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> bad; | |
| str += | |
| bad >> badvalue; // Check branch to a function value (it's not a block!) | |
| str += end; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("'Target Label' operands for OpBranch must " | |
| "be the ID of an OpLabel instruction")); | |
| } | |
| TEST_P(ValidateCFG, BranchConditionalTrueTargetFirstBlockBad) { | |
| Block entry("entry"); | |
| Block bad("bad", spv::Op::OpBranchConditional); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| bad.SetBody(" OpLoopMerge %entry %exit None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("entry", "bad", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> bad; | |
| str += bad >> std::vector<Block>({entry, exit}); // cannot target entry block | |
| str += exit; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex("First block '.\\[%entry\\]' of function '.\\[%Main\\]' " | |
| "is targeted by block '.\\[%bad\\]'\n" | |
| " %Main = OpFunction %void None %10\n")); | |
| } | |
| TEST_P(ValidateCFG, BranchConditionalFalseTargetFirstBlockBad) { | |
| Block entry("entry"); | |
| Block bad("bad", spv::Op::OpBranchConditional); | |
| Block t("t"); | |
| Block merge("merge"); | |
| Block end("end", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| bad.SetBody("OpLoopMerge %merge %cont None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("entry", "bad", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> bad; | |
| str += bad >> std::vector<Block>({t, entry}); | |
| str += merge >> end; | |
| str += end; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex("First block '.\\[%entry\\]' of function '.\\[%Main\\]' " | |
| "is targeted by block '.\\[%bad\\]'\n" | |
| " %Main = OpFunction %void None %10\n")); | |
| } | |
| TEST_P(ValidateCFG, SwitchTargetFirstBlockBad) { | |
| Block entry("entry"); | |
| Block bad("bad", spv::Op::OpSwitch); | |
| Block block1("block1"); | |
| Block block2("block2"); | |
| Block block3("block3"); | |
| Block def("def"); // default block | |
| Block merge("merge"); | |
| Block end("end", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| bad.SetBody("OpSelectionMerge %merge None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("entry", "bad", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> bad; | |
| str += bad >> std::vector<Block>({def, block1, block2, block3, entry}); | |
| str += def >> merge; | |
| str += block1 >> merge; | |
| str += block2 >> merge; | |
| str += block3 >> merge; | |
| str += merge >> end; | |
| str += end; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex("First block '.\\[%entry\\]' of function '.\\[%Main\\]' " | |
| "is targeted by block '.\\[%bad\\]'\n" | |
| " %Main = OpFunction %void None %10\n")); | |
| } | |
| TEST_P(ValidateCFG, BranchToBlockInOtherFunctionBad) { | |
| Block entry("entry"); | |
| Block middle("middle", spv::Op::OpBranchConditional); | |
| Block end("end", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| middle.SetBody("OpSelectionMerge %end None\n"); | |
| Block entry2("entry2"); | |
| Block middle2("middle2"); | |
| Block end2("end2", spv::Op::OpReturn); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("middle2", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> middle; | |
| str += middle >> std::vector<Block>({end, middle2}); | |
| str += end; | |
| str += "OpFunctionEnd\n"; | |
| str += "%func2 = OpFunction %voidt None %funct\n"; | |
| str += entry2 >> middle2; | |
| str += middle2 >> end2; | |
| str += end2; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| MatchesRegex( | |
| "Block\\(s\\) \\{'.\\[%middle2\\]'\\} are referenced but not " | |
| "defined in function '.\\[%Main\\]'\n" | |
| " %Main = OpFunction %void None %9\n")); | |
| } | |
| TEST_P(ValidateCFG, HeaderDoesntStrictlyDominateMergeBad) { | |
| // If a merge block is reachable, then it must be strictly dominated by | |
| // its header block. | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block head("head", spv::Op::OpBranchConditional); | |
| Block exit("exit", spv::Op::OpReturn); | |
| head.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) head.AppendBody("OpSelectionMerge %head None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("head", "exit", std::make_pair("func", "Main")) + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += head >> std::vector<Block>({exit, exit}); | |
| str += exit; | |
| str += "OpFunctionEnd\n"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex( | |
| "The selection construct with the selection header " | |
| "'.\\[%head\\]' does not strictly structurally dominate the " | |
| "merge block " | |
| "'.\\[%head\\]'\n %head = OpLabel\n")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()) << str; | |
| } | |
| } | |
| std::string GetUnreachableMergeNoMergeInst(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranchConditional); | |
| Block t("t", spv::Op::OpReturn); | |
| Block f("f", spv::Op::OpReturn); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (cap == spv::Capability::Shader) | |
| branch.AppendBody("OpSelectionMerge %merge None\n"); | |
| std::string str = header; | |
| str += nameOps("branch", "merge", std::make_pair("func", "Main")); | |
| str += types_consts() + "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({t, f}); | |
| str += t; | |
| str += f; | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableMergeNoMergeInst) { | |
| CompileSuccessfully(GetUnreachableMergeNoMergeInst(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableMergeTerminatedBy(spv::Capability cap, spv::Op op) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranchConditional); | |
| Block t("t", spv::Op::OpReturn); | |
| Block f("f", spv::Op::OpReturn); | |
| Block merge("merge", op); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) | |
| branch.AppendBody("OpSelectionMerge %merge None\n"); | |
| str += nameOps("branch", "merge", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({t, f}); | |
| str += t; | |
| str += f; | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableMergeTerminatedByOpUnreachable) { | |
| CompileSuccessfully( | |
| GetUnreachableMergeTerminatedBy(GetParam(), spv::Op::OpUnreachable)); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, UnreachableMergeTerminatedByOpKill) { | |
| CompileSuccessfully(GetUnreachableMergeTerminatedBy(spv::Capability::Shader, | |
| spv::Op::OpKill)); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_P(ValidateCFG, UnreachableMergeTerminatedByOpReturn) { | |
| CompileSuccessfully( | |
| GetUnreachableMergeTerminatedBy(GetParam(), spv::Op::OpReturn)); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableContinueTerminatedBy(spv::Capability cap, | |
| spv::Op op) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranch); | |
| Block merge("merge", spv::Op::OpReturn); | |
| Block target("target", op); | |
| if (op == spv::Op::OpBranch) target >> branch; | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) | |
| branch.AppendBody("OpLoopMerge %merge %target None\n"); | |
| str += nameOps("branch", "merge", "target", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({merge}); | |
| str += merge; | |
| str += target; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableContinueTerminatedByOpUnreachable) { | |
| CompileSuccessfully( | |
| GetUnreachableContinueTerminatedBy(GetParam(), spv::Op::OpUnreachable)); | |
| if (GetParam() == spv::Capability::Shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("targeted by 0 back-edge blocks")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_F(ValidateCFG, UnreachableContinueTerminatedByOpKill) { | |
| CompileSuccessfully(GetUnreachableContinueTerminatedBy( | |
| spv::Capability::Shader, spv::Op::OpKill)); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("targeted by 0 back-edge blocks")); | |
| } | |
| TEST_P(ValidateCFG, UnreachableContinueTerminatedByOpReturn) { | |
| CompileSuccessfully( | |
| GetUnreachableContinueTerminatedBy(GetParam(), spv::Op::OpReturn)); | |
| if (GetParam() == spv::Capability::Shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("targeted by 0 back-edge blocks")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, UnreachableContinueTerminatedByOpBranch) { | |
| CompileSuccessfully( | |
| GetUnreachableContinueTerminatedBy(GetParam(), spv::Op::OpBranch)); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableMergeUnreachableMergeInst(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block body("body", spv::Op::OpReturn); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranchConditional); | |
| Block t("t", spv::Op::OpReturn); | |
| Block f("f", spv::Op::OpReturn); | |
| Block merge("merge", spv::Op::OpUnreachable); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) | |
| branch.AppendBody("OpSelectionMerge %merge None\n"); | |
| str += nameOps("branch", "merge", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += body; | |
| str += merge; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({t, f}); | |
| str += t; | |
| str += f; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableMergeUnreachableMergeInst) { | |
| CompileSuccessfully(GetUnreachableMergeUnreachableMergeInst(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableContinueUnreachableLoopInst(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block body("body", spv::Op::OpReturn); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranch); | |
| Block merge("merge", spv::Op::OpReturn); | |
| Block target("target", spv::Op::OpBranch); | |
| target >> branch; | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) | |
| branch.AppendBody("OpLoopMerge %merge %target None\n"); | |
| str += nameOps("branch", "merge", "target", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += body; | |
| str += target; | |
| str += merge; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({merge}); | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableContinueUnreachableLoopInst) { | |
| CompileSuccessfully(GetUnreachableContinueUnreachableLoopInst(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableMergeWithComplexBody(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranchConditional); | |
| Block t("t", spv::Op::OpReturn); | |
| Block f("f", spv::Op::OpReturn); | |
| Block merge("merge", spv::Op::OpUnreachable); | |
| entry.AppendBody("%placeholder = OpVariable %intptrt Function\n"); | |
| entry.AppendBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| merge.AppendBody("OpStore %placeholder %one\n"); | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) | |
| branch.AppendBody("OpSelectionMerge %merge None\n"); | |
| str += nameOps("branch", "merge", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%intptrt = OpTypePointer Function %intt\n"; | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({t, f}); | |
| str += t; | |
| str += f; | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableMergeWithComplexBody) { | |
| CompileSuccessfully(GetUnreachableMergeWithComplexBody(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableContinueWithComplexBody(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranch); | |
| Block merge("merge", spv::Op::OpReturn); | |
| Block target("target", spv::Op::OpBranch); | |
| target >> branch; | |
| entry.AppendBody("%placeholder = OpVariable %intptrt Function\n"); | |
| target.AppendBody("OpStore %placeholder %one\n"); | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) | |
| branch.AppendBody("OpLoopMerge %merge %target None\n"); | |
| str += nameOps("branch", "merge", "target", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%intptrt = OpTypePointer Function %intt\n"; | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({merge}); | |
| str += merge; | |
| str += target; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableContinueWithComplexBody) { | |
| CompileSuccessfully(GetUnreachableContinueWithComplexBody(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableMergeWithBranchUse(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranchConditional); | |
| Block t("t", spv::Op::OpBranch); | |
| Block f("f", spv::Op::OpReturn); | |
| Block merge("merge", spv::Op::OpUnreachable); | |
| entry.AppendBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) | |
| branch.AppendBody("OpSelectionMerge %merge None\n"); | |
| str += nameOps("branch", "merge", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({t, f}); | |
| str += t >> merge; | |
| str += f; | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableMergeWithBranchUse) { | |
| CompileSuccessfully(GetUnreachableMergeWithBranchUse(GetParam())); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableMergeWithMultipleUses(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranchConditional); | |
| Block t("t", spv::Op::OpReturn); | |
| Block f("f", spv::Op::OpReturn); | |
| Block merge("merge", spv::Op::OpUnreachable); | |
| Block duplicate("duplicate", spv::Op::OpBranchConditional); | |
| entry.AppendBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) { | |
| branch.AppendBody("OpSelectionMerge %merge None\n"); | |
| duplicate.AppendBody("OpSelectionMerge %merge None\n"); | |
| } | |
| str += nameOps("branch", "merge", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({t, f}); | |
| str += duplicate >> std::vector<Block>({t, f}); | |
| str += t; | |
| str += f; | |
| str += merge; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableMergeWithMultipleUses) { | |
| CompileSuccessfully(GetUnreachableMergeWithMultipleUses(GetParam())); | |
| if (GetParam() == spv::Capability::Shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("is already a merge block for another header")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| std::string GetUnreachableContinueWithBranchUse(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranch); | |
| Block merge("merge", spv::Op::OpReturn); | |
| Block target("target", spv::Op::OpBranch); | |
| target >> branch; | |
| entry.AppendBody("%placeholder = OpVariable %intptrt Function\n"); | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) | |
| branch.AppendBody("OpLoopMerge %merge %target None\n"); | |
| str += nameOps("branch", "merge", "target", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%intptrt = OpTypePointer Function %intt\n"; | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({merge}); | |
| str += merge; | |
| str += target; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableContinueWithBranchUse) { | |
| CompileSuccessfully(GetUnreachableContinueWithBranchUse(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetReachableMergeAndContinue(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranch); | |
| Block merge("merge", spv::Op::OpReturn); | |
| Block target("target", spv::Op::OpBranch); | |
| Block body("body", spv::Op::OpBranchConditional); | |
| Block t("t", spv::Op::OpBranch); | |
| Block f("f", spv::Op::OpBranch); | |
| target >> branch; | |
| body.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| t >> merge; | |
| f >> target; | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) { | |
| branch.AppendBody("OpLoopMerge %merge %target None\n"); | |
| body.AppendBody("OpSelectionMerge %f None\n"); | |
| } | |
| str += nameOps("branch", "merge", "target", "body", "t", "f", | |
| std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({body}); | |
| str += body >> std::vector<Block>({t, f}); | |
| str += t; | |
| str += f; | |
| str += merge; | |
| str += target; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, ReachableMergeAndContinue) { | |
| CompileSuccessfully(GetReachableMergeAndContinue(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableMergeAndContinue(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block branch("branch", spv::Op::OpBranch); | |
| Block merge("merge", spv::Op::OpReturn); | |
| Block target("target", spv::Op::OpBranch); | |
| Block body("body", spv::Op::OpBranchConditional); | |
| Block t("t", spv::Op::OpReturn); | |
| Block f("f", spv::Op::OpReturn); | |
| Block pre_target("pre_target", spv::Op::OpBranch); | |
| target >> branch; | |
| body.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| std::string str = header; | |
| if (cap == spv::Capability::Shader) { | |
| branch.AppendBody("OpLoopMerge %merge %target None\n"); | |
| body.AppendBody("OpSelectionMerge %pre_target None\n"); | |
| } | |
| str += nameOps("branch", "merge", "pre_target", "target", "body", "t", "f", | |
| std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> branch; | |
| str += branch >> std::vector<Block>({body}); | |
| str += body >> std::vector<Block>({t, f}); | |
| str += t; | |
| str += f; | |
| str += merge; | |
| str += pre_target >> target; | |
| str += target; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableMergeAndContinue) { | |
| CompileSuccessfully(GetUnreachableMergeAndContinue(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableBlock(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block unreachable("unreachable"); | |
| Block exit("exit", spv::Op::OpReturn); | |
| std::string str = header; | |
| str += nameOps("unreachable", "exit", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> exit; | |
| str += unreachable >> exit; | |
| str += exit; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableBlock) { | |
| CompileSuccessfully(GetUnreachableBlock(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| std::string GetUnreachableBranch(spv::Capability cap) { | |
| std::string header = GetDefaultHeader(cap); | |
| Block entry("entry"); | |
| Block unreachable("unreachable", spv::Op::OpBranchConditional); | |
| Block unreachablechildt("unreachablechildt"); | |
| Block unreachablechildf("unreachablechildf"); | |
| Block merge("merge"); | |
| Block exit("exit", spv::Op::OpReturn); | |
| unreachable.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (cap == spv::Capability::Shader) | |
| unreachable.AppendBody("OpSelectionMerge %merge None\n"); | |
| std::string str = header; | |
| str += nameOps("unreachable", "exit", std::make_pair("func", "Main")); | |
| str += types_consts(); | |
| str += "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> exit; | |
| str += | |
| unreachable >> std::vector<Block>({unreachablechildt, unreachablechildf}); | |
| str += unreachablechildt >> merge; | |
| str += unreachablechildf >> merge; | |
| str += merge >> exit; | |
| str += exit; | |
| str += "OpFunctionEnd\n"; | |
| return str; | |
| } | |
| TEST_P(ValidateCFG, UnreachableBranch) { | |
| CompileSuccessfully(GetUnreachableBranch(GetParam())); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_P(ValidateCFG, EmptyFunction) { | |
| std::string str = GetDefaultHeader(GetParam()) + std::string(types_consts()) + | |
| R"(%func = OpFunction %voidt None %funct | |
| %l = OpLabel | |
| OpReturn | |
| OpFunctionEnd)"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_P(ValidateCFG, SingleBlockLoop) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop", spv::Op::OpBranchConditional); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) loop.AppendBody("OpLoopMerge %exit %loop None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + std::string(types_consts()) + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| str += loop >> std::vector<Block>({loop, exit}); | |
| str += exit; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_P(ValidateCFG, NestedLoops) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop1("loop1"); | |
| Block loop1_cont_break_block("loop1_cont_break_block", | |
| spv::Op::OpBranchConditional); | |
| Block loop2("loop2", spv::Op::OpBranchConditional); | |
| Block loop2_merge("loop2_merge"); | |
| Block loop1_merge("loop1_merge"); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) { | |
| loop1.SetBody("OpLoopMerge %loop1_merge %loop2 None\n"); | |
| loop2.SetBody("OpLoopMerge %loop2_merge %loop2 None\n"); | |
| } | |
| std::string str = | |
| GetDefaultHeader(GetParam()) + | |
| nameOps("loop1", "loop1_cont_break_block", "loop2", "loop2_merge") + | |
| types_consts() + "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop1; | |
| str += loop1 >> loop1_cont_break_block; | |
| str += loop1_cont_break_block >> std::vector<Block>({loop1_merge, loop2}); | |
| str += loop2 >> std::vector<Block>({loop2, loop2_merge}); | |
| str += loop2_merge >> loop1; | |
| str += loop1_merge >> exit; | |
| str += exit; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_P(ValidateCFG, NestedSelection) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| const int N = 256; | |
| std::vector<Block> if_blocks; | |
| std::vector<Block> merge_blocks; | |
| Block inner("inner"); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if_blocks.emplace_back("if0", spv::Op::OpBranchConditional); | |
| if (is_shader) if_blocks[0].SetBody("OpSelectionMerge %if_merge0 None\n"); | |
| merge_blocks.emplace_back("if_merge0", spv::Op::OpReturn); | |
| for (int i = 1; i < N; i++) { | |
| std::stringstream ss; | |
| ss << i; | |
| if_blocks.emplace_back("if" + ss.str(), spv::Op::OpBranchConditional); | |
| if (is_shader) | |
| if_blocks[i].SetBody("OpSelectionMerge %if_merge" + ss.str() + " None\n"); | |
| merge_blocks.emplace_back("if_merge" + ss.str(), spv::Op::OpBranch); | |
| } | |
| std::string str = GetDefaultHeader(GetParam()) + std::string(types_consts()) + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> if_blocks[0]; | |
| for (int i = 0; i < N - 1; i++) { | |
| str += | |
| if_blocks[i] >> std::vector<Block>({if_blocks[i + 1], merge_blocks[i]}); | |
| } | |
| str += if_blocks.back() >> std::vector<Block>({inner, merge_blocks.back()}); | |
| str += inner >> merge_blocks.back(); | |
| for (int i = N - 1; i > 0; i--) { | |
| str += merge_blocks[i] >> merge_blocks[i - 1]; | |
| } | |
| str += merge_blocks[0]; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_P(ValidateCFG, BackEdgeBlockDoesntPostDominateContinueTargetBad) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop1("loop1", spv::Op::OpBranchConditional); | |
| Block loop2("loop2", spv::Op::OpBranchConditional); | |
| Block loop2_merge("loop2_merge"); | |
| Block loop1_cont("loop1_cont", spv::Op::OpBranchConditional); | |
| Block be_block("be_block"); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) { | |
| loop1.SetBody("OpLoopMerge %exit %loop1_cont None\n"); | |
| loop2.SetBody("OpLoopMerge %loop2_merge %loop2 None\n"); | |
| } | |
| std::string str = | |
| GetDefaultHeader(GetParam()) + | |
| nameOps("loop1", "loop2", "be_block", "loop1_cont", "loop2_merge") + | |
| types_consts() + "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop1; | |
| str += loop1 >> std::vector<Block>({loop2, exit}); | |
| str += loop2 >> std::vector<Block>({loop2, loop2_merge}); | |
| str += loop2_merge >> loop1_cont; | |
| str += loop1_cont >> std::vector<Block>({be_block, exit}); | |
| str += be_block >> loop1; | |
| str += exit; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| if (GetParam() == spv::Capability::Shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex( | |
| "The continue construct with the continue target " | |
| "'.\\[%loop1_cont\\]' is not structurally post dominated by the " | |
| "back-edge block '.\\[%be_block\\]'\n" | |
| " %be_block = OpLabel\n")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, BranchingToNonLoopHeaderBlockBad) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block split("split", spv::Op::OpBranchConditional); | |
| Block t("t"); | |
| Block f("f"); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) split.SetBody("OpSelectionMerge %exit None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + nameOps("split", "f") + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> split; | |
| str += split >> std::vector<Block>({t, f}); | |
| str += t >> exit; | |
| str += f >> split; | |
| str += exit; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex("Back-edges \\('.\\[%f\\]' -> '.\\[%split\\]'\\) can only " | |
| "be formed between a block and a loop header.\n" | |
| " %f = OpLabel\n")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, BranchingToSameNonLoopHeaderBlockBad) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block split("split", spv::Op::OpBranchConditional); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) split.SetBody("OpSelectionMerge %exit None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + nameOps("split") + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> split; | |
| str += split >> std::vector<Block>({split, exit}); | |
| str += exit; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex( | |
| "Back-edges \\('.\\[%split\\]' -> '.\\[%split\\]'\\) can only be " | |
| "formed between a block and a loop header.\n %split = OpLabel\n")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, MultipleBackEdgeBlocksToLoopHeaderBad) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop", spv::Op::OpBranchConditional); | |
| Block back0("back0"); | |
| Block back1("back1"); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) loop.SetBody("OpLoopMerge %merge %back0 None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("loop", "back0", "back1") + types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| str += loop >> std::vector<Block>({back0, back1}); | |
| str += back0 >> loop; | |
| str += back1 >> loop; | |
| str += merge; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex( | |
| "Loop header '.\\[%loop\\]' is targeted by 2 back-edge blocks but " | |
| "the standard requires exactly one\n %loop = OpLabel\n")) | |
| << str; | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, ContinueTargetMustBePostDominatedByBackEdge) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop", spv::Op::OpBranchConditional); | |
| Block cheader("cheader", spv::Op::OpBranchConditional); | |
| Block be_block("be_block"); | |
| Block merge("merge", spv::Op::OpReturn); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) loop.SetBody("OpLoopMerge %merge %cheader None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("cheader", "be_block") + types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| str += loop >> std::vector<Block>({cheader, merge}); | |
| str += cheader >> std::vector<Block>({exit, be_block}); | |
| str += exit; // Branches out of a continue construct | |
| str += be_block >> loop; | |
| str += merge; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex( | |
| "The continue construct with the continue target " | |
| "'.\\[%cheader\\]' is not structurally post dominated by the " | |
| "back-edge block '.\\[%be_block\\]'\n" | |
| " %be_block = OpLabel\n")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, BranchOutOfConstructToMergeBad) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop", spv::Op::OpBranchConditional); | |
| Block cont("cont", spv::Op::OpBranchConditional); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) loop.SetBody("OpLoopMerge %merge %loop None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + nameOps("cont", "loop") + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| str += loop >> std::vector<Block>({cont, merge}); | |
| str += cont >> std::vector<Block>({loop, merge}); | |
| str += merge; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex("The continue construct with the continue target " | |
| "'.\\[%loop\\]' is not structurally post dominated by the " | |
| "back-edge block '.\\[%cont\\]'\n" | |
| " %cont = OpLabel\n")) | |
| << str; | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, BranchOutOfConstructBad) { | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop", spv::Op::OpBranchConditional); | |
| Block cont("cont", spv::Op::OpBranchConditional); | |
| Block merge("merge"); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) loop.SetBody("OpLoopMerge %merge %loop None\n"); | |
| std::string str = GetDefaultHeader(GetParam()) + nameOps("cont", "loop") + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| str += loop >> std::vector<Block>({cont, merge}); | |
| str += cont >> std::vector<Block>({loop, exit}); | |
| str += merge >> exit; | |
| str += exit; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex("The continue construct with the continue target " | |
| "'.\\[%loop\\]' is not structurally post dominated by the " | |
| "back-edge block '.\\[%cont\\]'\n" | |
| " %cont = OpLabel\n")); | |
| } else { | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_F(ValidateCFG, OpSwitchToUnreachableBlock) { | |
| Block entry("entry", spv::Op::OpSwitch); | |
| Block case0("case0"); | |
| Block case1("case1"); | |
| Block case2("case2"); | |
| Block def("default", spv::Op::OpUnreachable); | |
| Block phi("phi", spv::Op::OpReturn); | |
| std::string str = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %main "main" %id | |
| OpExecutionMode %main LocalSize 1 1 1 | |
| OpSource GLSL 430 | |
| OpName %main "main" | |
| OpDecorate %id BuiltIn GlobalInvocationId | |
| %void = OpTypeVoid | |
| %voidf = OpTypeFunction %void | |
| %u32 = OpTypeInt 32 0 | |
| %f32 = OpTypeFloat 32 | |
| %uvec3 = OpTypeVector %u32 3 | |
| %fvec3 = OpTypeVector %f32 3 | |
| %uvec3ptr = OpTypePointer Input %uvec3 | |
| %id = OpVariable %uvec3ptr Input | |
| %one = OpConstant %u32 1 | |
| %three = OpConstant %u32 3 | |
| %main = OpFunction %void None %voidf | |
| )"; | |
| entry.SetBody( | |
| "%idval = OpLoad %uvec3 %id\n" | |
| "%x = OpCompositeExtract %u32 %idval 0\n" | |
| "%selector = OpUMod %u32 %x %three\n" | |
| "OpSelectionMerge %phi None\n"); | |
| str += entry >> std::vector<Block>({def, case0, case1, case2}); | |
| str += case1 >> phi; | |
| str += def; | |
| str += phi; | |
| str += case0 >> phi; | |
| str += case2 >> phi; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, LoopWithZeroBackEdgesBad) { | |
| std::string str = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %main "main" | |
| OpExecutionMode %main OriginUpperLeft | |
| OpName %loop "loop" | |
| %voidt = OpTypeVoid | |
| %funct = OpTypeFunction %voidt | |
| %main = OpFunction %voidt None %funct | |
| %loop = OpLabel | |
| OpLoopMerge %exit %loop None | |
| OpBranch %exit | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(str); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| MatchesRegex("Loop header '.\\[%loop\\]' is targeted by " | |
| "0 back-edge blocks but the standard requires exactly " | |
| "one\n %loop = OpLabel\n")); | |
| } | |
| TEST_F(ValidateCFG, LoopWithBackEdgeFromUnreachableContinueConstructGood) { | |
| std::string str = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %main "main" | |
| OpExecutionMode %main OriginUpperLeft | |
| OpName %loop "loop" | |
| %voidt = OpTypeVoid | |
| %funct = OpTypeFunction %voidt | |
| %floatt = OpTypeFloat 32 | |
| %boolt = OpTypeBool | |
| %one = OpConstant %floatt 1 | |
| %two = OpConstant %floatt 2 | |
| %main = OpFunction %voidt None %funct | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %exit %cont None | |
| OpBranch %16 | |
| %16 = OpLabel | |
| %cond = OpFOrdLessThan %boolt %one %two | |
| OpBranchConditional %cond %body %exit | |
| %body = OpLabel | |
| OpReturn | |
| %cont = OpLabel ; Reachable only from OpLoopMerge ContinueTarget parameter | |
| OpBranch %loop ; Should be considered a back-edge | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(str); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()) << getDiagnosticString(); | |
| } | |
| TEST_P(ValidateCFG, | |
| NestedConstructWithUnreachableMergeBlockBranchingToOuterMergeBlock) { | |
| // Test for https://github.com/KhronosGroup/SPIRV-Tools/issues/297 | |
| // The nested construct has an unreachable merge block. In the | |
| // augmented CFG that merge block | |
| // we still determine that the | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry", spv::Op::OpBranchConditional); | |
| Block inner_head("inner_head", spv::Op::OpBranchConditional); | |
| Block inner_true("inner_true", spv::Op::OpReturn); | |
| Block inner_false("inner_false", spv::Op::OpReturn); | |
| Block inner_merge("inner_merge"); | |
| Block exit("exit", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) { | |
| entry.AppendBody("OpSelectionMerge %exit None\n"); | |
| inner_head.SetBody("OpSelectionMerge %inner_merge None\n"); | |
| } | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("entry", "inner_merge", "exit") + types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> std::vector<Block>({inner_head, exit}); | |
| str += inner_head >> std::vector<Block>({inner_true, inner_false}); | |
| str += inner_true; | |
| str += inner_false; | |
| str += inner_merge >> exit; | |
| str += exit; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()) << getDiagnosticString(); | |
| } | |
| TEST_P(ValidateCFG, ContinueTargetCanBeMergeBlockForNestedStructure) { | |
| // The continue construct cannot be the merge target of a nested selection | |
| // because the loop construct must contain "if_merge" because it contains | |
| // "if_head". | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop"); | |
| Block if_head("if_head", spv::Op::OpBranchConditional); | |
| Block if_true("if_true"); | |
| Block if_merge("if_merge", spv::Op::OpBranchConditional); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) { | |
| loop.SetBody("OpLoopMerge %merge %if_merge None\n"); | |
| if_head.SetBody("OpSelectionMerge %if_merge None\n"); | |
| } | |
| std::string str = | |
| GetDefaultHeader(GetParam()) + | |
| nameOps("entry", "loop", "if_head", "if_true", "if_merge", "merge") + | |
| types_consts() + "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| str += loop >> if_head; | |
| str += if_head >> std::vector<Block>({if_true, if_merge}); | |
| str += if_true >> if_merge; | |
| str += if_merge >> std::vector<Block>({loop, merge}); | |
| str += merge; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| if (is_shader) { | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "Header block '3[%if_head]' is contained in the loop construct " | |
| "headed " | |
| "by '2[%loop]', but its merge block '5[%if_merge]' is not")); | |
| } else { | |
| EXPECT_THAT(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| } | |
| TEST_P(ValidateCFG, SingleLatchBlockMultipleBranchesToLoopHeader) { | |
| // This test case ensures we allow both branches of a loop latch block | |
| // to go back to the loop header. It still counts as a single back edge. | |
| bool is_shader = GetParam() == spv::Capability::Shader; | |
| Block entry("entry"); | |
| Block loop("loop", spv::Op::OpBranchConditional); | |
| Block latch("latch", spv::Op::OpBranchConditional); | |
| Block merge("merge", spv::Op::OpReturn); | |
| entry.SetBody("%cond = OpSLessThan %boolt %one %two\n"); | |
| if (is_shader) { | |
| loop.SetBody("OpLoopMerge %merge %latch None\n"); | |
| } | |
| std::string str = GetDefaultHeader(GetParam()) + | |
| nameOps("entry", "loop", "latch", "merge") + | |
| types_consts() + | |
| "%func = OpFunction %voidt None %funct\n"; | |
| str += entry >> loop; | |
| str += loop >> std::vector<Block>({latch, merge}); | |
| str += latch >> std::vector<Block>({loop, loop}); // This is the key | |
| str += merge; | |
| str += "OpFunctionEnd"; | |
| CompileSuccessfully(str); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()) | |
| << str << getDiagnosticString(); | |
| } | |
| // Unit test to check the case where a basic block is the entry block of 2 | |
| // different constructs. In this case, the basic block is the entry block of a | |
| // continue construct as well as a selection construct. See issue# 517 for more | |
| // details. | |
| TEST_F(ValidateCFG, BasicBlockIsEntryBlockOfTwoConstructsGood) { | |
| std::string spirv = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %int = OpTypeInt 32 1 | |
| %void_func = OpTypeFunction %void | |
| %int_0 = OpConstant %int 0 | |
| %testfun = OpFunction %void None %void_func | |
| %label_1 = OpLabel | |
| OpBranch %start | |
| %start = OpLabel | |
| %cond = OpSLessThan %bool %int_0 %int_0 | |
| ; | |
| ; Note: In this case, the "target" block is both the entry block of | |
| ; the continue construct of the loop as well as the entry block of | |
| ; the selection construct. | |
| ; | |
| OpLoopMerge %loop_merge %target None | |
| OpBranchConditional %cond %target %loop_merge | |
| %loop_merge = OpLabel | |
| OpReturn | |
| %target = OpLabel | |
| OpSelectionMerge %selection_merge None | |
| OpBranchConditional %cond %do_stuff %do_other_stuff | |
| %do_other_stuff = OpLabel | |
| OpBranch %selection_merge | |
| %selection_merge = OpLabel | |
| OpBranch %start | |
| %do_stuff = OpLabel | |
| OpBranch %selection_merge | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(spirv); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, OpReturnInNonVoidFunc) { | |
| std::string spirv = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %int = OpTypeInt 32 1 | |
| %int_func = OpTypeFunction %int | |
| %testfun = OpFunction %int None %int_func | |
| %label_1 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(spirv); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "OpReturn can only be called from a function with void return type.\n" | |
| " OpReturn")); | |
| } | |
| TEST_F(ValidateCFG, StructuredCFGBranchIntoSelectionBody) { | |
| std::string spirv = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %func "func" | |
| OpExecutionMode %func OriginUpperLeft | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %true = OpConstantTrue %bool | |
| %functy = OpTypeFunction %void | |
| %func = OpFunction %void None %functy | |
| %entry = OpLabel | |
| OpSelectionMerge %merge None | |
| OpBranchConditional %true %then %merge | |
| %merge = OpLabel | |
| OpBranch %then | |
| %then = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(spirv); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("branches to the selection construct, but not to the " | |
| "selection header <ID> 6\n %7 = OpLabel")); | |
| } | |
| TEST_F(ValidateCFG, SwitchDefaultOnly) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeInt 32 0 | |
| %3 = OpConstant %2 0 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpFunction %1 None %4 | |
| %6 = OpLabel | |
| OpSelectionMerge %7 None | |
| OpSwitch %3 %7 | |
| %7 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, SwitchSingleCase) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeInt 32 0 | |
| %3 = OpConstant %2 0 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpFunction %1 None %4 | |
| %6 = OpLabel | |
| OpSelectionMerge %7 None | |
| OpSwitch %3 %7 0 %8 | |
| %8 = OpLabel | |
| OpBranch %7 | |
| %7 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, MultipleFallThroughBlocks) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeInt 32 0 | |
| %3 = OpConstant %2 0 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpTypeBool | |
| %6 = OpConstantTrue %5 | |
| %7 = OpFunction %1 None %4 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %3 %10 0 %11 1 %12 | |
| %10 = OpLabel | |
| OpBranchConditional %6 %11 %12 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %12 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "Case construct that targets '10[%10]' has branches to multiple " | |
| "other " | |
| "case construct targets '12[%12]' and '11[%11]'\n %10 = OpLabel")); | |
| } | |
| TEST_F(ValidateCFG, MultipleFallThroughToDefault) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeInt 32 0 | |
| %3 = OpConstant %2 0 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpTypeBool | |
| %6 = OpConstantTrue %5 | |
| %7 = OpFunction %1 None %4 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %3 %10 0 %11 1 %12 | |
| %10 = OpLabel | |
| OpBranch %9 | |
| %11 = OpLabel | |
| OpBranch %10 | |
| %12 = OpLabel | |
| OpBranch %10 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("Multiple case constructs have branches to the case construct " | |
| "that targets '10[%10]'\n %10 = OpLabel")); | |
| } | |
| TEST_F(ValidateCFG, MultipleFallThroughToNonDefault) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeInt 32 0 | |
| %3 = OpConstant %2 0 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpTypeBool | |
| %6 = OpConstantTrue %5 | |
| %7 = OpFunction %1 None %4 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %3 %10 0 %11 1 %12 | |
| %10 = OpLabel | |
| OpBranch %12 | |
| %11 = OpLabel | |
| OpBranch %12 | |
| %12 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("Multiple case constructs have branches to the case construct " | |
| "that targets '12[%12]'\n %12 = OpLabel")); | |
| } | |
| TEST_F(ValidateCFG, DuplicateTargetWithFallThrough) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeInt 32 0 | |
| %3 = OpConstant %2 0 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpTypeBool | |
| %6 = OpConstantTrue %5 | |
| %7 = OpFunction %1 None %4 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %3 %10 0 %10 1 %11 | |
| %10 = OpLabel | |
| OpBranch %11 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, OpSwitchTargetCannotBeOuterLoopMergeBlock) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeFunction %1 | |
| %3 = OpTypeBool | |
| %4 = OpUndef %3 | |
| %5 = OpTypeInt 32 0 | |
| %6 = OpConstant %5 0 | |
| %7 = OpFunction %1 None %2 | |
| %8 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpLoopMerge %10 %11 None | |
| OpBranch %12 | |
| %12 = OpLabel | |
| OpSelectionMerge %13 None | |
| OpSwitch %6 %13 0 %10 1 %14 | |
| %14 = OpLabel | |
| OpBranch %13 | |
| %13 = OpLabel | |
| OpBranch %11 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %10 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "Switch header '12[%12]' does not structurally dominate its case construct '10[%10]'\n" | |
| " %12 = OpLabel")); | |
| } | |
| TEST_F(ValidateCFG, OpSwitchTargetCannotBeOuterLoopContinueBlock) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeFunction %1 | |
| %3 = OpTypeBool | |
| %4 = OpUndef %3 | |
| %5 = OpTypeInt 32 0 | |
| %6 = OpConstant %5 0 | |
| %7 = OpFunction %1 None %2 | |
| %8 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpLoopMerge %10 %11 None | |
| OpBranch %12 | |
| %12 = OpLabel | |
| OpSelectionMerge %13 None | |
| OpSwitch %6 %13 0 %11 1 %14 | |
| %14 = OpLabel | |
| OpBranch %13 | |
| %13 = OpLabel | |
| OpBranch %11 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %10 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "Switch header '12[%12]' does not structurally dominate its case construct '11[%11]'\n" | |
| " %12 = OpLabel")); | |
| } | |
| TEST_F(ValidateCFG, WrongOperandList) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeInt 32 0 | |
| %3 = OpConstant %2 0 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpTypeBool | |
| %6 = OpConstantTrue %5 | |
| %7 = OpFunction %1 None %4 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %3 %10 0 %11 1 %12 | |
| %10 = OpLabel | |
| OpBranch %9 | |
| %12 = OpLabel | |
| OpBranch %11 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "Case construct that targets '12[%12]' has branches to the case " | |
| "construct that targets '11[%11]', but does not immediately " | |
| "precede it in the OpSwitch's target list\n" | |
| " OpSwitch %uint_0 %10 0 %11 1 %12")); | |
| } | |
| TEST_F(ValidateCFG, WrongOperandListThroughDefault) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeInt 32 0 | |
| %3 = OpConstant %2 0 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpTypeBool | |
| %6 = OpConstantTrue %5 | |
| %7 = OpFunction %1 None %4 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %3 %10 0 %11 1 %12 | |
| %10 = OpLabel | |
| OpBranch %11 | |
| %12 = OpLabel | |
| OpBranch %10 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "Case construct that targets '12[%12]' has branches to the case " | |
| "construct that targets '11[%11]', but does not immediately " | |
| "precede it in the OpSwitch's target list\n" | |
| " OpSwitch %uint_0 %10 0 %11 1 %12")); | |
| } | |
| TEST_F(ValidateCFG, WrongOperandListNotLast) { | |
| std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeInt 32 0 | |
| %3 = OpConstant %2 0 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpTypeBool | |
| %6 = OpConstantTrue %5 | |
| %7 = OpFunction %1 None %4 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %3 %10 0 %11 1 %12 2 %13 | |
| %10 = OpLabel | |
| OpBranch %9 | |
| %12 = OpLabel | |
| OpBranch %11 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %13 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "Case construct that targets '12[%12]' has branches to the case " | |
| "construct that targets '11[%11]', but does not immediately " | |
| "precede it in the OpSwitch's target list\n" | |
| " OpSwitch %uint_0 %10 0 %11 1 %12 2 %13")); | |
| } | |
| TEST_F(ValidateCFG, GoodUnreachableSwitch) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %2 "main" | |
| OpExecutionMode %2 OriginUpperLeft | |
| %3 = OpTypeVoid | |
| %4 = OpTypeFunction %3 | |
| %5 = OpTypeBool | |
| %6 = OpConstantTrue %5 | |
| %7 = OpTypeInt 32 1 | |
| %9 = OpConstant %7 0 | |
| %2 = OpFunction %3 None %4 | |
| %10 = OpLabel | |
| OpSelectionMerge %11 None | |
| OpBranchConditional %6 %12 %13 | |
| %12 = OpLabel | |
| OpReturn | |
| %13 = OpLabel | |
| OpReturn | |
| %11 = OpLabel | |
| OpSelectionMerge %14 None | |
| OpSwitch %9 %14 0 %15 | |
| %15 = OpLabel | |
| OpBranch %14 | |
| %14 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_THAT(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, InvalidCaseExit) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %1 "func" | |
| OpExecutionMode %1 OriginUpperLeft | |
| %2 = OpTypeVoid | |
| %3 = OpTypeInt 32 0 | |
| %4 = OpTypeFunction %2 | |
| %5 = OpConstant %3 0 | |
| %1 = OpFunction %2 None %4 | |
| %6 = OpLabel | |
| OpSelectionMerge %7 None | |
| OpSwitch %5 %7 0 %8 1 %9 | |
| %8 = OpLabel | |
| OpBranch %10 | |
| %9 = OpLabel | |
| OpBranch %10 | |
| %10 = OpLabel | |
| OpReturn | |
| %7 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("Case construct that targets '8[%8]' has invalid branch " | |
| "to block '10[%10]' (not another case construct, " | |
| "corresponding merge, outer loop merge or outer loop " | |
| "continue)")); | |
| } | |
| TEST_F(ValidateCFG, GoodCaseExitsToOuterConstructs) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %func "func" | |
| OpExecutionMode %func OriginUpperLeft | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %true = OpConstantTrue %bool | |
| %int = OpTypeInt 32 0 | |
| %int0 = OpConstant %int 0 | |
| %func_ty = OpTypeFunction %void | |
| %func = OpFunction %void None %func_ty | |
| %1 = OpLabel | |
| OpBranch %2 | |
| %2 = OpLabel | |
| OpLoopMerge %7 %6 None | |
| OpBranch %3 | |
| %3 = OpLabel | |
| OpSelectionMerge %5 None | |
| OpSwitch %int0 %5 0 %4 | |
| %4 = OpLabel | |
| OpBranchConditional %true %6 %7 | |
| %5 = OpLabel | |
| OpBranchConditional %true %6 %7 | |
| %6 = OpLabel | |
| OpBranch %2 | |
| %7 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, SwitchCaseOrderingBad1) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %default "default" | |
| OpName %other "other" | |
| %void = OpTypeVoid | |
| %int = OpTypeInt 32 0 | |
| %undef = OpUndef %int | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %merge None | |
| OpSwitch %undef %default 0 %other 1 %default | |
| %default = OpLabel | |
| OpBranch %other | |
| %other = OpLabel | |
| OpBranch %merge | |
| %merge = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("Case construct that targets '1[%default]' has branches to the " | |
| "case construct that targets '2[%other]', but does not " | |
| "immediately precede it in the OpSwitch's target list")); | |
| } | |
| TEST_F(ValidateCFG, SwitchCaseOrderingBad2) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %default "default" | |
| OpName %other "other" | |
| %void = OpTypeVoid | |
| %int = OpTypeInt 32 0 | |
| %undef = OpUndef %int | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %merge None | |
| OpSwitch %undef %default 0 %default 1 %other | |
| %other = OpLabel | |
| OpBranch %default | |
| %default = OpLabel | |
| OpBranch %merge | |
| %merge = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("Case construct that targets '2[%other]' has branches to the " | |
| "case construct that targets '1[%default]', but does not " | |
| "immediately precede it in the OpSwitch's target list")); | |
| } | |
| TEST_F(ValidateCFG, SwitchMultipleDefaultWithFallThroughGood) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %first "first" | |
| OpName %second "second" | |
| OpName %third "third" | |
| %void = OpTypeVoid | |
| %int = OpTypeInt 32 0 | |
| %undef = OpUndef %int | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %merge None | |
| OpSwitch %undef %second 0 %first 1 %second 2 %third | |
| %first = OpLabel | |
| OpBranch %second | |
| %second = OpLabel | |
| OpBranch %third | |
| %third = OpLabel | |
| OpBranch %merge | |
| %merge = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, SwitchMultipleDefaultWithFallThroughBad) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %first "first" | |
| OpName %second "second" | |
| OpName %third "third" | |
| %void = OpTypeVoid | |
| %int = OpTypeInt 32 0 | |
| %undef = OpUndef %int | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %merge None | |
| OpSwitch %undef %second 0 %second 1 %first 2 %third | |
| %first = OpLabel | |
| OpBranch %second | |
| %second = OpLabel | |
| OpBranch %third | |
| %third = OpLabel | |
| OpBranch %merge | |
| %merge = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, GoodUnreachableSelection) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| %1 = OpExtInstImport "GLSL.std.450" | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %main "main" | |
| OpExecutionMode %main OriginUpperLeft | |
| %void = OpTypeVoid | |
| %8 = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %false = OpConstantFalse %bool | |
| %main = OpFunction %void None %8 | |
| %15 = OpLabel | |
| OpBranch %16 | |
| %16 = OpLabel | |
| OpLoopMerge %17 %18 None | |
| OpBranch %19 | |
| %19 = OpLabel | |
| OpBranchConditional %false %21 %17 | |
| %21 = OpLabel | |
| OpSelectionMerge %22 None | |
| OpBranchConditional %false %23 %22 | |
| %23 = OpLabel | |
| OpBranch %24 | |
| %24 = OpLabel | |
| OpLoopMerge %25 %26 None | |
| OpBranch %27 | |
| %27 = OpLabel | |
| OpReturn | |
| %26 = OpLabel | |
| OpBranchConditional %false %24 %25 | |
| %25 = OpLabel | |
| OpSelectionMerge %28 None | |
| OpBranchConditional %false %18 %28 | |
| %28 = OpLabel | |
| OpBranch %22 | |
| %22 = OpLabel | |
| OpBranch %18 | |
| %18 = OpLabel | |
| OpBranch %16 | |
| %17 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, ShaderWithPhiPtr) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %1 "main" | |
| OpExecutionMode %1 LocalSize 1 1 1 | |
| OpSource HLSL 600 | |
| %bool = OpTypeBool | |
| %_ptr_Function_bool = OpTypePointer Function %bool | |
| %void = OpTypeVoid | |
| %5 = OpTypeFunction %void | |
| %1 = OpFunction %void None %5 | |
| %6 = OpLabel | |
| %7 = OpVariable %_ptr_Function_bool Function | |
| %8 = OpVariable %_ptr_Function_bool Function | |
| %9 = OpUndef %bool | |
| OpSelectionMerge %10 None | |
| OpBranchConditional %9 %11 %10 | |
| %11 = OpLabel | |
| OpBranch %10 | |
| %10 = OpLabel | |
| %12 = OpPhi %_ptr_Function_bool %7 %6 %8 %11 | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_DATA, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Using pointers with OpPhi requires capability " | |
| "VariablePointers or VariablePointersStorageBuffer")); | |
| } | |
| TEST_F(ValidateCFG, VarPtrShaderWithPhiPtr) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability VariablePointers | |
| OpExtension "SPV_KHR_variable_pointers" | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %1 "main" | |
| OpExecutionMode %1 LocalSize 1 1 1 | |
| OpSource HLSL 600 | |
| %bool = OpTypeBool | |
| %_ptr_Function_bool = OpTypePointer Function %bool | |
| %void = OpTypeVoid | |
| %5 = OpTypeFunction %void | |
| %1 = OpFunction %void None %5 | |
| %6 = OpLabel | |
| %7 = OpVariable %_ptr_Function_bool Function | |
| %8 = OpVariable %_ptr_Function_bool Function | |
| %9 = OpUndef %bool | |
| OpSelectionMerge %10 None | |
| OpBranchConditional %9 %11 %10 | |
| %11 = OpLabel | |
| OpBranch %10 | |
| %10 = OpLabel | |
| %12 = OpPhi %_ptr_Function_bool %7 %6 %8 %11 | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, VarPtrStgBufShaderWithPhiStgBufPtr) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability VariablePointersStorageBuffer | |
| OpExtension "SPV_KHR_variable_pointers" | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %1 "main" | |
| OpExecutionMode %1 LocalSize 1 1 1 | |
| OpSource HLSL 600 | |
| %bool = OpTypeBool | |
| %float = OpTypeFloat 32 | |
| %_ptr_StorageBuffer_float = OpTypePointer StorageBuffer %float | |
| %7 = OpVariable %_ptr_StorageBuffer_float StorageBuffer | |
| %8 = OpVariable %_ptr_StorageBuffer_float StorageBuffer | |
| %void = OpTypeVoid | |
| %5 = OpTypeFunction %void | |
| %1 = OpFunction %void None %5 | |
| %6 = OpLabel | |
| %9 = OpUndef %bool | |
| OpSelectionMerge %10 None | |
| OpBranchConditional %9 %11 %10 | |
| %11 = OpLabel | |
| OpBranch %10 | |
| %10 = OpLabel | |
| %12 = OpPhi %_ptr_StorageBuffer_float %7 %6 %8 %11 | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, KernelWithPhiPtr) { | |
| const std::string text = R"( | |
| OpCapability Kernel | |
| OpCapability Addresses | |
| OpMemoryModel Physical32 OpenCL | |
| OpEntryPoint Kernel %1 "main" | |
| OpExecutionMode %1 LocalSize 1 1 1 | |
| OpSource HLSL 600 | |
| %bool = OpTypeBool | |
| %_ptr_Function_bool = OpTypePointer Function %bool | |
| %void = OpTypeVoid | |
| %5 = OpTypeFunction %void | |
| %1 = OpFunction %void None %5 | |
| %6 = OpLabel | |
| %7 = OpVariable %_ptr_Function_bool Function | |
| %8 = OpVariable %_ptr_Function_bool Function | |
| %9 = OpUndef %bool | |
| OpSelectionMerge %10 None | |
| OpBranchConditional %9 %11 %10 | |
| %11 = OpLabel | |
| OpBranch %10 | |
| %10 = OpLabel | |
| %12 = OpPhi %_ptr_Function_bool %7 %6 %8 %11 | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, SwitchTargetMustBeLabel) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %1 "foo" | |
| %uint = OpTypeInt 32 0 | |
| %uint_0 = OpConstant %uint 0 | |
| %void = OpTypeVoid | |
| %5 = OpTypeFunction %void | |
| %1 = OpFunction %void None %5 | |
| %6 = OpLabel | |
| %7 = OpCopyObject %uint %uint_0 | |
| OpSelectionMerge %8 None | |
| OpSwitch %uint_0 %8 0 %7 | |
| %8 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("'Target Label' operands for OpSwitch must " | |
| "be IDs of an OpLabel instruction")); | |
| } | |
| TEST_F(ValidateCFG, BranchTargetMustBeLabel) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %1 "foo" | |
| %uint = OpTypeInt 32 0 | |
| %uint_0 = OpConstant %uint 0 | |
| %void = OpTypeVoid | |
| %5 = OpTypeFunction %void | |
| %1 = OpFunction %void None %5 | |
| %2 = OpLabel | |
| %7 = OpCopyObject %uint %uint_0 | |
| OpBranch %7 | |
| %8 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("'Target Label' operands for OpBranch must " | |
| "be the ID of an OpLabel instruction")); | |
| } | |
| TEST_F(ValidateCFG, ReachableOpUnreachableOneBlock) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpUnreachable | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, ReachableOpUnreachableOpBranch) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranch %block | |
| %block = OpLabel | |
| OpUnreachable | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, ReachableOpUnreachableOpBranchConditional) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %block None | |
| OpBranchConditional %undef %block %unreachable | |
| %block = OpLabel | |
| OpReturn | |
| %unreachable = OpLabel | |
| OpUnreachable | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, ReachableOpUnreachableOpSwitch) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %int = OpTypeInt 32 0 | |
| %undef = OpUndef %int | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %block1 None | |
| OpSwitch %undef %block1 0 %unreachable 1 %block2 | |
| %block1 = OpLabel | |
| OpReturn | |
| %unreachable = OpLabel | |
| OpUnreachable | |
| %block2 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, ReachableOpUnreachableLoop) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %unreachable %loop None | |
| OpBranchConditional %undef %loop %unreachable | |
| %unreachable = OpLabel | |
| OpUnreachable | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, UnreachableLoopBadBackedge) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %2 "main" | |
| OpExecutionMode %2 OriginUpperLeft | |
| %4 = OpTypeVoid | |
| %5 = OpTypeFunction %4 | |
| %8 = OpTypeBool | |
| %13 = OpConstantTrue %8 | |
| %2 = OpFunction %4 None %5 | |
| %14 = OpLabel | |
| OpSelectionMerge %15 None | |
| OpBranchConditional %13 %15 %15 | |
| %16 = OpLabel | |
| OpLoopMerge %17 %18 None | |
| OpBranch %17 | |
| %18 = OpLabel | |
| OpBranch %17 | |
| %17 = OpLabel | |
| OpBranch %15 | |
| %15 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| // The back-edge in this test is bad, but the validator fails to identify it | |
| // because it is in an entirely unreachable section of code. Prior to #2488 | |
| // this code failed an assert in Construct::blocks(). | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, OneContinueTwoBackedges) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %1 "main" | |
| OpExecutionMode %1 LocalSize 1 1 1 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %true = OpConstantTrue %bool | |
| %5 = OpTypeFunction %void | |
| %1 = OpFunction %void None %5 | |
| %6 = OpLabel | |
| OpBranch %7 | |
| %7 = OpLabel | |
| OpLoopMerge %8 %9 None | |
| OpBranch %10 | |
| %10 = OpLabel | |
| OpLoopMerge %11 %9 None | |
| OpBranchConditional %true %11 %9 | |
| %9 = OpLabel | |
| OpBranchConditional %true %10 %7 | |
| %11 = OpLabel | |
| OpBranch %8 | |
| %8 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Back-edges ('10[%10]' -> '9[%9]') can only be formed " | |
| "between a block and a loop header")); | |
| } | |
| TEST_F(ValidateCFG, LoopMergeMergeBlockNotLabel) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %undef "undef" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %1 = OpLabel | |
| OpLoopMerge %undef %2 None | |
| OpBranchConditional %undef %2 %2 | |
| %2 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Merge Block '1[%undef]' must be an OpLabel")); | |
| } | |
| TEST_F(ValidateCFG, LoopMergeContinueTargetNotLabel) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %undef "undef" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %1 = OpLabel | |
| OpLoopMerge %2 %undef None | |
| OpBranchConditional %undef %2 %2 | |
| %2 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Continue Target '1[%undef]' must be an OpLabel")); | |
| } | |
| TEST_F(ValidateCFG, LoopMergeMergeBlockContinueTargetSameLabel) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %undef "undef" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %1 = OpLabel | |
| OpLoopMerge %2 %2 None | |
| OpBranchConditional %undef %2 %2 | |
| %2 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("Merge Block and Continue Target must be different ids")); | |
| } | |
| TEST_F(ValidateCFG, LoopMergeUnrollAndDontUnroll) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %undef "undef" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %5 = OpLabel | |
| OpBranch %1 | |
| %1 = OpLabel | |
| OpLoopMerge %2 %3 Unroll|DontUnroll | |
| OpBranchConditional %undef %2 %3 | |
| %3 = OpLabel | |
| OpBranch %1 | |
| %2 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_DATA, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "Unroll and DontUnroll loop controls must not both be specified")); | |
| } | |
| TEST_F(ValidateCFG, LoopMergePeelCountAndDontUnroll) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %undef "undef" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %5 = OpLabel | |
| OpBranch %1 | |
| %1 = OpLabel | |
| OpLoopMerge %2 %3 DontUnroll|PeelCount 1 | |
| OpBranchConditional %undef %2 %3 | |
| %3 = OpLabel | |
| OpBranch %1 | |
| %2 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text, SPV_ENV_UNIVERSAL_1_4); | |
| EXPECT_EQ(SPV_ERROR_INVALID_DATA, | |
| ValidateInstructions(SPV_ENV_UNIVERSAL_1_4)); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "PeelCount and DontUnroll loop controls must not both be specified")); | |
| } | |
| TEST_F(ValidateCFG, LoopMergePartialCountAndDontUnroll) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %undef "undef" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %5 = OpLabel | |
| OpBranch %1 | |
| %1 = OpLabel | |
| OpLoopMerge %2 %3 DontUnroll|PartialCount 1 | |
| OpBranchConditional %undef %2 %3 | |
| %3 = OpLabel | |
| OpBranch %1 | |
| %2 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text, SPV_ENV_UNIVERSAL_1_4); | |
| EXPECT_EQ(SPV_ERROR_INVALID_DATA, | |
| ValidateInstructions(SPV_ENV_UNIVERSAL_1_4)); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("PartialCount and DontUnroll loop controls must not " | |
| "both be specified")); | |
| } | |
| TEST_F(ValidateCFG, LoopMergeIterationMultipleZero) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %undef "undef" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %5 = OpLabel | |
| OpBranch %1 | |
| %1 = OpLabel | |
| OpLoopMerge %2 %3 IterationMultiple 0 | |
| OpBranchConditional %undef %2 %3 | |
| %3 = OpLabel | |
| OpBranch %1 | |
| %2 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text, SPV_ENV_UNIVERSAL_1_4); | |
| EXPECT_EQ(SPV_ERROR_INVALID_DATA, | |
| ValidateInstructions(SPV_ENV_UNIVERSAL_1_4)); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "IterationMultiple loop control operand must be greater than zero")); | |
| } | |
| TEST_F(ValidateCFG, LoopMergeIterationMultipleZeroMoreOperands) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %undef "undef" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %5 = OpLabel | |
| OpBranch %1 | |
| %1 = OpLabel | |
| OpLoopMerge %2 %3 MaxIterations|IterationMultiple 4 0 | |
| OpBranchConditional %undef %2 %3 | |
| %3 = OpLabel | |
| OpBranch %1 | |
| %2 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text, SPV_ENV_UNIVERSAL_1_4); | |
| EXPECT_EQ(SPV_ERROR_INVALID_DATA, | |
| ValidateInstructions(SPV_ENV_UNIVERSAL_1_4)); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "IterationMultiple loop control operand must be greater than zero")); | |
| } | |
| TEST_F(ValidateCFG, LoopMergeTargetsHeader) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %fn = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %loop %continue None | |
| OpBranch %body | |
| %continue = OpLabel | |
| OpBranch %loop | |
| %body = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("Merge Block may not be the block containing the OpLoopMerge")); | |
| } | |
| TEST_F(ValidateCFG, InvalidSelectionExit) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %1 "main" | |
| OpExecutionMode %1 OriginUpperLeft | |
| %2 = OpTypeVoid | |
| %3 = OpTypeBool | |
| %4 = OpConstantTrue %3 | |
| %5 = OpTypeFunction %2 | |
| %1 = OpFunction %2 None %5 | |
| %6 = OpLabel | |
| OpSelectionMerge %7 None | |
| OpBranchConditional %4 %7 %8 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpBranchConditional %4 %10 %9 | |
| %10 = OpLabel | |
| OpBranch %7 | |
| %9 = OpLabel | |
| OpBranch %7 | |
| %7 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("block <ID> '10[%10]' exits the selection headed by <ID> " | |
| "'8[%8]', but not via a structured exit")); | |
| } | |
| TEST_F(ValidateCFG, InvalidLoopExit) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %1 "main" | |
| OpExecutionMode %1 OriginUpperLeft | |
| %2 = OpTypeVoid | |
| %3 = OpTypeBool | |
| %4 = OpConstantTrue %3 | |
| %5 = OpTypeFunction %2 | |
| %1 = OpFunction %2 None %5 | |
| %6 = OpLabel | |
| OpSelectionMerge %7 None | |
| OpBranchConditional %4 %7 %8 | |
| %8 = OpLabel | |
| OpLoopMerge %9 %10 None | |
| OpBranchConditional %4 %9 %11 | |
| %11 = OpLabel | |
| OpBranchConditional %4 %7 %10 | |
| %10 = OpLabel | |
| OpBranch %8 | |
| %9 = OpLabel | |
| OpBranch %7 | |
| %7 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("block <ID> '11[%11]' exits the loop headed by <ID> " | |
| "'8[%8]', but not via a structured exit")); | |
| } | |
| TEST_F(ValidateCFG, InvalidContinueExit) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %1 "main" | |
| OpExecutionMode %1 OriginUpperLeft | |
| %2 = OpTypeVoid | |
| %3 = OpTypeBool | |
| %4 = OpConstantTrue %3 | |
| %5 = OpTypeFunction %2 | |
| %1 = OpFunction %2 None %5 | |
| %6 = OpLabel | |
| OpSelectionMerge %7 None | |
| OpBranchConditional %4 %7 %8 | |
| %8 = OpLabel | |
| OpLoopMerge %9 %10 None | |
| OpBranchConditional %4 %9 %10 | |
| %10 = OpLabel | |
| OpBranch %11 | |
| %11 = OpLabel | |
| OpBranchConditional %4 %8 %7 | |
| %9 = OpLabel | |
| OpBranch %7 | |
| %7 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("block <ID> '11[%11]' exits the continue headed by <ID> " | |
| "'10[%10]', but not via a structured exit")); | |
| } | |
| TEST_F(ValidateCFG, InvalidSelectionExitBackedge) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeBool | |
| %3 = OpUndef %2 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpFunction %1 None %4 | |
| %6 = OpLabel | |
| OpBranch %7 | |
| %7 = OpLabel | |
| OpLoopMerge %8 %9 None | |
| OpBranchConditional %3 %8 %9 | |
| %9 = OpLabel | |
| OpSelectionMerge %10 None | |
| OpBranchConditional %3 %11 %12 | |
| %11 = OpLabel | |
| OpBranch %13 | |
| %12 = OpLabel | |
| OpBranch %13 | |
| %13 = OpLabel | |
| OpBranch %7 | |
| %10 = OpLabel | |
| OpUnreachable | |
| %8 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "The continue construct with the continue target '9[%9]' is not " | |
| "structurally post dominated by the back-edge block '13[%13]'")); | |
| } | |
| TEST_F(ValidateCFG, BreakFromSwitch) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeBool | |
| %3 = OpTypeInt 32 0 | |
| %4 = OpUndef %2 | |
| %5 = OpUndef %3 | |
| %6 = OpTypeFunction %1 | |
| %7 = OpFunction %1 None %6 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %5 %9 0 %10 | |
| %10 = OpLabel | |
| OpSelectionMerge %11 None | |
| OpBranchConditional %4 %11 %12 | |
| %12 = OpLabel | |
| OpBranch %9 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, InvalidBreakFromSwitch) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeBool | |
| %3 = OpTypeInt 32 0 | |
| %4 = OpUndef %2 | |
| %5 = OpUndef %3 | |
| %6 = OpTypeFunction %1 | |
| %7 = OpFunction %1 None %6 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %5 %9 0 %10 | |
| %10 = OpLabel | |
| OpSelectionMerge %11 None | |
| OpSwitch %5 %11 0 %12 | |
| %12 = OpLabel | |
| OpBranch %9 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("block <ID> '12[%12]' exits the selection headed by <ID> " | |
| "'10[%10]', but not via a structured exit")); | |
| } | |
| TEST_F(ValidateCFG, BreakToOuterSwitch) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeBool | |
| %3 = OpTypeInt 32 0 | |
| %4 = OpUndef %2 | |
| %5 = OpUndef %3 | |
| %6 = OpTypeFunction %1 | |
| %7 = OpFunction %1 None %6 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %5 %9 0 %10 | |
| %10 = OpLabel | |
| OpSelectionMerge %11 None | |
| OpSwitch %5 %11 0 %12 | |
| %12 = OpLabel | |
| OpSelectionMerge %13 None | |
| OpBranchConditional %4 %13 %14 | |
| %14 = OpLabel | |
| OpBranch %9 | |
| %13 = OpLabel | |
| OpBranch %11 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("block <ID> '14[%14]' exits the selection headed by <ID> " | |
| "'10[%10]', but not via a structured exit")); | |
| } | |
| TEST_F(ValidateCFG, BreakToOuterLoop) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeBool | |
| %3 = OpUndef %2 | |
| %4 = OpTypeFunction %1 | |
| %5 = OpFunction %1 None %4 | |
| %6 = OpLabel | |
| OpBranch %7 | |
| %7 = OpLabel | |
| OpLoopMerge %8 %9 None | |
| OpBranch %10 | |
| %10 = OpLabel | |
| OpLoopMerge %11 %12 None | |
| OpBranch %13 | |
| %13 = OpLabel | |
| OpSelectionMerge %14 None | |
| OpBranchConditional %3 %14 %15 | |
| %15 = OpLabel | |
| OpBranch %8 | |
| %14 = OpLabel | |
| OpBranch %12 | |
| %12 = OpLabel | |
| OpBranchConditional %3 %10 %11 | |
| %11 = OpLabel | |
| OpBranch %9 | |
| %9 = OpLabel | |
| OpBranchConditional %3 %7 %8 | |
| %8 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("block <ID> '15[%15]' exits the loop headed by <ID> " | |
| "'10[%10]', but not via a structured exit")); | |
| } | |
| TEST_F(ValidateCFG, ContinueFromNestedSelection) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %4 = OpFunction %void None %void_fn | |
| %5 = OpLabel | |
| OpBranch %48 | |
| %48 = OpLabel | |
| OpLoopMerge %47 %50 None | |
| OpBranch %10 | |
| %10 = OpLabel | |
| OpLoopMerge %12 %37 None | |
| OpBranchConditional %undef %11 %12 | |
| %11 = OpLabel | |
| OpSelectionMerge %31 None | |
| OpBranchConditional %undef %30 %31 | |
| %30 = OpLabel | |
| OpSelectionMerge %38 None | |
| OpBranchConditional %undef %36 %38 | |
| %36 = OpLabel | |
| OpBranch %38 | |
| %38 = OpLabel | |
| OpBranch %37 | |
| %37 = OpLabel | |
| OpBranch %10 | |
| %31 = OpLabel | |
| OpBranch %12 | |
| %12 = OpLabel | |
| OpSelectionMerge %55 None | |
| OpBranchConditional %undef %47 %55 | |
| %55 = OpLabel | |
| OpBranch %47 | |
| %50 = OpLabel | |
| OpBranch %48 | |
| %47 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeConditionalBranchBad) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranchConditional %undef %then %else | |
| %then = OpLabel | |
| OpReturn | |
| %else = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), HasSubstr("Selection must be structured")); | |
| } | |
| TEST_F(ValidateCFG, LoopConditionalBranchWithoutExitBad) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %exit %continue None | |
| OpBranchConditional %undef %then %else | |
| %then = OpLabel | |
| OpBranch %continue | |
| %else = OpLabel | |
| OpBranch %exit | |
| %continue = OpLabel | |
| OpBranch %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), HasSubstr("Selection must be structured")); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeSwitchBad) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %int = OpTypeInt 32 0 | |
| %undef = OpUndef %int | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSwitch %undef %then 0 %else | |
| %then = OpLabel | |
| OpReturn | |
| %else = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "OpSwitch must be preceded by an OpSelectionMerge instruction")); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeSwitchBad2) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %int = OpTypeInt 32 0 | |
| %undef = OpUndef %int | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSwitch %undef %then 0 %then 1 %then 2 %else | |
| %then = OpLabel | |
| OpReturn | |
| %else = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "OpSwitch must be preceded by an OpSelectionMerge instruction")); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeOneBranchToMergeGood) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %b3 None | |
| OpBranchConditional %undef %b1 %b2 | |
| %b1 = OpLabel | |
| OpBranchConditional %undef %b2 %b3 | |
| %b2 = OpLabel | |
| OpBranch %b3 | |
| %b3 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeSameTargetConditionalBranchGood) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranchConditional %undef %then %then | |
| %then = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeOneTargetSwitchBad) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %int = OpTypeInt 32 0 | |
| %undef = OpUndef %int | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSwitch %undef %then 0 %then 1 %then | |
| %then = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "OpSwitch must be preceded by an OpSelectionMerge instruction")); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeOneUnseenTargetSwitchBad) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %int = OpTypeInt 32 0 | |
| %undef_int = OpUndef %int | |
| %bool = OpTypeBool | |
| %undef_bool = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %merge None | |
| OpBranchConditional %undef_bool %merge %b1 | |
| %b1 = OpLabel | |
| OpSwitch %undef_int %b2 0 %b2 1 %merge 2 %b2 | |
| %b2 = OpLabel | |
| OpBranch %merge | |
| %merge = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr( | |
| "OpSwitch must be preceded by an OpSelectionMerge instruction")); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeLoopBreakGood) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %exit %continue None | |
| OpBranch %body | |
| %body = OpLabel | |
| OpBranchConditional %undef %body2 %exit | |
| %body2 = OpLabel | |
| OpBranch %continue | |
| %continue = OpLabel | |
| OpBranch %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeLoopContinueGood) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %exit %continue None | |
| OpBranch %body | |
| %body = OpLabel | |
| OpBranchConditional %undef %body2 %continue | |
| %body2 = OpLabel | |
| OpBranch %continue | |
| %continue = OpLabel | |
| OpBranch %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeSwitchBreakGood) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %int = OpTypeInt 32 0 | |
| %int_0 = OpConstant %int 0 | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %merge None | |
| OpSwitch %int_0 %merge 1 %b1 | |
| %b1 = OpLabel | |
| OpBranchConditional %undef %merge %b2 | |
| %b2 = OpLabel | |
| OpBranch %merge | |
| %merge = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeSwitchFallThroughGood) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %int = OpTypeInt 32 0 | |
| %int_0 = OpConstant %int 0 | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %merge None | |
| OpSwitch %int_0 %b1 1 %b2 | |
| %b1 = OpLabel | |
| OpBranchConditional %undef %b3 %b2 | |
| %b2 = OpLabel | |
| OpBranch %merge | |
| %b3 = OpLabel | |
| OpBranch %merge | |
| %merge = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeInALoopBad) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %exit %continue None | |
| OpBranch %body | |
| %body = OpLabel | |
| OpBranchConditional %undef %b1 %b2 | |
| %b1 = OpLabel | |
| OpBranch %exit | |
| %b2 = OpLabel | |
| OpBranch %continue | |
| %continue = OpLabel | |
| OpBranch %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), HasSubstr("Selection must be structured")); | |
| } | |
| TEST_F(ValidateCFG, MissingMergeCrissCrossBad) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %merge None | |
| OpBranchConditional %undef %b1 %b2 | |
| %b1 = OpLabel | |
| OpBranchConditional %undef %b3 %b4 | |
| %b2 = OpLabel | |
| OpBranchConditional %undef %b3 %b4 | |
| %b3 = OpLabel | |
| OpBranch %merge | |
| %b4 = OpLabel | |
| OpBranch %merge | |
| %merge = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), HasSubstr("Selection must be structured")); | |
| } | |
| TEST_F(ValidateCFG, ContinueCannotBeSelectionMergeTarget) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %loop "loop" | |
| OpName %continue "continue" | |
| OpName %body "body" | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %exit %continue None | |
| OpBranch %body | |
| %body = OpLabel | |
| OpSelectionMerge %continue None | |
| OpBranchConditional %undef %exit %continue | |
| %continue = OpLabel | |
| OpBranch %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("Header block '3[%body]' is contained in the loop construct " | |
| "headed by " | |
| "'1[%loop]', but its merge block '2[%continue]' is not")); | |
| } | |
| TEST_F(ValidateCFG, ContinueCannotBeLoopMergeTarget) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %loop "loop" | |
| OpName %continue "continue" | |
| OpName %inner "inner" | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranch %loop | |
| %loop = OpLabel | |
| OpLoopMerge %exit %continue None | |
| OpBranchConditional %undef %exit %inner | |
| %inner = OpLabel | |
| OpLoopMerge %continue %inner None | |
| OpBranchConditional %undef %inner %continue | |
| %continue = OpLabel | |
| OpBranch %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("Header block '3[%inner]' is contained in the loop construct " | |
| "headed by " | |
| "'1[%loop]', but its merge block '2[%continue]' is not")); | |
| } | |
| TEST_F(ValidateCFG, ExitFromConstructWhoseHeaderIsAMerge) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %2 = OpTypeFunction %void | |
| %int = OpTypeInt 32 1 | |
| %4 = OpUndef %int | |
| %bool = OpTypeBool | |
| %6 = OpUndef %bool | |
| %7 = OpFunction %void None %2 | |
| %8 = OpLabel | |
| OpSelectionMerge %9 None | |
| OpSwitch %4 %10 0 %11 | |
| %10 = OpLabel | |
| OpBranch %9 | |
| %11 = OpLabel | |
| OpBranch %12 | |
| %12 = OpLabel | |
| OpLoopMerge %13 %14 None | |
| OpBranch %15 | |
| %15 = OpLabel | |
| OpSelectionMerge %16 None | |
| OpSwitch %4 %17 1 %18 2 %19 | |
| %17 = OpLabel | |
| OpBranch %16 | |
| %18 = OpLabel | |
| OpBranch %14 | |
| %19 = OpLabel | |
| OpBranch %16 | |
| %16 = OpLabel | |
| OpBranch %14 | |
| %14 = OpLabel | |
| OpBranchConditional %6 %12 %13 | |
| %13 = OpLabel | |
| OpSelectionMerge %20 None | |
| OpBranchConditional %6 %21 %20 | |
| %21 = OpLabel | |
| OpBranch %9 | |
| %20 = OpLabel | |
| OpBranch %10 | |
| %9 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, ExitFromConstructWhoseHeaderIsAMerge2) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| %1 = OpExtInstImport "GLSL.std.450" | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %2 "main" | |
| OpExecutionMode %2 OriginUpperLeft | |
| %void = OpTypeVoid | |
| %4 = OpTypeFunction %void | |
| %int = OpTypeInt 32 1 | |
| %6 = OpUndef %int | |
| %bool = OpTypeBool | |
| %8 = OpUndef %bool | |
| %2 = OpFunction %void None %4 | |
| %9 = OpLabel | |
| OpSelectionMerge %10 None | |
| OpSwitch %6 %11 0 %12 | |
| %11 = OpLabel | |
| OpBranch %10 | |
| %12 = OpLabel | |
| OpBranch %13 | |
| %13 = OpLabel | |
| OpLoopMerge %14 %15 None | |
| OpBranch %16 | |
| %16 = OpLabel | |
| OpSelectionMerge %17 None | |
| OpSwitch %6 %18 1 %19 2 %20 | |
| %18 = OpLabel | |
| OpBranch %17 | |
| %19 = OpLabel | |
| OpBranch %15 | |
| %20 = OpLabel | |
| OpBranch %17 | |
| %17 = OpLabel | |
| OpBranch %15 | |
| %15 = OpLabel | |
| OpBranchConditional %8 %13 %14 | |
| %14 = OpLabel | |
| OpSelectionMerge %21 None | |
| OpBranchConditional %8 %22 %21 | |
| %22 = OpLabel | |
| OpSelectionMerge %23 None | |
| OpBranchConditional %8 %24 %23 | |
| %24 = OpLabel | |
| OpBranch %10 | |
| %23 = OpLabel | |
| OpBranch %21 | |
| %21 = OpLabel | |
| OpBranch %11 | |
| %10 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, PhiResultInvalidSampler) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %f32 = OpTypeFloat 32 | |
| %sampler = OpTypeSampler | |
| %ptr_uc_sampler = OpTypePointer UniformConstant %sampler | |
| %sampler_var = OpVariable %ptr_uc_sampler UniformConstant | |
| %undef_bool = OpUndef %bool | |
| %undef_sampler = OpUndef %sampler | |
| %void_fn = OpTypeFunction %void | |
| %fn = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| %ld_sampler = OpLoad %sampler %sampler_var | |
| OpBranch %loop | |
| %loop = OpLabel | |
| %phi = OpPhi %sampler %undef_sampler %entry %ld_sampler %loop | |
| OpLoopMerge %exit %loop None | |
| OpBranchConditional %undef_bool %exit %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Result type cannot be OpTypeSampler")); | |
| } | |
| TEST_F(ValidateCFG, PhiResultInvalidImage) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %f32 = OpTypeFloat 32 | |
| %image = OpTypeImage %f32 2D 0 0 0 1 Rgba32f | |
| %ptr_uc_image = OpTypePointer UniformConstant %image | |
| %image_var = OpVariable %ptr_uc_image UniformConstant | |
| %undef_bool = OpUndef %bool | |
| %undef_image = OpUndef %image | |
| %void_fn = OpTypeFunction %void | |
| %fn = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| %ld_image = OpLoad %image %image_var | |
| OpBranch %loop | |
| %loop = OpLabel | |
| %phi = OpPhi %image %undef_image %entry %ld_image %loop | |
| OpLoopMerge %exit %loop None | |
| OpBranchConditional %undef_bool %exit %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Result type cannot be OpTypeImage")); | |
| } | |
| TEST_F(ValidateCFG, PhiResultInvalidSampledImage) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %f32 = OpTypeFloat 32 | |
| %sampler = OpTypeSampler | |
| %ptr_uc_sampler = OpTypePointer UniformConstant %sampler | |
| %sampler_var = OpVariable %ptr_uc_sampler UniformConstant | |
| %image = OpTypeImage %f32 2D 0 0 0 1 Rgba32f | |
| %ptr_uc_image = OpTypePointer UniformConstant %image | |
| %image_var = OpVariable %ptr_uc_image UniformConstant | |
| %sampled_image = OpTypeSampledImage %image | |
| %undef_bool = OpUndef %bool | |
| %undef_sampled_image = OpUndef %sampled_image | |
| %void_fn = OpTypeFunction %void | |
| %fn = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| %ld_image = OpLoad %image %image_var | |
| %ld_sampler = OpLoad %sampler %sampler_var | |
| OpBranch %loop | |
| %loop = OpLabel | |
| %phi = OpPhi %sampled_image %undef_sampled_image %entry %sample %loop | |
| %sample = OpSampledImage %sampled_image %ld_image %ld_sampler | |
| OpLoopMerge %exit %loop None | |
| OpBranchConditional %undef_bool %exit %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Result type cannot be OpTypeSampledImage")); | |
| } | |
| TEST_F(ValidateCFG, PhiResultValidPreLegalizationSampler) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %f32 = OpTypeFloat 32 | |
| %sampler = OpTypeSampler | |
| %ptr_uc_sampler = OpTypePointer UniformConstant %sampler | |
| %sampler_var = OpVariable %ptr_uc_sampler UniformConstant | |
| %undef_bool = OpUndef %bool | |
| %undef_sampler = OpUndef %sampler | |
| %void_fn = OpTypeFunction %void | |
| %fn = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| %ld_sampler = OpLoad %sampler %sampler_var | |
| OpBranch %loop | |
| %loop = OpLabel | |
| %phi = OpPhi %sampler %undef_sampler %entry %ld_sampler %loop | |
| OpLoopMerge %exit %loop None | |
| OpBranchConditional %undef_bool %exit %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| options_->before_hlsl_legalization = true; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, PhiResultValidPreLegalizationImage) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %f32 = OpTypeFloat 32 | |
| %image = OpTypeImage %f32 2D 0 0 0 1 Rgba32f | |
| %ptr_uc_image = OpTypePointer UniformConstant %image | |
| %image_var = OpVariable %ptr_uc_image UniformConstant | |
| %undef_bool = OpUndef %bool | |
| %undef_image = OpUndef %image | |
| %void_fn = OpTypeFunction %void | |
| %fn = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| %ld_image = OpLoad %image %image_var | |
| OpBranch %loop | |
| %loop = OpLabel | |
| %phi = OpPhi %image %undef_image %entry %ld_image %loop | |
| OpLoopMerge %exit %loop None | |
| OpBranchConditional %undef_bool %exit %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| options_->before_hlsl_legalization = true; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, PhiResultValidPreLegalizationSampledImage) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %f32 = OpTypeFloat 32 | |
| %sampler = OpTypeSampler | |
| %ptr_uc_sampler = OpTypePointer UniformConstant %sampler | |
| %sampler_var = OpVariable %ptr_uc_sampler UniformConstant | |
| %image = OpTypeImage %f32 2D 0 0 0 1 Rgba32f | |
| %ptr_uc_image = OpTypePointer UniformConstant %image | |
| %image_var = OpVariable %ptr_uc_image UniformConstant | |
| %sampled_image = OpTypeSampledImage %image | |
| %undef_bool = OpUndef %bool | |
| %undef_sampled_image = OpUndef %sampled_image | |
| %void_fn = OpTypeFunction %void | |
| %fn = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| %ld_image = OpLoad %image %image_var | |
| %ld_sampler = OpLoad %sampler %sampler_var | |
| OpBranch %loop | |
| %loop = OpLabel | |
| %phi = OpPhi %sampled_image %undef_sampled_image %entry %sample %loop | |
| %sample = OpSampledImage %sampled_image %ld_image %ld_sampler | |
| OpLoopMerge %exit %loop None | |
| OpBranchConditional %undef_bool %exit %loop | |
| %exit = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| options_->before_hlsl_legalization = true; | |
| CompileSuccessfully(text); | |
| ASSERT_EQ(SPV_SUCCESS, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, StructuredSelections_RegisterBothTrueAndFalse) { | |
| // In this test, we try to make a case where the false branches | |
| // to %20 and %60 from blocks %10 and %50 must be registered | |
| // during the validity check for sturctured selections. | |
| // However, an error is caught earlier in the flow, that the | |
| // branches from %100 to %20 and %60 violate dominance. | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical Simple | |
| OpEntryPoint Fragment %main "main" | |
| OpExecutionMode %main OriginUpperLeft | |
| %void = OpTypeVoid | |
| %void_fn = OpTypeFunction %void | |
| %bool = OpTypeBool | |
| %cond = OpUndef %bool | |
| %main = OpFunction %void None %void_fn | |
| %1 = OpLabel | |
| OpSelectionMerge %999 None | |
| OpBranchConditional %cond %10 %100 | |
| %10 = OpLabel | |
| OpSelectionMerge %30 None ; force registration of %30 | |
| OpBranchConditional %cond %30 %20 ; %20 should be registered too | |
| %20 = OpLabel | |
| OpBranch %30 | |
| %30 = OpLabel ; merge for first if | |
| OpBranch %50 | |
| %50 = OpLabel | |
| OpSelectionMerge %70 None ; force registration of %70 | |
| OpBranchConditional %cond %70 %60 ; %60 should be registered | |
| %60 = OpLabel | |
| OpBranch %70 | |
| %70 = OpLabel ; merge for second if | |
| OpBranch %999 | |
| %100 = OpLabel | |
| OpBranchConditional %cond %20 %60 ; should require a merge | |
| %999 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_NE(SPV_SUCCESS, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("The selection construct with the selection header " | |
| "'8[%8]' does not structurally dominate the merge " | |
| "block '10[%10]'\n")); | |
| } | |
| TEST_F(ValidateCFG, UnreachableIsStaticallyReachable) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeFunction %1 | |
| %3 = OpFunction %1 None %2 | |
| %4 = OpLabel | |
| OpBranch %5 | |
| %5 = OpLabel | |
| OpUnreachable | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateAndRetrieveValidationState()); | |
| auto f = vstate_->function(3); | |
| auto entry = f->GetBlock(4).first; | |
| ASSERT_TRUE(entry->reachable()); | |
| auto end = f->GetBlock(5).first; | |
| ASSERT_TRUE(end->reachable()); | |
| } | |
| TEST_F(ValidateCFG, BlockOrderDoesNotAffectReachability) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeFunction %1 | |
| %3 = OpTypeBool | |
| %4 = OpUndef %3 | |
| %5 = OpFunction %1 None %2 | |
| %6 = OpLabel | |
| OpBranch %7 | |
| %7 = OpLabel | |
| OpSelectionMerge %8 None | |
| OpBranchConditional %4 %9 %10 | |
| %8 = OpLabel | |
| OpReturn | |
| %9 = OpLabel | |
| OpBranch %8 | |
| %10 = OpLabel | |
| OpBranch %8 | |
| %11 = OpLabel | |
| OpUnreachable | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateAndRetrieveValidationState()); | |
| auto f = vstate_->function(5); | |
| auto b6 = f->GetBlock(6).first; | |
| auto b7 = f->GetBlock(7).first; | |
| auto b8 = f->GetBlock(8).first; | |
| auto b9 = f->GetBlock(9).first; | |
| auto b10 = f->GetBlock(10).first; | |
| auto b11 = f->GetBlock(11).first; | |
| ASSERT_TRUE(b6->reachable()); | |
| ASSERT_TRUE(b7->reachable()); | |
| ASSERT_TRUE(b8->reachable()); | |
| ASSERT_TRUE(b9->reachable()); | |
| ASSERT_TRUE(b10->reachable()); | |
| ASSERT_FALSE(b11->reachable()); | |
| } | |
| TEST_F(ValidateCFG, PhiInstructionWithDuplicateIncomingEdges) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| %1 = OpExtInstImport "GLSL.std.450" | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %4 "main" | |
| OpExecutionMode %4 OriginUpperLeft | |
| OpSource ESSL 320 | |
| %2 = OpTypeVoid | |
| %3 = OpTypeFunction %2 | |
| %6 = OpTypeBool | |
| %7 = OpConstantTrue %6 | |
| %4 = OpFunction %2 None %3 | |
| %5 = OpLabel | |
| OpSelectionMerge %10 None | |
| OpBranchConditional %7 %8 %9 | |
| %8 = OpLabel | |
| OpBranch %10 | |
| %9 = OpLabel | |
| OpBranch %10 | |
| %10 = OpLabel | |
| %11 = OpPhi %6 %7 %8 %7 %8 | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("OpPhi references incoming basic block <id> ")); | |
| EXPECT_THAT(getDiagnosticString(), HasSubstr("multiple times.")); | |
| } | |
| TEST_F(ValidateCFG, PhiOnVoid) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| %1 = OpExtInstImport "GLSL.std.450" | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %4 "main" | |
| OpExecutionMode %4 OriginUpperLeft | |
| OpSource ESSL 320 | |
| OpName %4 "main" | |
| OpName %6 "foo(" | |
| %2 = OpTypeVoid | |
| %3 = OpTypeFunction %2 | |
| %4 = OpFunction %2 None %3 | |
| %5 = OpLabel | |
| %8 = OpFunctionCall %2 %6 | |
| OpBranch %20 | |
| %20 = OpLabel | |
| %21 = OpPhi %2 %8 %20 | |
| OpReturn | |
| OpFunctionEnd | |
| %6 = OpFunction %2 None %3 | |
| %7 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_DATA, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("OpPhi must not have void result type")); | |
| } | |
| TEST_F(ValidateCFG, InvalidExitSingleBlockLoop) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| OpName %5 "BAD" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %fn = OpFunction %void None %void_fn | |
| %1 = OpLabel | |
| OpBranch %2 | |
| %2 = OpLabel | |
| OpLoopMerge %3 %4 None | |
| OpBranchConditional %undef %3 %5 | |
| %5 = OpLabel | |
| OpLoopMerge %6 %5 None | |
| OpBranchConditional %undef %5 %4 | |
| %6 = OpLabel | |
| OpReturn | |
| %4 = OpLabel | |
| OpBranch %2 | |
| %3 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("block <ID> '1[%BAD]' exits the continue headed by <ID> " | |
| "'1[%BAD]', but not via a structured exit")); | |
| } | |
| TEST_F(ValidateCFG, SwitchSelectorNotAnInt) { | |
| const std::string spirv = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %main "main" | |
| OpExecutionMode %main LocalSize 1 1 1 | |
| %void = OpTypeVoid | |
| %float = OpTypeFloat 32 | |
| %float_1 = OpConstant %float 1 | |
| %void_fn = OpTypeFunction %void | |
| %main = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %default None | |
| OpSwitch %float_1 %default | |
| %default = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(spirv); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Selector type must be OpTypeInt")); | |
| } | |
| TEST_F(ValidateCFG, SwitchDefaultNotALabel) { | |
| const std::string spirv = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %main "main" | |
| OpExecutionMode %main LocalSize 1 1 1 | |
| %void = OpTypeVoid | |
| %int = OpTypeInt 32 0 | |
| %int_1 = OpConstant %int 1 | |
| %void_fn = OpTypeFunction %void | |
| %main = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpSelectionMerge %default None | |
| OpSwitch %int_1 %int_1 | |
| %default = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(spirv); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Default must be an OpLabel instruction")); | |
| } | |
| TEST_F(ValidateCFG, BlockDepthRecursion) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %main "main" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %main = OpFunction %void None %void_fn | |
| %1 = OpLabel | |
| OpBranch %2 | |
| %2 = OpLabel | |
| OpLoopMerge %3 %4 None | |
| OpBranchConditional %undef %3 %4 | |
| %4 = OpLabel | |
| OpBranch %2 | |
| %3 = OpLabel | |
| OpBranch %5 | |
| %5 = OpLabel | |
| OpSelectionMerge %2 None | |
| OpBranchConditional %undef %6 %7 | |
| %6 = OpLabel | |
| OpReturn | |
| %7 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, BadStructuredExitBackwardsMerge) { | |
| const std::string spirv = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint GLCompute %main "main" | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %main = OpFunction %void None %void_fn | |
| %1 = OpLabel | |
| OpBranch %2 | |
| %2 = OpLabel | |
| OpLoopMerge %4 %5 None | |
| OpBranchConditional %undef %4 %6 | |
| %6 = OpLabel | |
| OpSelectionMerge %7 None | |
| OpBranchConditional %undef %8 %9 | |
| %7 = OpLabel | |
| OpReturn | |
| %8 = OpLabel | |
| OpBranch %5 | |
| %9 = OpLabel | |
| OpSelectionMerge %6 None | |
| OpBranchConditional %undef %5 %5 | |
| %5 = OpLabel | |
| OpBranch %2 | |
| %4 = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(spirv); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| } | |
| TEST_F(ValidateCFG, BranchConditionalDifferentTargetsPre1p6) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranchConditional %undef %target %target | |
| %target = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text, SPV_ENV_UNIVERSAL_1_5); | |
| EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_UNIVERSAL_1_5)); | |
| } | |
| TEST_F(ValidateCFG, BranchConditionalDifferentTargetsPost1p6) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %void = OpTypeVoid | |
| %bool = OpTypeBool | |
| %undef = OpUndef %bool | |
| %void_fn = OpTypeFunction %void | |
| %func = OpFunction %void None %void_fn | |
| %entry = OpLabel | |
| OpBranchConditional %undef %target %target | |
| %target = OpLabel | |
| OpReturn | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text, SPV_ENV_UNIVERSAL_1_6); | |
| EXPECT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions(SPV_ENV_UNIVERSAL_1_6)); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("In SPIR-V 1.6 or later, True Label and False Label " | |
| "must be different labels")); | |
| } | |
| TEST_F(ValidateCFG, BadBackEdgeUnreachableContinue) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpCapability Linkage | |
| OpMemoryModel Logical GLSL450 | |
| %1 = OpTypeVoid | |
| %2 = OpTypeFunction %1 | |
| %3 = OpFunction %1 None %2 | |
| %4 = OpLabel | |
| OpBranch %5 | |
| %5 = OpLabel | |
| OpLoopMerge %6 %7 None | |
| OpBranch %8 | |
| %8 = OpLabel | |
| OpBranch %5 | |
| %7 = OpLabel | |
| OpUnreachable | |
| %6 = OpLabel | |
| OpUnreachable | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT( | |
| getDiagnosticString(), | |
| HasSubstr("The continue construct with the continue target '7[%7]' " | |
| "does not structurally dominate the back-edge block '8[%8]'")); | |
| } | |
| TEST_F(ValidateCFG, BadLoop) { | |
| const std::string text = R"( | |
| OpCapability Shader | |
| OpMemoryModel Logical Simple | |
| OpEntryPoint Fragment %2 " " | |
| OpExecutionMode %2 OriginUpperLeft | |
| OpName %49 "loop" | |
| %void = OpTypeVoid | |
| %12 = OpTypeFunction %void | |
| %2 = OpFunction %void None %12 | |
| %33 = OpLabel | |
| OpBranch %49 | |
| %50 = OpLabel | |
| OpBranch %49 | |
| %49 = OpLabel | |
| OpLoopMerge %33 %50 Unroll | |
| OpBranch %49 | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("Loop header '2[%loop]' is targeted by 2 back-edge " | |
| "blocks but the standard requires exactly one")); | |
| } | |
| TEST_F(ValidateCFG, BadSwitch) { | |
| const std::string text = R"( | |
| OpCapability StorageImageExtendedFormats | |
| OpMemoryModel Logical GLSL450 | |
| OpEntryPoint Fragment %2 "blah" %58 | |
| OpExecutionMode %2 OriginUpperLeft | |
| OpName %BAD "BAD" | |
| %11 = OpTypeVoid | |
| %12 = OpTypeFunction %11 | |
| %19 = OpTypeInt 32 1 | |
| %21 = OpConstant %19 555758549 | |
| %2 = OpFunction %11 None %12 | |
| %4 = OpLabel | |
| OpBranch %33 | |
| %33 = OpLabel | |
| OpLoopMerge %34 %35 None | |
| OpBranch %55 | |
| %BAD = OpLabel | |
| OpSelectionMerge %53 None | |
| OpSwitch %21 %34 196153896 %53 20856160 %34 33570306 %34 593494531 %52 | |
| %55 = OpLabel | |
| OpLoopMerge %52 %58 DontUnroll | |
| OpBranch %35 | |
| %58 = OpLabel | |
| OpSelectionMerge %58 None | |
| OpSwitch %21 %52 178168 %55 608223677 %34 604111047 %34 -553516825 %34 -106432813 %BAD 6946864 %55 1257373689 %55 973090296 %35 -113180668 %55 537002232 %BAD 13762553 %BAD 1030172152 %35 -553516825 %55 -262137 %35 -1091822332 %BAD 131320 %52 131321 %35 131320 %52 131321 %35 -1091822332 %BAD | |
| %53 = OpLabel | |
| OpBranch %35 | |
| %52 = OpLabel | |
| OpBranch %34 | |
| %35 = OpLabel | |
| OpBranch %33 | |
| %34 = OpLabel | |
| OpKill | |
| OpFunctionEnd | |
| )"; | |
| CompileSuccessfully(text); | |
| EXPECT_EQ(SPV_ERROR_INVALID_CFG, ValidateInstructions()); | |
| EXPECT_THAT(getDiagnosticString(), | |
| HasSubstr("exits the selection headed by <ID> '3[%BAD]', but not " | |
| "via a structured exit")); | |
| } | |
| } // namespace | |
| } // namespace val | |
| } // namespace spvtools |