commit b8bcc42a41e53e492e0f64ad880b69093da15c10
author Nicolas Capens <capn@google.com> Mon Jul 26 11:59:26 2021 -0400
committer Nicolas Capens <nicolascapens@google.com> Tue Jul 27 15:05:31 2021 +0000
tree 48ef6680c2b75f6436ee72d0501e0c52badebe8a
parent fdb16bd6c291d5747112ccba33fab0bfbea9651e

Remove -Wno-unused-but-set-variable flag usage

Bug: chromium:1203071
Change-Id: Id9a90cf5eb056965167e62dd2bf976eb25c19bdd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/56048
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

src/OpenGL/libEGL/BUILD.gn

diff --git a/src/OpenGL/libEGL/BUILD.gn b/src/OpenGL/libEGL/BUILD.gn
index cf86974..5e4cbd3 100644
--- a/src/OpenGL/libEGL/BUILD.gn
+++ b/src/OpenGL/libEGL/BUILD.gn
@@ -32,9 +32,6 @@
       "-Wno-sign-compare",
       "-Wno-unused-function",
     ]
-    if (!is_clang) {
-      cflags += [ "-Wno-unused-but-set-variable" ]
-    }
 
     if (is_mac) {
       cflags += [ "-fvisibility=protected" ]

src/OpenGL/libGLESv2/BUILD.gn

diff --git a/src/OpenGL/libGLESv2/BUILD.gn b/src/OpenGL/libGLESv2/BUILD.gn
index fc3ba3a..3112028 100644
--- a/src/OpenGL/libGLESv2/BUILD.gn
+++ b/src/OpenGL/libGLESv2/BUILD.gn
@@ -41,9 +41,6 @@
     }
   } else {
     cflags = [ "-Wno-sign-compare" ]
-    if (!is_clang) {
-      cflags += [ "-Wno-unused-but-set-variable" ]
-    }
 
     defines += [
       "__STDC_CONSTANT_MACROS",

third_party/llvm-10.0/CMakeLists.txt

diff --git a/third_party/llvm-10.0/CMakeLists.txt b/third_party/llvm-10.0/CMakeLists.txt
index 96141e9..a7d4214 100644
--- a/third_party/llvm-10.0/CMakeLists.txt
+++ b/third_party/llvm-10.0/CMakeLists.txt
@@ -1174,7 +1174,6 @@
     list(APPEND LLVM_COMPILE_OPTIONS
         "-Wno-noexcept-type"           # mangled name for ‘X’ will change in C++17 because the exception specification is part of a function type
         "-Wno-maybe-uninitialized"     # ‘X’ may be used uninitialized in this function
-        "-Wno-unused-but-set-variable" # variable ‘X’ set but not used
     )
     if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 8)
         list(APPEND LLVM_COMPILE_OPTIONS