commit b3c4d88a647a8899944347497dda4b176a4c1ec2
author Alexis Hetu <sugoi@google.com> Tue Nov 13 13:28:20 2018 -0500
committer Alexis Hétu <sugoi@google.com> Tue Nov 13 19:27:50 2018 +0000
tree 20351a026a15c52067ca5874a22835e73805b609
parent 6ed398b46847732242418340fbf8c8a177165b1b

Disabling the debugger wait dialog by default with Vulkan

For some reason, the Vulkan Loader prevents any dialog window from
popping up, which means that loading the SwiftShader Vulkan DLL in
Debug was always failing, unless a debugger was already attached
(as is the case when running from within Visual Studio). The
debugger wait dialog can still be easily enabled locally by setting
the DEBUGGER_WAIT_DIALOG environment variable.

Bug b/116336664

Change-Id: I7ce596c753506c806bf6b159685a72d0372f949a
Reviewed-on: https://swiftshader-review.googlesource.com/c/22488
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

src/Vulkan/vulkan.vcxproj

diff --git a/src/Vulkan/vulkan.vcxproj b/src/Vulkan/vulkan.vcxproj
index 5258dc6..89062a8 100644
--- a/src/Vulkan/vulkan.vcxproj
+++ b/src/Vulkan/vulkan.vcxproj
@@ -83,7 +83,7 @@
       <Optimization>Disabled</Optimization>

       <SDLCheck>true</SDLCheck>

       <AdditionalIncludeDirectories>$(SolutionDir)include;$(SolutionDir)src;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>

-      <PreprocessorDefinitions>_DEBUG;_WINDOWS;_USRDLL;_CRT_SECURE_NO_DEPRECATE;NOMINMAX;DEBUGGER_WAIT_DIALOG;%(PreprocessorDefinitions)</PreprocessorDefinitions>

+      <PreprocessorDefinitions>_DEBUG;_WINDOWS;_USRDLL;_CRT_SECURE_NO_DEPRECATE;NOMINMAX;%(PreprocessorDefinitions)</PreprocessorDefinitions>

       <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>

       <AdditionalOptions>/permissive- %(AdditionalOptions)</AdditionalOptions>

       <TreatSpecificWarningsAsErrors>4018;5038;4838</TreatSpecificWarningsAsErrors>