| commit | ad33af09869902037dedb9eab5c8acfa6eff6aec | [log] [tgz] |
|---|---|---|
| author | Romaric Jodin <rjodin@chromium.org> | Wed Oct 26 15:35:03 2022 +0200 |
| committer | swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 26 14:18:38 2022 +0000 |
| tree | f1b046ad8fa23c6f202b550f9de2cf1ab9cac4e6 | |
| parent | 3cbe2768b06a47978655c4d8f0a967a5685bb72c [diff] |
libVulkan.cpp: add missing struct in vkCreateDevice swiftshader reports supporting vulkan 1.2. As such vkCreateDevice needs to accept VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES and VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES, even so those features are not supported. This CL aims at fixing clvk (OpenCL over Vulkan): https://github.com/kpet/clvk/issues/441 https://github.com/kpet/clvk/pull/443 https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_shader_float16_int8.html#_promotion_to_vulkan_1_2 https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_8bit_storage.html#_promotion_to_vulkan_1_2 Bug: b/181875303 Change-Id: I82ed41f84c30aa7ce73ffcc9f3e5fe0b763c5d73 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/69328 Tested-by: Romaric Jodin <rjodin@chromium.org> Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Romaric Jodin <rjodin@chromium.org>
diff --git a/src/Vulkan/libVulkan.cpp b/src/Vulkan/libVulkan.cpp index 8cca4c8..06f97cb 100644 --- a/src/Vulkan/libVulkan.cpp +++ b/src/Vulkan/libVulkan.cpp
@@ -1080,6 +1080,8 @@ } break; // These structs are supported, but no behavior changes based on their feature flags + case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES: + case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES: case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES: case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES: case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_4444_FORMATS_FEATURES_EXT: