commit a6ca3d4c0ccdac078ac2c0e0b80efc9ee16a31e0
author Nicolas Capens <capn@google.com> Tue Aug 24 23:41:21 2021 -0400
committer Nicolas Capens <nicolascapens@google.com> Thu Aug 26 21:42:09 2021 +0000
tree 721cf08d3f92df4cb3af2029174b9bc08e3b4d26
parent 0adc2145ec1e195cdd24d015b1d29b314f88e037

Implement VK_EXT_load_store_op_none

We currently don't discard any content between subpasses, so this is
a no-op aside from allowing the new VK_ATTACHMENT_LOAD_OP_NONE_EXT enum.

Note we write directly into the attachment, so we don't do anything for
any of the VkAttachmentStoreOp enums, including the new
VK_ATTACHMENT_STORE_OP_NONE_EXT.

Bug: b/192088265
Change-Id: Id4ae69082e19c4590a9b17a0951b8e7ae6a123ac
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/56630
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

src/Vulkan/VkFramebuffer.cpp

diff --git a/src/Vulkan/VkFramebuffer.cpp b/src/Vulkan/VkFramebuffer.cpp
index 4235fc1..2f75d7c 100644
--- a/src/Vulkan/VkFramebuffer.cpp
+++ b/src/Vulkan/VkFramebuffer.cpp
@@ -90,6 +90,7 @@
 			break;
 		case VK_ATTACHMENT_LOAD_OP_LOAD:
 		case VK_ATTACHMENT_LOAD_OP_DONT_CARE:
+		case VK_ATTACHMENT_LOAD_OP_NONE_EXT:
 			// Don't clear the attachment's color or depth aspect.
 			break;
 		default:
@@ -103,6 +104,7 @@
 			break;
 		case VK_ATTACHMENT_LOAD_OP_LOAD:
 		case VK_ATTACHMENT_LOAD_OP_DONT_CARE:
+		case VK_ATTACHMENT_LOAD_OP_NONE_EXT:
 			// Don't clear the attachment's stencil aspect.
 			break;
 		default:

src/Vulkan/libVulkan.cpp

diff --git a/src/Vulkan/libVulkan.cpp b/src/Vulkan/libVulkan.cpp
index 110e344..c42ca2d4 100644
--- a/src/Vulkan/libVulkan.cpp
+++ b/src/Vulkan/libVulkan.cpp
@@ -353,6 +353,7 @@
 	{ { VK_KHR_SEPARATE_DEPTH_STENCIL_LAYOUTS_EXTENSION_NAME, VK_KHR_SEPARATE_DEPTH_STENCIL_LAYOUTS_SPEC_VERSION } },
 	{ { VK_EXT_DEPTH_CLIP_ENABLE_EXTENSION_NAME, VK_EXT_DEPTH_CLIP_ENABLE_SPEC_VERSION } },
 	{ { VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME, VK_EXT_CUSTOM_BORDER_COLOR_SPEC_VERSION } },
+	{ { VK_EXT_LOAD_STORE_OP_NONE_EXTENSION_NAME, VK_EXT_LOAD_STORE_OP_NONE_SPEC_VERSION } },
 	// Only 1.1 core version of this is supported. The extension has additional requirements
 	//{{ VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME, VK_KHR_SHADER_DRAW_PARAMETERS_SPEC_VERSION }},
 	{ { VK_KHR_STORAGE_BUFFER_STORAGE_CLASS_EXTENSION_NAME, VK_KHR_STORAGE_BUFFER_STORAGE_CLASS_SPEC_VERSION } },