commit 951192f3c2b20d78ba3a54ca0d00d3b0c4cc9468
author Stephan Hartmann <stha09@googlemail.com> Sun Jun 20 16:31:35 2021 +0000
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 28 14:32:07 2021 +0000
tree 02824d40a38673a06134ee138475c8fe908889be
parent f679fc179b9b478bf5f116026df9c8d483ab3c65

GCC: readd visibility attributes for EGL/GLESv2

https://crbug.com/1122889 removed all defines for EGLAPI and
GL_APICALL when compiled with GCC. However, that made all symbols
of libEGL.so and libGLESv2.so hidden. Therefore SwiftShader
can't be used with Chromium anymore.

Bug: chromium:1122889
Change-Id: Ic05e7b5539537731141d945cf7944d07f4c389df
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/55048
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

src/OpenGL/libEGL/BUILD.gn

diff --git a/src/OpenGL/libEGL/BUILD.gn b/src/OpenGL/libEGL/BUILD.gn
index 1421911..cf86974 100644
--- a/src/OpenGL/libEGL/BUILD.gn
+++ b/src/OpenGL/libEGL/BUILD.gn
@@ -42,7 +42,7 @@
     } else if (is_clang) {
       defines += [ "EGLAPI=__attribute__((visibility(\"protected\"))) __attribute__((no_sanitize(\"function\")))" ]
     } else {
-      defines += [ "EGLAPI= " ]
+      defines += [ "EGLAPI=__attribute__((visibility(\"protected\")))" ]
     }
   }
 }

src/OpenGL/libGLESv2/BUILD.gn

diff --git a/src/OpenGL/libGLESv2/BUILD.gn b/src/OpenGL/libGLESv2/BUILD.gn
index f71dc68..fc3ba3a 100644
--- a/src/OpenGL/libGLESv2/BUILD.gn
+++ b/src/OpenGL/libGLESv2/BUILD.gn
@@ -57,7 +57,7 @@
     } else if (is_clang) {
       defines += [ "GL_APICALL=__attribute__((visibility(\"protected\"))) __attribute__((no_sanitize(\"function\")))" ]
     } else {
-      defines += [ "GL_APICALL= " ]
+      defines += [ "GL_APICALL=__attribute__((visibility(\"protected\")))" ]
     }
   }
 }