commit 8f71f7311f29a2ef769d3d61bdbc73ecd6ceccb2
author Ben Clayton <headlessclayton@gmail.com> Fri Feb 01 09:38:45 2019 +0000
committer Chris Forbes <chrisforbes@google.com> Tue Feb 05 11:08:04 2019 +0000
tree 74cae8fcbf26e1e8e07d94675edd0ad0e482e76b
parent 049ff387333469cf9b6b92c0014ac034c0cac18e

Fix linux link error when using LLVM reactor backend.

Seen building on Ubuntu 18.04.1:

```
libllvm.a(DynamicLibrary.cpp.o): In function `llvm::sys::DynamicLibrary::HandleSet::~HandleSet()':
DynamicLibrary.cpp:(.text._ZN4llvm3sys14DynamicLibrary9HandleSetD2Ev+0x1c): undefined reference to `dlclose'
DynamicLibrary.cpp:(.text._ZN4llvm3sys14DynamicLibrary9HandleSetD2Ev+0x2c): undefined reference to `dlclose'
libllvm.a(DynamicLibrary.cpp.o): In function `llvm::sys::DynamicLibrary::HandleSet::DLSym(void*, char const*)':
DynamicLibrary.cpp:(.text._ZN4llvm3sys14DynamicLibrary9HandleSet5DLSymEPvPKc+0x1): undefined reference to `dlsym'
```

Also removes --no-as-needed hack.

Bug: b/123360006
Change-Id: Icef1078e68cbf68af991e52f7fbb6e8d449e0809
Reviewed-on: https://swiftshader-review.googlesource.com/c/24310
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ee373b0..206e82f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -156,11 +156,6 @@
         if(NOT MSAN AND NOT ASAN AND NOT TSAN AND NOT UBSAN)
             set_property(TARGET ${TARGET} APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--no-undefined")
         endif()
-
-        # Older version of GCC have problem linking libdl when --as-needed is set.
-        if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0)
-            set_property(TARGET ${TARGET} APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--no-as-needed")
-        endif()
     endif()
 endmacro()
 
@@ -1744,6 +1739,11 @@
     FOLDER "LLVM"
 )
 
+# Add required libraries for LLVM
+if(LINUX)
+    target_link_libraries(llvm dl)
+endif(LINUX)
+
 ###########################################################
 # Subzero
 ###########################################################