commit 8e8e1d0dd7292440b803b95bc0832589520f784d
author Ben Clayton <bclayton@google.com> Mon Feb 03 20:45:37 2020 +0000
committer Ben Clayton <bclayton@google.com> Tue Feb 04 20:00:49 2020 +0000
tree 14cf9153a0c158738ff91a09d40161013003b901
parent 3a2dfcbef3b6f5bf7ed0588dfe6eeb4fd7bd8d7b

Shader: Add missing switch cases to operationString

These used to assert.
Instead of asserting, let the compiler warn about unhandled cases - there's already a `return "<unknown>"` statement below the switch.

Credit to Dan Sinclair who did all the hard work here.

Bug: None - maintenance fix for legacy code
Change-Id: I010a1d6228961a80a15523ff1a2c6db522b7756d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40833
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

src/Shader/Shader.cpp

diff --git a/src/Shader/Shader.cpp b/src/Shader/Shader.cpp
index fe0c0ac..7b60697 100644
--- a/src/Shader/Shader.cpp
+++ b/src/Shader/Shader.cpp
@@ -903,6 +903,7 @@
 		case OPCODE_TEXBIAS:         return "texbias";
 		case OPCODE_TEXOFFSET:       return "texoffset";
 		case OPCODE_TEXOFFSETBIAS:   return "texoffsetbias";
+		case OPCODE_TEXLOD:          return "texlod";
 		case OPCODE_TEXLODOFFSET:    return "texlodoffset";
 		case OPCODE_TEXELFETCH:      return "texelfetch";
 		case OPCODE_TEXELFETCHOFFSET: return "texelfetchoffset";
@@ -992,8 +993,7 @@
 		case OPCODE_TEST:            return "test";
 		case OPCODE_SWITCH:          return "switch";
 		case OPCODE_ENDSWITCH:       return "endswitch";
-		default:
-			ASSERT(false);
+		case OPCODE_SCALAR:          return "scalar";
 		}
 
 		return "<unknown>";