commit 8dceaddf8503b9a83e07ff7788b3edfbb0d9665a
author Nicolas Capens <capn@google.com> Fri Nov 06 14:36:13 2020 -0500
committer Nicolas Capens <nicolascapens@google.com> Mon Nov 16 14:58:02 2020 +0000
tree ca0a39db45d810fb5321f5c060d6da0e8b8321f0
parent e4c1a25cc6797a47043fc415c53b8edcd7b3e37e

Enable Reactor Print() in Debug/RelWithDebInfo builds

The rr::Print() functionality is intended for debugging, so it should
always be available in Debug builds without having to set the CMake
flag explicitly. This also helps us avoid inadvertently breaking it.

Also consistently use TRUE/FALSE for Boolean values instead of a string.

Bug: b/149328074
Change-Id: Iab7e0f230dcd5b42679d64ef75bf3c0a3809a0d0
Signed-off-by: Nicolas Capens <capn@google.com>
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/50076
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 49dadc5..28b950c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -554,10 +554,15 @@
     endif()
 endif()
 
+# Enable Reactor Print() functionality in Debug/RelWithDebInfo builds or when explicitly enabled.
+if(CMAKE_BUILD_TYPE MATCHES "Deb")
+    set(REACTOR_ENABLE_PRINT TRUE)
+endif()
+
 if(REACTOR_EMIT_PRINT_LOCATION)
     # This feature depends on REACTOR_EMIT_DEBUG_INFO and REACTOR_ENABLE_PRINT
-    set(REACTOR_EMIT_DEBUG_INFO "On")
-    set(REACTOR_ENABLE_PRINT "On")
+    set(REACTOR_EMIT_DEBUG_INFO TRUE)
+    set(REACTOR_ENABLE_PRINT TRUE)
     list(APPEND SWIFTSHADER_COMPILE_OPTIONS "-DENABLE_RR_EMIT_PRINT_LOCATION")
 endif()