commit 8d9a45b1f3ab73a78e44336d12749929b8539fb6
author Ben Clayton <bclayton@google.com> Sun Jul 23 23:48:05 2023 +0100
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 24 13:27:30 2023 +0000
tree 1a4b6eab53bcbc060b6585708d95488a522c40e9
parent 66d6b0dd0c392aad9190447d66565ed9393921b9

LLVMReactor: Remove CreateFreeze() call

The RHS is now clamped. The freeze should be unnecessary.

Bug: swiftshader:185
Change-Id: I8c9c44a97884cad7717618f999f4a62598c2ce92
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/72108
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@google.com>
Reviewed-by: Corentin Wallez <cwallez@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

src/Reactor/LLVMReactor.cpp

diff --git a/src/Reactor/LLVMReactor.cpp b/src/Reactor/LLVMReactor.cpp
index f871515..fde6476 100644
--- a/src/Reactor/LLVMReactor.cpp
+++ b/src/Reactor/LLVMReactor.cpp
@@ -824,14 +824,14 @@
 {
 	RR_DEBUG_INFO_UPDATE_LOC();
 	auto *clamped_rhs = clampForShift(V(rhs));
-	return V(jit->builder->CreateFreeze(jit->builder->CreateShl(V(lhs), clamped_rhs)));
+	return V(jit->builder->CreateShl(V(lhs), clamped_rhs));
 }
 
 Value *Nucleus::createLShr(Value *lhs, Value *rhs)
 {
 	RR_DEBUG_INFO_UPDATE_LOC();
 	auto *clamped_rhs = clampForShift(V(rhs));
-	return V(jit->builder->CreateFreeze(jit->builder->CreateLShr(V(lhs), clamped_rhs)));
+	return V(jit->builder->CreateLShr(V(lhs), clamped_rhs));
 }
 
 Value *Nucleus::createAShr(Value *lhs, Value *rhs)