Intentionally ignore pipeline cache for now
Since PipelineCache is a potential optimization, unmarking it as
UNIMPLEMENTED() and leaving a TODO instead. This can be addressed
much later, but for now, this shouldn't make tests fail.
Bug b/118386749 b/123588002
Change-Id: I5bdc15aedd9a01e35a457eef1a70c450083fd577
Reviewed-on: https://swiftshader-review.googlesource.com/c/23969
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
diff --git a/src/Vulkan/libVulkan.cpp b/src/Vulkan/libVulkan.cpp
index 0fc4adb..00fe21d 100644
--- a/src/Vulkan/libVulkan.cpp
+++ b/src/Vulkan/libVulkan.cpp
@@ -930,10 +930,7 @@
TRACE("(VkDevice device = 0x%X, VkPipelineCache pipelineCache = 0x%X, uint32_t createInfoCount = %d, const VkGraphicsPipelineCreateInfo* pCreateInfos, const VkAllocationCallbacks* pAllocator = 0x%X, VkPipeline* pPipelines = 0x%X)",
device, pipelineCache, createInfoCount, pCreateInfos, pAllocator, pPipelines);
- if(pipelineCache != VK_NULL_HANDLE)
- {
- UNIMPLEMENTED();
- }
+ // TODO (b/123588002): Optimize based on pipelineCache.
VkResult errorResult = VK_SUCCESS;
for(uint32_t i = 0; i < createInfoCount; i++)
@@ -966,10 +963,7 @@
TRACE("(VkDevice device = 0x%X, VkPipelineCache pipelineCache = 0x%X, uint32_t createInfoCount = %d, const VkComputePipelineCreateInfo* pCreateInfos, const VkAllocationCallbacks* pAllocator = 0x%X, VkPipeline* pPipelines = 0x%X)",
device, pipelineCache, createInfoCount, pCreateInfos, pAllocator, pPipelines);
- if(pipelineCache != VK_NULL_HANDLE)
- {
- UNIMPLEMENTED();
- }
+ // TODO (b/123588002): Optimize based on pipelineCache.
VkResult errorResult = VK_SUCCESS;
for(uint32_t i = 0; i < createInfoCount; i++)
