commit 84d0f7cbbb9bd16b4378b4dc992c6774825c8e11
author Antonio Maiorano <amaiorano@google.com> Tue Nov 05 15:55:20 2019 -0500
committer Antonio Maiorano <amaiorano@google.com> Mon Dec 09 14:13:23 2019 +0000
tree ca5fc3ed7ea1f046f5433fa239204dac021d9167
parent f523485ec4f02ae408019a3e21ffe5678027ace8

Revert "Fix materialization of function arguments"

This reverts commit 51d98676b0efc64398e026f4e0a3ab92a73f206f.
No longer needed, as the root problem was fixed in
7fefd4833b96e0eea1478d4a3751bb7662504bfc
(https://swiftshader-review.googlesource.com/c/SwiftShader/+/37273)

Bug: b/129757459
Change-Id: I70da0bf00fd737e395a264c1f8bfd4b25325e4bc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37930
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

src/Reactor/Reactor.cpp

diff --git a/src/Reactor/Reactor.cpp b/src/Reactor/Reactor.cpp
index 29e1292..79c0891 100644
--- a/src/Reactor/Reactor.cpp
+++ b/src/Reactor/Reactor.cpp
@@ -185,7 +185,6 @@
 
 	Bool::Bool(Argument<Bool> argument)
 	{
-		materialize();  // FIXME(b/129757459)
 		storeValue(argument.value);
 	}
 
@@ -261,7 +260,6 @@
 
 	Byte::Byte(Argument<Byte> argument)
 	{
-		materialize();  // FIXME(b/129757459)
 		storeValue(argument.value);
 	}
 
@@ -519,7 +517,6 @@
 
 	SByte::SByte(Argument<SByte> argument)
 	{
-		materialize();  // FIXME(b/129757459)
 		storeValue(argument.value);
 	}
 
@@ -765,7 +762,6 @@
 
 	Short::Short(Argument<Short> argument)
 	{
-		materialize();  // FIXME(b/129757459)
 		storeValue(argument.value);
 	}
 
@@ -1004,7 +1000,6 @@
 
 	UShort::UShort(Argument<UShort> argument)
 	{
-		materialize();  // FIXME(b/129757459)
 		storeValue(argument.value);
 	}
 
@@ -2220,7 +2215,6 @@
 
 	Int::Int(Argument<Int> argument)
 	{
-		materialize();  // FIXME(b/129757459)
 		storeValue(argument.value);
 	}
 
@@ -2660,7 +2654,6 @@
 
 	UInt::UInt(Argument<UInt> argument)
 	{
-		materialize();  // FIXME(b/129757459)
 		storeValue(argument.value);
 	}
 
@@ -3884,7 +3877,6 @@
 
 	Float::Float(Argument<Float> argument)
 	{
-		materialize();  // FIXME(b/129757459)
 		storeValue(argument.value);
 	}
 

src/Reactor/Reactor.hpp

diff --git a/src/Reactor/Reactor.hpp b/src/Reactor/Reactor.hpp
index 168764a..eec950b 100644
--- a/src/Reactor/Reactor.hpp
+++ b/src/Reactor/Reactor.hpp
@@ -2888,7 +2888,6 @@
 	template<class T>
 	Pointer<T>::Pointer(Argument<Pointer<T>> argument) : alignment(1)
 	{
-		LValue<Pointer<T>>::materialize();  // FIXME(b/129757459)
 		LValue<Pointer<T>>::storeValue(argument.value);
 	}