commit 78cfdcddd8c77a7620adf5db9296a81bcde225aa
author Alexis Hetu <sugoi@google.com> Thu Sep 01 10:55:48 2022 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Sep 01 16:24:38 2022 +0000
tree 086c281ac76493557c1b0dd99891f39156a07808
parent f99e45c6e720e36fde440c0400e735a06d663890

Remove the "--cached" flag from clang formatting

The "--cached" flag prevents developers from formatting local work in
progress, which is annoying. I always remove it locally, and it has
confused external developers as well. It is more straightforward and
intuitive to just format every modified file when running the script.

Bug: b/187094215
Change-Id: I8b48613bdbd70aeeeceb6dd03eda4bee0d0e6062
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/67930
Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Commit-Queue: Alexis Hétu <sugoi@google.com>

src/clang-format-all.sh

diff --git a/src/clang-format-all.sh b/src/clang-format-all.sh
index f68c60a8..9fb5a52 100755
--- a/src/clang-format-all.sh
+++ b/src/clang-format-all.sh
@@ -43,7 +43,7 @@
     done
 else
     BASEDIR=$(git rev-parse --show-toplevel)
-    FILES=$(git diff --cached --name-only --diff-filter=ACM | grep '\.cpp$\|\.hpp\|\.c$\|\.h$')
+    FILES=$(git diff --name-only --diff-filter=ACM | grep '\.cpp$\|\.hpp\|\.c$\|\.h$')
     for FILE in $FILES
     do
         ${CLANG_FORMAT} -i -style=file "$BASEDIR/$FILE"