commit 787f953343b0cd97e946682cc28be5d9900f2e49
author Raymond Chiu <chiur@google.com> Wed Jan 30 16:00:08 2019 -0800
committer Chris Forbes <chrisforbes@google.com> Thu Jan 31 00:24:17 2019 +0000
tree 1543a189fa5226aa889752e4af84ecc2016673f9
parent 77630f1e7d12c647a829dca1f07119ec3a784451

Add -Wl,--no-as-needed to ld flags

Older version of gcc mistakenly missed out on linking libdl without it.

Change-Id: I5c12972c140348fa504e4ff4acb81655b445b4a5
Reviewed-on: https://swiftshader-review.googlesource.com/c/24268
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index cb417fd..ee373b0 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -156,6 +156,11 @@
         if(NOT MSAN AND NOT ASAN AND NOT TSAN AND NOT UBSAN)
             set_property(TARGET ${TARGET} APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--no-undefined")
         endif()
+
+        # Older version of GCC have problem linking libdl when --as-needed is set.
+        if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0)
+            set_property(TARGET ${TARGET} APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--no-as-needed")
+        endif()
     endif()
 endmacro()
 

kokoro/gcp_ubuntu/continuous.sh

diff --git a/kokoro/gcp_ubuntu/continuous.sh b/kokoro/gcp_ubuntu/continuous.sh
index 4caf6ce..e1c5bc7 100755
--- a/kokoro/gcp_ubuntu/continuous.sh
+++ b/kokoro/gcp_ubuntu/continuous.sh
@@ -12,4 +12,4 @@
 mkdir -p build && cd build
 
 cmake ..
-make --jobs=$(nproc)
+make --jobs=$(nproc) VERBOSE=1