commit 766eb919cbf903d7228024626a07dec63cdd5f25
author Nico Weber <thakis@chromium.org> Thu Jul 08 14:13:38 2021 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jul 08 21:45:05 2021 +0000
tree e8b6f6ac76e840b3381af00cdc053c8d31b3c903
parent 6f0ce1280b25b3686694eb2035f7d7f71fab7a2a

Share ANGLE_DISABLE_TRACE-setting code between win and non-win

No behavior change.

Change-Id: Ibe79440616b7d37ba621b718c448bb9c6bad9b78
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/55631
Tested-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index fd2cf7f..1545aa1 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -21,6 +21,10 @@
 config("swiftshader_config") {
   defines = []
 
+  if (!is_debug) {
+    defines += [ "ANGLE_DISABLE_TRACE" ]
+  }
+
   if (is_win) {
     defines += [
       "_WINDLL",
@@ -31,10 +35,6 @@
       "_ENABLE_EXTENDED_ALIGNED_STORAGE",
     ]
 
-    if (!is_debug) {
-      defines += [ "ANGLE_DISABLE_TRACE" ]
-    }
-
     # Diable some MSVC warnings.
     if (!is_clang) {
       cflags += [
@@ -54,8 +54,6 @@
 
     if (!is_debug) {
       cflags += [ "-Os" ]
-
-      defines += [ "ANGLE_DISABLE_TRACE" ]
     }
 
     if (current_cpu == "x64") {  # 64 bit version