commit 749b4e0cee4a5ddec0dcbb103c113d4459f10738
author Ben Clayton <bclayton@google.com> Tue Apr 09 14:27:43 2019 -0400
committer Ben Clayton <bclayton@google.com> Thu Apr 11 02:42:08 2019 +0000
tree a407d5209a1c5f6cb9352709fd8121438bd05c7c
parent eafae4773877c3184448b47b3185d34003ac99c6

SpirvShader: Implement GLSLstd450Atan

Bug: b/126873455
Tests: dEQP-VK.glsl.builtin.precision.atan.*
Change-Id: Ic7dc89ca2b3253482e972ced46515fc83da33770
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28437
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

src/Pipeline/SpirvShader.cpp

diff --git a/src/Pipeline/SpirvShader.cpp b/src/Pipeline/SpirvShader.cpp
index ab12f60..14fcc0a 100644
--- a/src/Pipeline/SpirvShader.cpp
+++ b/src/Pipeline/SpirvShader.cpp
@@ -3329,6 +3329,16 @@
 			}
 			break;
 		}
+		case GLSLstd450Atan:
+		{
+			auto val = GenericValue(this, routine, insn.word(5));
+			for (auto i = 0u; i < type.sizeInComponents; i++)
+			{
+				dst.move(i, Atan(val.Float(i)));
+			}
+			break;
+		}
+
 		default:
 			UNIMPLEMENTED("Unhandled ExtInst %d", extInstIndex);
 		}

src/Reactor/LLVMReactor.cpp

diff --git a/src/Reactor/LLVMReactor.cpp b/src/Reactor/LLVMReactor.cpp
index d3fd354..5a3f5f6 100644
--- a/src/Reactor/LLVMReactor.cpp
+++ b/src/Reactor/LLVMReactor.cpp
@@ -558,6 +558,7 @@
 			func_.emplace("cosf", reinterpret_cast<void*>(cosf));
 			func_.emplace("asinf", reinterpret_cast<void*>(asinf));
 			func_.emplace("acosf", reinterpret_cast<void*>(acosf));
+			func_.emplace("atanf", reinterpret_cast<void*>(atanf));
 
 #ifdef __APPLE__
 			// LLVM uses this function on macOS for tan.
@@ -3114,6 +3115,11 @@
 		return TransformFloat4PerElement(v, "acosf");
 	}
 
+	RValue<Float4> Atan(RValue<Float4> v)
+	{
+		return TransformFloat4PerElement(v, "atanf");
+	}
+
 	Type *Float4::getType()
 	{
 		return T(llvm::VectorType::get(T(Float::getType()), 4));

src/Reactor/Reactor.hpp

diff --git a/src/Reactor/Reactor.hpp b/src/Reactor/Reactor.hpp
index 96c87e0..d9eb3e6 100644
--- a/src/Reactor/Reactor.hpp
+++ b/src/Reactor/Reactor.hpp
@@ -2213,6 +2213,7 @@
 	RValue<Float4> Tan(RValue<Float4> x);
 	RValue<Float4> Asin(RValue<Float4> x);
 	RValue<Float4> Acos(RValue<Float4> x);
+	RValue<Float4> Atan(RValue<Float4> x);
 
 	template<class T>
 	class Pointer : public LValue<Pointer<T>>