commit 6b06de217af9b6ef04dcf3b7ea372133d8f2bf18
author Leonard Grey <lgrey@chromium.org> Thu Aug 19 16:57:13 2021 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 20 13:43:50 2021 +0000
tree 3f3f8038d2dbbda32f3c7b3d367caebbfdc974ce
parent 34d436e2ab7ccc26e7a3ed8d0e79848bb1b9fd5a

Mac: use default visibility

Protected visibility is not supported in Mach-O. This currently fails
silently, but triggers errors in lld when enabling LTO.

Bug: chromium:471146

Change-Id: I61adfb1e18214596657cb3a6befe0a21caf96a9e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/56431
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Leonard Grey <lgrey@google.com>
Commit-Queue: Leonard Grey <lgrey@google.com>

src/OpenGL/libEGL/BUILD.gn

diff --git a/src/OpenGL/libEGL/BUILD.gn b/src/OpenGL/libEGL/BUILD.gn
index 5e4cbd3..2e6db82 100644
--- a/src/OpenGL/libEGL/BUILD.gn
+++ b/src/OpenGL/libEGL/BUILD.gn
@@ -34,7 +34,7 @@
     ]
 
     if (is_mac) {
-      cflags += [ "-fvisibility=protected" ]
+      cflags += [ "-fvisibility=default" ]
       defines += [ "EGLAPI=__attribute__((no_sanitize(\"function\")))" ]
     } else if (is_clang) {
       defines += [ "EGLAPI=__attribute__((visibility(\"protected\"))) __attribute__((no_sanitize(\"function\")))" ]

src/OpenGL/libGLESv2/BUILD.gn

diff --git a/src/OpenGL/libGLESv2/BUILD.gn b/src/OpenGL/libGLESv2/BUILD.gn
index 3112028..067ae74 100644
--- a/src/OpenGL/libGLESv2/BUILD.gn
+++ b/src/OpenGL/libGLESv2/BUILD.gn
@@ -49,7 +49,7 @@
     ]
 
     if (is_mac) {
-      cflags += [ "-fvisibility=protected" ]
+      cflags += [ "-fvisibility=default" ]
       defines += [ "GL_APICALL=__attribute__((no_sanitize(\"function\")))" ]
     } else if (is_clang) {
       defines += [ "GL_APICALL=__attribute__((visibility(\"protected\"))) __attribute__((no_sanitize(\"function\")))" ]