commit 65498c15ca60362b11673a023d326d60db1f6e9b
author Nico Weber <thakis@chromium.org> Thu Jul 08 11:35:05 2021 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 09 01:31:21 2021 +0000
tree 27feaa292540f00c82dbbc67512f1981dd957bb2
parent b77a8af7a5550a555ebace7a835feb4aebd082ef

Remove -Wno-error flags

The project has a strict warnings-as-errors policy. If any warnings
aren't interesting, we should disable those warnings, not
warnings-as-errors.

Change-Id: Ib3f5d21e6f368339a6af51582facdfa7508f4239
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/55609
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Nico Weber <thakis@google.com>
Tested-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

src/Reactor/BUILD.gn

diff --git a/src/Reactor/BUILD.gn b/src/Reactor/BUILD.gn
index afd22f1..e0d624c 100644
--- a/src/Reactor/BUILD.gn
+++ b/src/Reactor/BUILD.gn
@@ -148,10 +148,6 @@
         "-Wno-unused-function",
       ]
     }
-
-    if (is_fuchsia) {
-      cflags += [ "-Wno-error" ]
-    }
   }
 
   config("swiftshader_reactor_with_subzero_private_config") {
@@ -184,10 +180,6 @@
     if (is_clang) {
       cflags += [ "-Wno-header-hygiene" ]
     }
-
-    if (is_fuchsia) {
-      cflags += [ "-Wno-error" ]
-    }
   }
 
   swiftshader_source_set("swiftshader_subzero") {