| // Copyright (c) 2015-2016 The Khronos Group Inc. |
| // |
| // Licensed under the Apache License, Version 2.0 (the "License"); |
| // you may not use this file except in compliance with the License. |
| // You may obtain a copy of the License at |
| // |
| // http://www.apache.org/licenses/LICENSE-2.0 |
| // |
| // Unless required by applicable law or agreed to in writing, software |
| // distributed under the License is distributed on an "AS IS" BASIS, |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| // See the License for the specific language governing permissions and |
| // limitations under the License. |
| |
| // Performs validation on instructions that appear inside of a SPIR-V block. |
| |
| #include <algorithm> |
| #include <cassert> |
| #include <iomanip> |
| #include <sstream> |
| #include <string> |
| #include <vector> |
| |
| #include "source/binary.h" |
| #include "source/diagnostic.h" |
| #include "source/enum_set.h" |
| #include "source/enum_string_mapping.h" |
| #include "source/extensions.h" |
| #include "source/opcode.h" |
| #include "source/operand.h" |
| #include "source/spirv_constant.h" |
| #include "source/spirv_definition.h" |
| #include "source/spirv_target_env.h" |
| #include "source/spirv_validator_options.h" |
| #include "source/util/string_utils.h" |
| #include "source/val/function.h" |
| #include "source/val/validate.h" |
| #include "source/val/validation_state.h" |
| |
| namespace spvtools { |
| namespace val { |
| namespace { |
| |
| std::string ToString(const CapabilitySet& capabilities, |
| const AssemblyGrammar& grammar) { |
| std::stringstream ss; |
| capabilities.ForEach([&grammar, &ss](SpvCapability cap) { |
| spv_operand_desc desc; |
| if (SPV_SUCCESS == |
| grammar.lookupOperand(SPV_OPERAND_TYPE_CAPABILITY, cap, &desc)) |
| ss << desc->name << " "; |
| else |
| ss << cap << " "; |
| }); |
| return ss.str(); |
| } |
| |
| // Returns capabilities that enable an opcode. An empty result is interpreted |
| // as no prohibition of use of the opcode. If the result is non-empty, then |
| // the opcode may only be used if at least one of the capabilities is specified |
| // by the module. |
| CapabilitySet EnablingCapabilitiesForOp(const ValidationState_t& state, |
| SpvOp opcode) { |
| // Exceptions for SPV_AMD_shader_ballot |
| switch (opcode) { |
| // Normally these would require Group capability |
| case SpvOpGroupIAddNonUniformAMD: |
| case SpvOpGroupFAddNonUniformAMD: |
| case SpvOpGroupFMinNonUniformAMD: |
| case SpvOpGroupUMinNonUniformAMD: |
| case SpvOpGroupSMinNonUniformAMD: |
| case SpvOpGroupFMaxNonUniformAMD: |
| case SpvOpGroupUMaxNonUniformAMD: |
| case SpvOpGroupSMaxNonUniformAMD: |
| if (state.HasExtension(kSPV_AMD_shader_ballot)) return CapabilitySet(); |
| break; |
| default: |
| break; |
| } |
| // Look it up in the grammar |
| spv_opcode_desc opcode_desc = {}; |
| if (SPV_SUCCESS == state.grammar().lookupOpcode(opcode, &opcode_desc)) { |
| return state.grammar().filterCapsAgainstTargetEnv( |
| opcode_desc->capabilities, opcode_desc->numCapabilities); |
| } |
| return CapabilitySet(); |
| } |
| |
| // Returns SPV_SUCCESS if, for the given operand, the target environment |
| // satsifies minimum version requirements, or if the module declares an |
| // enabling extension for the operand. Otherwise emit a diagnostic and |
| // return an error code. |
| spv_result_t OperandVersionExtensionCheck( |
| ValidationState_t& _, const Instruction* inst, size_t which_operand, |
| const spv_operand_desc_t& operand_desc, uint32_t word) { |
| const uint32_t module_version = _.version(); |
| const uint32_t operand_min_version = operand_desc.minVersion; |
| const uint32_t operand_last_version = operand_desc.lastVersion; |
| const bool reserved = operand_min_version == 0xffffffffu; |
| const bool version_satisfied = !reserved && |
| (operand_min_version <= module_version) && |
| (module_version <= operand_last_version); |
| |
| if (version_satisfied) { |
| return SPV_SUCCESS; |
| } |
| |
| if (operand_last_version < module_version) { |
| return _.diag(SPV_ERROR_WRONG_VERSION, inst) |
| << spvtools::utils::CardinalToOrdinal(which_operand) |
| << " operand of " << spvOpcodeString(inst->opcode()) << ": operand " |
| << operand_desc.name << "(" << word << ") requires SPIR-V version " |
| << SPV_SPIRV_VERSION_MAJOR_PART(operand_last_version) << "." |
| << SPV_SPIRV_VERSION_MINOR_PART(operand_last_version) |
| << " or earlier"; |
| } |
| |
| if (!reserved && operand_desc.numExtensions == 0) { |
| return _.diag(SPV_ERROR_WRONG_VERSION, inst) |
| << spvtools::utils::CardinalToOrdinal(which_operand) |
| << " operand of " << spvOpcodeString(inst->opcode()) << ": operand " |
| << operand_desc.name << "(" << word << ") requires SPIR-V version " |
| << SPV_SPIRV_VERSION_MAJOR_PART(operand_min_version) << "." |
| << SPV_SPIRV_VERSION_MINOR_PART(operand_min_version) << " or later"; |
| } else { |
| ExtensionSet required_extensions(operand_desc.numExtensions, |
| operand_desc.extensions); |
| if (!_.HasAnyOfExtensions(required_extensions)) { |
| return _.diag(SPV_ERROR_MISSING_EXTENSION, inst) |
| << spvtools::utils::CardinalToOrdinal(which_operand) |
| << " operand of " << spvOpcodeString(inst->opcode()) |
| << ": operand " << operand_desc.name << "(" << word |
| << ") requires one of these extensions: " |
| << ExtensionSetToString(required_extensions); |
| } |
| } |
| return SPV_SUCCESS; |
| } |
| |
| // Returns SPV_SUCCESS if the given operand is enabled by capabilities declared |
| // in the module. Otherwise issues an error message and returns |
| // SPV_ERROR_INVALID_CAPABILITY. |
| spv_result_t CheckRequiredCapabilities(ValidationState_t& state, |
| const Instruction* inst, |
| size_t which_operand, |
| const spv_parsed_operand_t& operand, |
| uint32_t word) { |
| // Mere mention of PointSize, ClipDistance, or CullDistance in a Builtin |
| // decoration does not require the associated capability. The use of such |
| // a variable value should trigger the capability requirement, but that's |
| // not implemented yet. This rule is independent of target environment. |
| // See https://github.com/KhronosGroup/SPIRV-Tools/issues/365 |
| if (operand.type == SPV_OPERAND_TYPE_BUILT_IN) { |
| switch (word) { |
| case SpvBuiltInPointSize: |
| case SpvBuiltInClipDistance: |
| case SpvBuiltInCullDistance: |
| return SPV_SUCCESS; |
| default: |
| break; |
| } |
| } else if (operand.type == SPV_OPERAND_TYPE_FP_ROUNDING_MODE) { |
| // Allow all FP rounding modes if requested |
| if (state.features().free_fp_rounding_mode) { |
| return SPV_SUCCESS; |
| } |
| } else if (operand.type == SPV_OPERAND_TYPE_GROUP_OPERATION && |
| state.features().group_ops_reduce_and_scans && |
| (word <= uint32_t(SpvGroupOperationExclusiveScan))) { |
| // Allow certain group operations if requested. |
| return SPV_SUCCESS; |
| } |
| |
| CapabilitySet enabling_capabilities; |
| spv_operand_desc operand_desc = nullptr; |
| const auto lookup_result = |
| state.grammar().lookupOperand(operand.type, word, &operand_desc); |
| if (lookup_result == SPV_SUCCESS) { |
| // Allow FPRoundingMode decoration if requested. |
| if (operand.type == SPV_OPERAND_TYPE_DECORATION && |
| operand_desc->value == SpvDecorationFPRoundingMode) { |
| if (state.features().free_fp_rounding_mode) return SPV_SUCCESS; |
| |
| // Vulkan API requires more capabilities on rounding mode. |
| if (spvIsVulkanEnv(state.context()->target_env)) { |
| enabling_capabilities.Add(SpvCapabilityStorageUniformBufferBlock16); |
| enabling_capabilities.Add(SpvCapabilityStorageUniform16); |
| enabling_capabilities.Add(SpvCapabilityStoragePushConstant16); |
| enabling_capabilities.Add(SpvCapabilityStorageInputOutput16); |
| } |
| } else { |
| enabling_capabilities = state.grammar().filterCapsAgainstTargetEnv( |
| operand_desc->capabilities, operand_desc->numCapabilities); |
| } |
| |
| // When encountering an OpCapability instruction, the instruction pass |
| // registers a capability with the module *before* checking capabilities. |
| // So in the case of an OpCapability instruction, don't bother checking |
| // enablement by another capability. |
| if (inst->opcode() != SpvOpCapability) { |
| const bool enabled_by_cap = |
| state.HasAnyOfCapabilities(enabling_capabilities); |
| if (!enabling_capabilities.IsEmpty() && !enabled_by_cap) { |
| return state.diag(SPV_ERROR_INVALID_CAPABILITY, inst) |
| << "Operand " << which_operand << " of " |
| << spvOpcodeString(inst->opcode()) |
| << " requires one of these capabilities: " |
| << ToString(enabling_capabilities, state.grammar()); |
| } |
| } |
| return OperandVersionExtensionCheck(state, inst, which_operand, |
| *operand_desc, word); |
| } |
| return SPV_SUCCESS; |
| } |
| |
| // Returns SPV_ERROR_INVALID_BINARY and emits a diagnostic if the instruction |
| // is explicitly reserved in the SPIR-V core spec. Otherwise return |
| // SPV_SUCCESS. |
| spv_result_t ReservedCheck(ValidationState_t& _, const Instruction* inst) { |
| const SpvOp opcode = inst->opcode(); |
| switch (opcode) { |
| // These instructions are enabled by a capability, but should never |
| // be used anyway. |
| case SpvOpImageSparseSampleProjImplicitLod: |
| case SpvOpImageSparseSampleProjExplicitLod: |
| case SpvOpImageSparseSampleProjDrefImplicitLod: |
| case SpvOpImageSparseSampleProjDrefExplicitLod: { |
| spv_opcode_desc inst_desc; |
| _.grammar().lookupOpcode(opcode, &inst_desc); |
| return _.diag(SPV_ERROR_INVALID_BINARY, inst) |
| << "Invalid Opcode name 'Op" << inst_desc->name << "'"; |
| } |
| default: |
| break; |
| } |
| return SPV_SUCCESS; |
| } |
| |
| // Returns SPV_ERROR_INVALID_CAPABILITY and emits a diagnostic if the |
| // instruction is invalid because the required capability isn't declared |
| // in the module. |
| spv_result_t CapabilityCheck(ValidationState_t& _, const Instruction* inst) { |
| const SpvOp opcode = inst->opcode(); |
| CapabilitySet opcode_caps = EnablingCapabilitiesForOp(_, opcode); |
| if (!_.HasAnyOfCapabilities(opcode_caps)) { |
| return _.diag(SPV_ERROR_INVALID_CAPABILITY, inst) |
| << "Opcode " << spvOpcodeString(opcode) |
| << " requires one of these capabilities: " |
| << ToString(opcode_caps, _.grammar()); |
| } |
| for (size_t i = 0; i < inst->operands().size(); ++i) { |
| const auto& operand = inst->operand(i); |
| const auto word = inst->word(operand.offset); |
| if (spvOperandIsConcreteMask(operand.type)) { |
| // Check for required capabilities for each bit position of the mask. |
| for (uint32_t mask_bit = 0x80000000; mask_bit; mask_bit >>= 1) { |
| if (word & mask_bit) { |
| spv_result_t status = |
| CheckRequiredCapabilities(_, inst, i + 1, operand, mask_bit); |
| if (status != SPV_SUCCESS) return status; |
| } |
| } |
| } else if (spvIsIdType(operand.type)) { |
| // TODO(dneto): Check the value referenced by this Id, if we can compute |
| // it. For now, just punt, to fix issue 248: |
| // https://github.com/KhronosGroup/SPIRV-Tools/issues/248 |
| } else { |
| // Check the operand word as a whole. |
| spv_result_t status = |
| CheckRequiredCapabilities(_, inst, i + 1, operand, word); |
| if (status != SPV_SUCCESS) return status; |
| } |
| } |
| return SPV_SUCCESS; |
| } |
| |
| // Checks that the instruction can be used in this target environment's base |
| // version. Assumes that CapabilityCheck has checked direct capability |
| // dependencies for the opcode. |
| spv_result_t VersionCheck(ValidationState_t& _, const Instruction* inst) { |
| const auto opcode = inst->opcode(); |
| spv_opcode_desc inst_desc; |
| const spv_result_t r = _.grammar().lookupOpcode(opcode, &inst_desc); |
| assert(r == SPV_SUCCESS); |
| (void)r; |
| |
| const auto min_version = inst_desc->minVersion; |
| const auto last_version = inst_desc->lastVersion; |
| const auto module_version = _.version(); |
| |
| if (last_version < module_version) { |
| return _.diag(SPV_ERROR_WRONG_VERSION, inst) |
| << spvOpcodeString(opcode) << " requires SPIR-V version " |
| << SPV_SPIRV_VERSION_MAJOR_PART(last_version) << "." |
| << SPV_SPIRV_VERSION_MINOR_PART(last_version) << " or earlier"; |
| } |
| |
| // OpTerminateInvocation is special because it is enabled by Shader |
| // capability, but also requires an extension and/or version check. |
| const bool capability_check_is_sufficient = |
| inst->opcode() != SpvOpTerminateInvocation; |
| |
| if (capability_check_is_sufficient && (inst_desc->numCapabilities > 0u)) { |
| // We already checked that the direct capability dependency has been |
| // satisfied. We don't need to check any further. |
| return SPV_SUCCESS; |
| } |
| |
| ExtensionSet exts(inst_desc->numExtensions, inst_desc->extensions); |
| if (exts.IsEmpty()) { |
| // If no extensions can enable this instruction, then emit error |
| // messages only concerning core SPIR-V versions if errors happen. |
| if (min_version == ~0u) { |
| return _.diag(SPV_ERROR_WRONG_VERSION, inst) |
| << spvOpcodeString(opcode) << " is reserved for future use."; |
| } |
| |
| if (module_version < min_version) { |
| return _.diag(SPV_ERROR_WRONG_VERSION, inst) |
| << spvOpcodeString(opcode) << " requires SPIR-V version " |
| << SPV_SPIRV_VERSION_MAJOR_PART(min_version) << "." |
| << SPV_SPIRV_VERSION_MINOR_PART(min_version) << " at minimum."; |
| } |
| } else if (!_.HasAnyOfExtensions(exts)) { |
| // Otherwise, we only error out when no enabling extensions are |
| // registered. |
| if (min_version == ~0u) { |
| return _.diag(SPV_ERROR_MISSING_EXTENSION, inst) |
| << spvOpcodeString(opcode) |
| << " requires one of the following extensions: " |
| << ExtensionSetToString(exts); |
| } |
| |
| if (module_version < min_version) { |
| return _.diag(SPV_ERROR_WRONG_VERSION, inst) |
| << spvOpcodeString(opcode) << " requires SPIR-V version " |
| << SPV_SPIRV_VERSION_MAJOR_PART(min_version) << "." |
| << SPV_SPIRV_VERSION_MINOR_PART(min_version) |
| << " at minimum or one of the following extensions: " |
| << ExtensionSetToString(exts); |
| } |
| } |
| |
| return SPV_SUCCESS; |
| } |
| |
| // Checks that the Resuld <id> is within the valid bound. |
| spv_result_t LimitCheckIdBound(ValidationState_t& _, const Instruction* inst) { |
| if (inst->id() >= _.getIdBound()) { |
| return _.diag(SPV_ERROR_INVALID_BINARY, inst) |
| << "Result <id> '" << inst->id() |
| << "' must be less than the ID bound '" << _.getIdBound() << "'."; |
| } |
| return SPV_SUCCESS; |
| } |
| |
| // Checks that the number of OpTypeStruct members is within the limit. |
| spv_result_t LimitCheckStruct(ValidationState_t& _, const Instruction* inst) { |
| if (SpvOpTypeStruct != inst->opcode()) { |
| return SPV_SUCCESS; |
| } |
| |
| // Number of members is the number of operands of the instruction minus 1. |
| // One operand is the result ID. |
| const uint16_t limit = |
| static_cast<uint16_t>(_.options()->universal_limits_.max_struct_members); |
| if (inst->operands().size() - 1 > limit) { |
| return _.diag(SPV_ERROR_INVALID_BINARY, inst) |
| << "Number of OpTypeStruct members (" << inst->operands().size() - 1 |
| << ") has exceeded the limit (" << limit << ")."; |
| } |
| |
| // Section 2.17 of SPIRV Spec specifies that the "Structure Nesting Depth" |
| // must be less than or equal to 255. |
| // This is interpreted as structures including other structures as |
| // members. The code does not follow pointers or look into arrays to see |
| // if we reach a structure downstream. The nesting depth of a struct is |
| // 1+(largest depth of any member). Scalars are at depth 0. |
| uint32_t max_member_depth = 0; |
| // Struct members start at word 2 of OpTypeStruct instruction. |
| for (size_t word_i = 2; word_i < inst->words().size(); ++word_i) { |
| auto member = inst->word(word_i); |
| auto memberTypeInstr = _.FindDef(member); |
| if (memberTypeInstr && SpvOpTypeStruct == memberTypeInstr->opcode()) { |
| max_member_depth = std::max( |
| max_member_depth, _.struct_nesting_depth(memberTypeInstr->id())); |
| } |
| } |
| |
| const uint32_t depth_limit = _.options()->universal_limits_.max_struct_depth; |
| const uint32_t cur_depth = 1 + max_member_depth; |
| _.set_struct_nesting_depth(inst->id(), cur_depth); |
| if (cur_depth > depth_limit) { |
| return _.diag(SPV_ERROR_INVALID_BINARY, inst) |
| << "Structure Nesting Depth may not be larger than " << depth_limit |
| << ". Found " << cur_depth << "."; |
| } |
| return SPV_SUCCESS; |
| } |
| |
| // Checks that the number of (literal, label) pairs in OpSwitch is within |
| // the limit. |
| spv_result_t LimitCheckSwitch(ValidationState_t& _, const Instruction* inst) { |
| if (SpvOpSwitch == inst->opcode()) { |
| // The instruction syntax is as follows: |
| // OpSwitch <selector ID> <Default ID> literal label literal label ... |
| // literal,label pairs come after the first 2 operands. |
| // It is guaranteed at this point that num_operands is an even number. |
| size_t num_pairs = (inst->operands().size() - 2) / 2; |
| const unsigned int num_pairs_limit = |
| _.options()->universal_limits_.max_switch_branches; |
| if (num_pairs > num_pairs_limit) { |
| return _.diag(SPV_ERROR_INVALID_BINARY, inst) |
| << "Number of (literal, label) pairs in OpSwitch (" << num_pairs |
| << ") exceeds the limit (" << num_pairs_limit << ")."; |
| } |
| } |
| return SPV_SUCCESS; |
| } |
| |
| // Ensure the number of variables of the given class does not exceed the |
| // limit. |
| spv_result_t LimitCheckNumVars(ValidationState_t& _, const uint32_t var_id, |
| const SpvStorageClass storage_class) { |
| if (SpvStorageClassFunction == storage_class) { |
| _.registerLocalVariable(var_id); |
| const uint32_t num_local_vars_limit = |
| _.options()->universal_limits_.max_local_variables; |
| if (_.num_local_vars() > num_local_vars_limit) { |
| return _.diag(SPV_ERROR_INVALID_BINARY, nullptr) |
| << "Number of local variables ('Function' Storage Class) " |
| "exceeded the valid limit (" |
| << num_local_vars_limit << ")."; |
| } |
| } else { |
| _.registerGlobalVariable(var_id); |
| const uint32_t num_global_vars_limit = |
| _.options()->universal_limits_.max_global_variables; |
| if (_.num_global_vars() > num_global_vars_limit) { |
| return _.diag(SPV_ERROR_INVALID_BINARY, nullptr) |
| << "Number of Global Variables (Storage Class other than " |
| "'Function') exceeded the valid limit (" |
| << num_global_vars_limit << ")."; |
| } |
| } |
| return SPV_SUCCESS; |
| } |
| |
| // Parses OpExtension instruction and logs warnings if unsuccessful. |
| spv_result_t CheckIfKnownExtension(ValidationState_t& _, |
| const Instruction* inst) { |
| const std::string extension_str = GetExtensionString(&(inst->c_inst())); |
| Extension extension; |
| if (!GetExtensionFromString(extension_str.c_str(), &extension)) { |
| return _.diag(SPV_WARNING, inst) |
| << "Found unrecognized extension " << extension_str; |
| } |
| return SPV_SUCCESS; |
| } |
| |
| } // namespace |
| |
| spv_result_t InstructionPass(ValidationState_t& _, const Instruction* inst) { |
| const SpvOp opcode = inst->opcode(); |
| if (opcode == SpvOpExtension) { |
| CheckIfKnownExtension(_, inst); |
| } else if (opcode == SpvOpCapability) { |
| _.RegisterCapability(inst->GetOperandAs<SpvCapability>(0)); |
| } else if (opcode == SpvOpMemoryModel) { |
| if (_.has_memory_model_specified()) { |
| return _.diag(SPV_ERROR_INVALID_LAYOUT, inst) |
| << "OpMemoryModel should only be provided once."; |
| } |
| _.set_addressing_model(inst->GetOperandAs<SpvAddressingModel>(0)); |
| _.set_memory_model(inst->GetOperandAs<SpvMemoryModel>(1)); |
| } else if (opcode == SpvOpExecutionMode) { |
| const uint32_t entry_point = inst->word(1); |
| _.RegisterExecutionModeForEntryPoint(entry_point, |
| SpvExecutionMode(inst->word(2))); |
| } else if (opcode == SpvOpVariable) { |
| const auto storage_class = inst->GetOperandAs<SpvStorageClass>(2); |
| if (auto error = LimitCheckNumVars(_, inst->id(), storage_class)) { |
| return error; |
| } |
| } else if (opcode == SpvOpSamplerImageAddressingModeNV) { |
| if (!_.HasCapability(SpvCapabilityBindlessTextureNV)) { |
| return _.diag(SPV_ERROR_MISSING_EXTENSION, inst) |
| << "OpSamplerImageAddressingModeNV supported only with extension " |
| "SPV_NV_bindless_texture"; |
| } |
| uint32_t bitwidth = inst->GetOperandAs<uint32_t>(0); |
| if (_.samplerimage_variable_address_mode() != 0) { |
| return _.diag(SPV_ERROR_INVALID_LAYOUT, inst) |
| << "OpSamplerImageAddressingModeNV should only be provided once"; |
| } |
| if (bitwidth != 32 && bitwidth != 64) { |
| return _.diag(SPV_ERROR_INVALID_DATA, inst) |
| << "OpSamplerImageAddressingModeNV bitwidth should be 64 or 32"; |
| } |
| _.set_samplerimage_variable_address_mode(bitwidth); |
| } |
| |
| if (auto error = ReservedCheck(_, inst)) return error; |
| if (auto error = CapabilityCheck(_, inst)) return error; |
| if (auto error = LimitCheckIdBound(_, inst)) return error; |
| if (auto error = LimitCheckStruct(_, inst)) return error; |
| if (auto error = LimitCheckSwitch(_, inst)) return error; |
| if (auto error = VersionCheck(_, inst)) return error; |
| |
| // All instruction checks have passed. |
| return SPV_SUCCESS; |
| } |
| |
| } // namespace val |
| } // namespace spvtools |
