SpirvShader: Move image handling to new cpp file
Bug: b/145336353
Change-Id: Ie988c583d2429dac65aaacadf7c89598cd5996c5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38816
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
diff --git a/src/Pipeline/BUILD.gn b/src/Pipeline/BUILD.gn
index 0422f97..3d117b5 100644
--- a/src/Pipeline/BUILD.gn
+++ b/src/Pipeline/BUILD.gn
@@ -43,6 +43,7 @@
"SpirvShaderControlFlow.cpp",
"SpirvShaderGLSLstd450.cpp",
"SpirvShaderGroup.cpp",
+ "SpirvShaderImage.cpp",
"SpirvShaderMemory.cpp",
"SpirvShaderSampling.cpp",
"SpirvShaderSpec.cpp",
diff --git a/src/Pipeline/SpirvShader.cpp b/src/Pipeline/SpirvShader.cpp
index f8fc6d0..eb83249 100644
--- a/src/Pipeline/SpirvShader.cpp
+++ b/src/Pipeline/SpirvShader.cpp
@@ -30,47 +30,6 @@
#include <queue>
-namespace
-{
- VkFormat SpirvFormatToVulkanFormat(spv::ImageFormat format)
- {
- switch (format)
- {
- case spv::ImageFormatRgba32f: return VK_FORMAT_R32G32B32A32_SFLOAT;
- case spv::ImageFormatRgba32i: return VK_FORMAT_R32G32B32A32_SINT;
- case spv::ImageFormatRgba32ui: return VK_FORMAT_R32G32B32A32_UINT;
- case spv::ImageFormatR32f: return VK_FORMAT_R32_SFLOAT;
- case spv::ImageFormatR32i: return VK_FORMAT_R32_SINT;
- case spv::ImageFormatR32ui: return VK_FORMAT_R32_UINT;
- case spv::ImageFormatRgba8: return VK_FORMAT_R8G8B8A8_UNORM;
- case spv::ImageFormatRgba8Snorm: return VK_FORMAT_R8G8B8A8_SNORM;
- case spv::ImageFormatRgba8i: return VK_FORMAT_R8G8B8A8_SINT;
- case spv::ImageFormatRgba8ui: return VK_FORMAT_R8G8B8A8_UINT;
- case spv::ImageFormatRgba16f: return VK_FORMAT_R16G16B16A16_SFLOAT;
- case spv::ImageFormatRgba16i: return VK_FORMAT_R16G16B16A16_SINT;
- case spv::ImageFormatRgba16ui: return VK_FORMAT_R16G16B16A16_UINT;
- case spv::ImageFormatRg32f: return VK_FORMAT_R32G32_SFLOAT;
- case spv::ImageFormatRg32i: return VK_FORMAT_R32G32_SINT;
- case spv::ImageFormatRg32ui: return VK_FORMAT_R32G32_UINT;
-
- default:
- UNIMPLEMENTED("SPIR-V ImageFormat %u", format);
- return VK_FORMAT_UNDEFINED;
- }
- }
-
- sw::SIMD::Float sRGBtoLinear(sw::SIMD::Float c)
- {
- sw::SIMD::Float lc = c * sw::SIMD::Float(1.0f / 12.92f);
- sw::SIMD::Float ec = sw::power((c + sw::SIMD::Float(0.055f)) * sw::SIMD::Float(1.0f / 1.055f), sw::SIMD::Float(2.4f));
-
- sw::SIMD::Int linear = CmpLT(c, sw::SIMD::Float(0.04045f));
-
- return rr::As<sw::SIMD::Float>((linear & rr::As<sw::SIMD::Int>(lc)) | (~linear & rr::As<sw::SIMD::Int>(ec))); // TODO: IfThenElse()
- }
-
-} // anonymous namespace
-
namespace sw
{
@@ -2710,949 +2669,6 @@
return EmitResult::Continue;
}
- SpirvShader::EmitResult SpirvShader::EmitImageSampleImplicitLod(Variant variant, InsnIterator insn, EmitState *state) const
- {
- return EmitImageSample({variant, Implicit}, insn, state);
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageGather(Variant variant, InsnIterator insn, EmitState *state) const
- {
- ImageInstruction instruction = {variant, Gather};
- instruction.gatherComponent = !instruction.isDref() ? getObject(insn.word(5)).constantValue[0] : 0;
-
- return EmitImageSample(instruction, insn, state);
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageSampleExplicitLod(Variant variant, InsnIterator insn, EmitState *state) const
- {
- auto isDref = (variant == Dref) || (variant == ProjDref);
- uint32_t imageOperands = static_cast<spv::ImageOperandsMask>(insn.word(isDref ? 6 : 5));
- imageOperands &= ~spv::ImageOperandsConstOffsetMask; // Dealt with later.
-
- if((imageOperands & spv::ImageOperandsLodMask) == imageOperands)
- {
- return EmitImageSample({variant, Lod}, insn, state);
- }
- else if((imageOperands & spv::ImageOperandsGradMask) == imageOperands)
- {
- return EmitImageSample({variant, Grad}, insn, state);
- }
- else UNIMPLEMENTED("Image Operands %x", imageOperands);
- return EmitResult::Continue;
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageFetch(InsnIterator insn, EmitState *state) const
- {
- return EmitImageSample({None, Fetch}, insn, state);
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageSample(ImageInstruction instruction, InsnIterator insn, EmitState *state) const
- {
- Type::ID resultTypeId = insn.word(1);
- Object::ID resultId = insn.word(2);
- Object::ID sampledImageId = insn.word(3); // For OpImageFetch this is just an Image, not a SampledImage.
- Object::ID coordinateId = insn.word(4);
- auto &resultType = getType(resultTypeId);
-
- auto &result = state->createIntermediate(resultId, resultType.sizeInComponents);
- auto imageDescriptor = state->getPointer(sampledImageId).base; // vk::SampledImageDescriptor*
-
- // If using a separate sampler, look through the OpSampledImage instruction to find the sampler descriptor
- auto &sampledImage = getObject(sampledImageId);
- auto samplerDescriptor = (sampledImage.opcode() == spv::OpSampledImage) ?
- state->getPointer(sampledImage.definition.word(4)).base : imageDescriptor;
-
- auto coordinate = GenericValue(this, state, coordinateId);
- auto &coordinateType = getType(coordinate.type);
-
- Pointer<Byte> sampler = samplerDescriptor + OFFSET(vk::SampledImageDescriptor, sampler); // vk::Sampler*
- Pointer<Byte> texture = imageDescriptor + OFFSET(vk::SampledImageDescriptor, texture); // sw::Texture*
-
- // Above we assumed that if the SampledImage operand is not the result of an OpSampledImage,
- // it must be a combined image sampler loaded straight from the descriptor set. For OpImageFetch
- // it's just an Image operand, so there's no sampler descriptor data.
- if(getType(sampledImage.type).opcode() != spv::OpTypeSampledImage)
- {
- sampler = Pointer<Byte>(nullptr);
- }
-
- uint32_t imageOperands = spv::ImageOperandsMaskNone;
- bool lodOrBias = false;
- Object::ID lodOrBiasId = 0;
- bool grad = false;
- Object::ID gradDxId = 0;
- Object::ID gradDyId = 0;
- bool constOffset = false;
- Object::ID offsetId = 0;
- bool sample = false;
- Object::ID sampleId = 0;
-
- uint32_t operand = (instruction.isDref() || instruction.samplerMethod == Gather) ? 6 : 5;
-
- if(insn.wordCount() > operand)
- {
- imageOperands = static_cast<spv::ImageOperandsMask>(insn.word(operand++));
-
- if(imageOperands & spv::ImageOperandsBiasMask)
- {
- lodOrBias = true;
- lodOrBiasId = insn.word(operand);
- operand++;
- imageOperands &= ~spv::ImageOperandsBiasMask;
-
- ASSERT(instruction.samplerMethod == Implicit);
- instruction.samplerMethod = Bias;
- }
-
- if(imageOperands & spv::ImageOperandsLodMask)
- {
- lodOrBias = true;
- lodOrBiasId = insn.word(operand);
- operand++;
- imageOperands &= ~spv::ImageOperandsLodMask;
- }
-
- if(imageOperands & spv::ImageOperandsGradMask)
- {
- ASSERT(!lodOrBias); // SPIR-V 1.3: "It is invalid to set both the Lod and Grad bits." Bias is for ImplicitLod, Grad for ExplicitLod.
- grad = true;
- gradDxId = insn.word(operand + 0);
- gradDyId = insn.word(operand + 1);
- operand += 2;
- imageOperands &= ~spv::ImageOperandsGradMask;
- }
-
- if(imageOperands & spv::ImageOperandsConstOffsetMask)
- {
- constOffset = true;
- offsetId = insn.word(operand);
- operand++;
- imageOperands &= ~spv::ImageOperandsConstOffsetMask;
- }
-
- if(imageOperands & spv::ImageOperandsSampleMask)
- {
- sample = true;
- sampleId = insn.word(operand);
- imageOperands &= ~spv::ImageOperandsSampleMask;
-
- ASSERT(instruction.samplerMethod == Fetch);
- instruction.sample = true;
- }
-
- if(imageOperands != 0)
- {
- UNSUPPORTED("Image operand %x", imageOperands);
- }
- }
-
- Array<SIMD::Float> in(16); // Maximum 16 input parameter components.
-
- uint32_t coordinates = coordinateType.sizeInComponents - instruction.isProj();
- instruction.coordinates = coordinates;
-
- uint32_t i = 0;
- for( ; i < coordinates; i++)
- {
- if(instruction.isProj())
- {
- in[i] = coordinate.Float(i) / coordinate.Float(coordinates); // TODO(b/129523279): Optimize using reciprocal.
- }
- else
- {
- in[i] = coordinate.Float(i);
- }
- }
-
- if(instruction.isDref())
- {
- auto drefValue = GenericValue(this, state, insn.word(5));
-
- if(instruction.isProj())
- {
- in[i] = drefValue.Float(0) / coordinate.Float(coordinates); // TODO(b/129523279): Optimize using reciprocal.
- }
- else
- {
- in[i] = drefValue.Float(0);
- }
-
- i++;
- }
-
- if(lodOrBias)
- {
- auto lodValue = GenericValue(this, state, lodOrBiasId);
- in[i] = lodValue.Float(0);
- i++;
- }
- else if(grad)
- {
- auto dxValue = GenericValue(this, state, gradDxId);
- auto dyValue = GenericValue(this, state, gradDyId);
- auto &dxyType = getType(dxValue.type);
- ASSERT(dxyType.sizeInComponents == getType(dyValue.type).sizeInComponents);
-
- instruction.grad = dxyType.sizeInComponents;
-
- for(uint32_t j = 0; j < dxyType.sizeInComponents; j++, i++)
- {
- in[i] = dxValue.Float(j);
- }
-
- for(uint32_t j = 0; j < dxyType.sizeInComponents; j++, i++)
- {
- in[i] = dyValue.Float(j);
- }
- }
- else if (instruction.samplerMethod == Fetch)
- {
- // The instruction didn't provide a lod operand, but the sampler's Fetch
- // function requires one to be present. If no lod is supplied, the default
- // is zero.
- in[i] = As<SIMD::Float>(SIMD::Int(0));
- i++;
- }
-
- if(constOffset)
- {
- auto offsetValue = GenericValue(this, state, offsetId);
- auto &offsetType = getType(offsetValue.type);
-
- instruction.offset = offsetType.sizeInComponents;
-
- for(uint32_t j = 0; j < offsetType.sizeInComponents; j++, i++)
- {
- in[i] = As<SIMD::Float>(offsetValue.Int(j)); // Integer values, but transfered as float.
- }
- }
-
- if(sample)
- {
- auto sampleValue = GenericValue(this, state, sampleId);
- in[i] = As<SIMD::Float>(sampleValue.Int(0));
- }
-
- auto cacheIt = state->routine->samplerCache.find(resultId);
- ASSERT(cacheIt != state->routine->samplerCache.end());
- auto &cache = cacheIt->second;
- auto cacheHit = cache.imageDescriptor == imageDescriptor && cache.sampler == sampler;
-
- If(!cacheHit)
- {
- cache.function = Call(getImageSampler, instruction.parameters, imageDescriptor, sampler);
- cache.imageDescriptor = imageDescriptor;
- cache.sampler = sampler;
- }
-
- Array<SIMD::Float> out(4);
- Call<ImageSampler>(cache.function, texture, sampler, &in[0], &out[0], state->routine->constants);
-
- for (auto i = 0u; i < resultType.sizeInComponents; i++) { result.move(i, out[i]); }
-
- return EmitResult::Continue;
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageQuerySizeLod(InsnIterator insn, EmitState *state) const
- {
- auto &resultTy = getType(Type::ID(insn.word(1)));
- auto resultId = Object::ID(insn.word(2));
- auto imageId = Object::ID(insn.word(3));
- auto lodId = Object::ID(insn.word(4));
-
- auto &dst = state->createIntermediate(resultId, resultTy.sizeInComponents);
- GetImageDimensions(state, resultTy, imageId, lodId, dst);
-
- return EmitResult::Continue;
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageQuerySize(InsnIterator insn, EmitState *state) const
- {
- auto &resultTy = getType(Type::ID(insn.word(1)));
- auto resultId = Object::ID(insn.word(2));
- auto imageId = Object::ID(insn.word(3));
- auto lodId = Object::ID(0);
-
- auto &dst = state->createIntermediate(resultId, resultTy.sizeInComponents);
- GetImageDimensions(state, resultTy, imageId, lodId, dst);
-
- return EmitResult::Continue;
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageQueryLod(InsnIterator insn, EmitState *state) const
- {
- return EmitImageSample({None, Query}, insn, state);
- }
-
- void SpirvShader::GetImageDimensions(EmitState const *state, Type const &resultTy, Object::ID imageId, Object::ID lodId, Intermediate &dst) const
- {
- auto routine = state->routine;
- auto &image = getObject(imageId);
- auto &imageType = getType(image.type);
-
- ASSERT(imageType.definition.opcode() == spv::OpTypeImage);
- bool isArrayed = imageType.definition.word(5) != 0;
- bool isCubeMap = imageType.definition.word(3) == spv::DimCube;
-
- const DescriptorDecorations &d = descriptorDecorations.at(imageId);
- auto setLayout = routine->pipelineLayout->getDescriptorSetLayout(d.DescriptorSet);
- auto &bindingLayout = setLayout->getBindingLayout(d.Binding);
-
- Pointer<Byte> descriptor = state->getPointer(imageId).base;
-
- Pointer<Int> extent;
- Int arrayLayers;
-
- switch (bindingLayout.descriptorType)
- {
- case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
- case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
- {
- extent = descriptor + OFFSET(vk::StorageImageDescriptor, extent); // int[3]*
- arrayLayers = *Pointer<Int>(descriptor + OFFSET(vk::StorageImageDescriptor, arrayLayers)); // uint32_t
- break;
- }
- case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
- case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
- case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
- {
- extent = descriptor + OFFSET(vk::SampledImageDescriptor, extent); // int[3]*
- arrayLayers = *Pointer<Int>(descriptor + OFFSET(vk::SampledImageDescriptor, arrayLayers)); // uint32_t
- break;
- }
- default:
- UNREACHABLE("Image descriptorType: %d", int(bindingLayout.descriptorType));
- }
-
- auto dimensions = resultTy.sizeInComponents - (isArrayed ? 1 : 0);
- std::vector<Int> out;
- if (lodId != 0)
- {
- auto lodVal = GenericValue(this, state, lodId);
- ASSERT(getType(lodVal.type).sizeInComponents == 1);
- auto lod = lodVal.Int(0);
- auto one = SIMD::Int(1);
- for (uint32_t i = 0; i < dimensions; i++)
- {
- dst.move(i, Max(SIMD::Int(extent[i]) >> lod, one));
- }
- }
- else
- {
- for (uint32_t i = 0; i < dimensions; i++)
- {
- dst.move(i, SIMD::Int(extent[i]));
- }
- }
-
- if (isArrayed)
- {
- auto numElements = isCubeMap ? (arrayLayers / 6) : RValue<Int>(arrayLayers);
- dst.move(dimensions, SIMD::Int(numElements));
- }
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageQueryLevels(InsnIterator insn, EmitState *state) const
- {
- auto &resultTy = getType(Type::ID(insn.word(1)));
- ASSERT(resultTy.sizeInComponents == 1);
- auto resultId = Object::ID(insn.word(2));
- auto imageId = Object::ID(insn.word(3));
-
- const DescriptorDecorations &d = descriptorDecorations.at(imageId);
- auto setLayout = state->routine->pipelineLayout->getDescriptorSetLayout(d.DescriptorSet);
- auto &bindingLayout = setLayout->getBindingLayout(d.Binding);
-
- Pointer<Byte> descriptor = state->getPointer(imageId).base;
- Int mipLevels = 0;
- switch (bindingLayout.descriptorType)
- {
- case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
- case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
- case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
- mipLevels = *Pointer<Int>(descriptor + OFFSET(vk::SampledImageDescriptor, mipLevels)); // uint32_t
- break;
- default:
- UNREACHABLE("Image descriptorType: %d", int(bindingLayout.descriptorType));
- }
-
- auto &dst = state->createIntermediate(resultId, 1);
- dst.move(0, SIMD::Int(mipLevels));
-
- return EmitResult::Continue;
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageQuerySamples(InsnIterator insn, EmitState *state) const
- {
- auto &resultTy = getType(Type::ID(insn.word(1)));
- ASSERT(resultTy.sizeInComponents == 1);
- auto resultId = Object::ID(insn.word(2));
- auto imageId = Object::ID(insn.word(3));
- auto imageTy = getType(getObject(imageId).type);
- ASSERT(imageTy.definition.opcode() == spv::OpTypeImage);
- ASSERT(imageTy.definition.word(3) == spv::Dim2D);
- ASSERT(imageTy.definition.word(6 /* MS */) == 1);
-
- const DescriptorDecorations &d = descriptorDecorations.at(imageId);
- auto setLayout = state->routine->pipelineLayout->getDescriptorSetLayout(d.DescriptorSet);
- auto &bindingLayout = setLayout->getBindingLayout(d.Binding);
-
- Pointer<Byte> descriptor = state->getPointer(imageId).base;
- Int sampleCount = 0;
- switch (bindingLayout.descriptorType)
- {
- case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
- sampleCount = *Pointer<Int>(descriptor + OFFSET(vk::StorageImageDescriptor, sampleCount)); // uint32_t
- break;
- case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
- case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
- case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
- sampleCount = *Pointer<Int>(descriptor + OFFSET(vk::SampledImageDescriptor, sampleCount)); // uint32_t
- break;
- default:
- UNREACHABLE("Image descriptorType: %d", int(bindingLayout.descriptorType));
- }
-
- auto &dst = state->createIntermediate(resultId, 1);
- dst.move(0, SIMD::Int(sampleCount));
-
- return EmitResult::Continue;
- }
-
- SIMD::Pointer SpirvShader::GetTexelAddress(EmitState const *state, SIMD::Pointer ptr, GenericValue const & coordinate, Type const & imageType, Pointer<Byte> descriptor, int texelSize, Object::ID sampleId, bool useStencilAspect) const
- {
- auto routine = state->routine;
- bool isArrayed = imageType.definition.word(5) != 0;
- auto dim = static_cast<spv::Dim>(imageType.definition.word(3));
- int dims = getType(coordinate.type).sizeInComponents - (isArrayed ? 1 : 0);
-
- SIMD::Int u = coordinate.Int(0);
- SIMD::Int v = SIMD::Int(0);
-
- if (getType(coordinate.type).sizeInComponents > 1)
- {
- v = coordinate.Int(1);
- }
-
- if (dim == spv::DimSubpassData)
- {
- u += routine->windowSpacePosition[0];
- v += routine->windowSpacePosition[1];
- }
-
- auto rowPitch = SIMD::Int(*Pointer<Int>(descriptor + (useStencilAspect
- ? OFFSET(vk::StorageImageDescriptor, stencilRowPitchBytes)
- : OFFSET(vk::StorageImageDescriptor, rowPitchBytes))));
- auto slicePitch = SIMD::Int(
- *Pointer<Int>(descriptor + (useStencilAspect
- ? OFFSET(vk::StorageImageDescriptor, stencilSlicePitchBytes)
- : OFFSET(vk::StorageImageDescriptor, slicePitchBytes))));
- auto samplePitch = SIMD::Int(
- *Pointer<Int>(descriptor + (useStencilAspect
- ? OFFSET(vk::StorageImageDescriptor, stencilSamplePitchBytes)
- : OFFSET(vk::StorageImageDescriptor, samplePitchBytes))));
-
- ptr += u * SIMD::Int(texelSize);
- if (dims > 1)
- {
- ptr += v * rowPitch;
- }
- if (dims > 2)
- {
- ptr += coordinate.Int(2) * slicePitch;
- }
- if (isArrayed)
- {
- ptr += coordinate.Int(dims) * slicePitch;
- }
-
- if (dim == spv::DimSubpassData)
- {
- // Multiview input attachment access is to the layer corresponding to the current view
- ptr += SIMD::Int(routine->viewID) * slicePitch;
- }
-
- if (sampleId.value())
- {
- GenericValue sample(this, state, sampleId);
- ptr += sample.Int(0) * samplePitch;
- }
-
- return ptr;
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageRead(InsnIterator insn, EmitState *state) const
- {
- auto &resultType = getType(Type::ID(insn.word(1)));
- auto imageId = Object::ID(insn.word(3));
- auto &image = getObject(imageId);
- auto &imageType = getType(image.type);
- Object::ID resultId = insn.word(2);
-
- Object::ID sampleId = 0;
-
- if (insn.wordCount() > 5)
- {
- int operand = 6;
- auto imageOperands = insn.word(5);
- if (imageOperands & spv::ImageOperandsSampleMask)
- {
- sampleId = insn.word(operand++);
- imageOperands &= ~spv::ImageOperandsSampleMask;
- }
-
- // Should be no remaining image operands.
- ASSERT(!imageOperands);
- }
-
- ASSERT(imageType.definition.opcode() == spv::OpTypeImage);
- auto dim = static_cast<spv::Dim>(imageType.definition.word(3));
-
- auto coordinate = GenericValue(this, state, insn.word(4));
- const DescriptorDecorations &d = descriptorDecorations.at(imageId);
-
- // For subpass data, format in the instruction is spv::ImageFormatUnknown. Get it from
- // the renderpass data instead. In all other cases, we can use the format in the instruction.
- auto vkFormat = (dim == spv::DimSubpassData)
- ? inputAttachmentFormats[d.InputAttachmentIndex]
- : SpirvFormatToVulkanFormat(static_cast<spv::ImageFormat>(imageType.definition.word(8)));
-
- // Depth+Stencil image attachments select aspect based on the Sampled Type of the
- // OpTypeImage. If float, then we want the depth aspect. If int, we want the stencil aspect.
- auto useStencilAspect = (vkFormat == VK_FORMAT_D32_SFLOAT_S8_UINT &&
- getType(imageType.definition.word(2)).opcode() == spv::OpTypeInt);
-
- if (useStencilAspect)
- {
- vkFormat = VK_FORMAT_S8_UINT;
- }
-
- auto pointer = state->getPointer(imageId);
- Pointer<Byte> binding = pointer.base;
- Pointer<Byte> imageBase = *Pointer<Pointer<Byte>>(binding + (useStencilAspect
- ? OFFSET(vk::StorageImageDescriptor, stencilPtr)
- : OFFSET(vk::StorageImageDescriptor, ptr)));
-
- auto imageSizeInBytes = *Pointer<Int>(binding + OFFSET(vk::StorageImageDescriptor, sizeInBytes));
-
- auto &dst = state->createIntermediate(resultId, resultType.sizeInComponents);
-
- auto texelSize = vk::Format(vkFormat).bytes();
- auto basePtr = SIMD::Pointer(imageBase, imageSizeInBytes);
- auto texelPtr = GetTexelAddress(state, basePtr, coordinate, imageType, binding, texelSize, sampleId, useStencilAspect);
-
- // "The value returned by a read of an invalid texel is undefined,
- // unless that read operation is from a buffer resource and the robustBufferAccess feature is enabled."
- // TODO: Don't always assume a buffer resource.
- auto robustness = OutOfBoundsBehavior::RobustBufferAccess;
-
- SIMD::Int packed[4];
- // Round up texel size: for formats smaller than 32 bits per texel, we will emit a bunch
- // of (overlapping) 32b loads here, and each lane will pick out what it needs from the low bits.
- // TODO: specialize for small formats?
- for (auto i = 0; i < (texelSize + 3)/4; i++)
- {
- packed[i] = texelPtr.Load<SIMD::Int>(robustness, state->activeLaneMask(), false, std::memory_order_relaxed, std::min(texelSize, 4));
- texelPtr += sizeof(float);
- }
-
- // Format support requirements here come from two sources:
- // - Minimum required set of formats for loads from storage images
- // - Any format supported as a color or depth/stencil attachment, for input attachments
- switch(vkFormat)
- {
- case VK_FORMAT_R32G32B32A32_SFLOAT:
- case VK_FORMAT_R32G32B32A32_SINT:
- case VK_FORMAT_R32G32B32A32_UINT:
- dst.move(0, packed[0]);
- dst.move(1, packed[1]);
- dst.move(2, packed[2]);
- dst.move(3, packed[3]);
- break;
- case VK_FORMAT_R32_SINT:
- case VK_FORMAT_R32_UINT:
- dst.move(0, packed[0]);
- // Fill remaining channels with 0,0,1 (of the correct type)
- dst.move(1, SIMD::Int(0));
- dst.move(2, SIMD::Int(0));
- dst.move(3, SIMD::Int(1));
- break;
- case VK_FORMAT_R32_SFLOAT:
- case VK_FORMAT_D32_SFLOAT:
- case VK_FORMAT_D32_SFLOAT_S8_UINT:
- dst.move(0, packed[0]);
- // Fill remaining channels with 0,0,1 (of the correct type)
- dst.move(1, SIMD::Float(0));
- dst.move(2, SIMD::Float(0));
- dst.move(3, SIMD::Float(1));
- break;
- case VK_FORMAT_D16_UNORM:
- dst.move(0, SIMD::Float(packed[0] & SIMD::Int(0xffff)) * SIMD::Float(1.0f / 65535.0f));
- dst.move(1, SIMD::Float(0));
- dst.move(2, SIMD::Float(0));
- dst.move(3, SIMD::Float(1));
- break;
- case VK_FORMAT_R16G16B16A16_SINT:
- dst.move(0, (packed[0] << 16) >> 16);
- dst.move(1, (packed[0]) >> 16);
- dst.move(2, (packed[1] << 16) >> 16);
- dst.move(3, (packed[1]) >> 16);
- break;
- case VK_FORMAT_R16G16B16A16_UINT:
- dst.move(0, packed[0] & SIMD::Int(0xffff));
- dst.move(1, (packed[0] >> 16) & SIMD::Int(0xffff));
- dst.move(2, packed[1] & SIMD::Int(0xffff));
- dst.move(3, (packed[1] >> 16) & SIMD::Int(0xffff));
- break;
- case VK_FORMAT_R16G16B16A16_SFLOAT:
- dst.move(0, halfToFloatBits(As<SIMD::UInt>(packed[0]) & SIMD::UInt(0x0000FFFF)));
- dst.move(1, halfToFloatBits((As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFFFF0000)) >> 16));
- dst.move(2, halfToFloatBits(As<SIMD::UInt>(packed[1]) & SIMD::UInt(0x0000FFFF)));
- dst.move(3, halfToFloatBits((As<SIMD::UInt>(packed[1]) & SIMD::UInt(0xFFFF0000)) >> 16));
- break;
- case VK_FORMAT_R8G8B8A8_SNORM:
- dst.move(0, Min(Max(SIMD::Float(((packed[0]<<24) & SIMD::Int(0xFF000000))) * SIMD::Float(1.0f / float(0x7f000000)), SIMD::Float(-1.0f)), SIMD::Float(1.0f)));
- dst.move(1, Min(Max(SIMD::Float(((packed[0]<<16) & SIMD::Int(0xFF000000))) * SIMD::Float(1.0f / float(0x7f000000)), SIMD::Float(-1.0f)), SIMD::Float(1.0f)));
- dst.move(2, Min(Max(SIMD::Float(((packed[0]<<8) & SIMD::Int(0xFF000000))) * SIMD::Float(1.0f / float(0x7f000000)), SIMD::Float(-1.0f)), SIMD::Float(1.0f)));
- dst.move(3, Min(Max(SIMD::Float(((packed[0]) & SIMD::Int(0xFF000000))) * SIMD::Float(1.0f / float(0x7f000000)), SIMD::Float(-1.0f)), SIMD::Float(1.0f)));
- break;
- case VK_FORMAT_R8G8B8A8_UNORM:
- case VK_FORMAT_A8B8G8R8_UNORM_PACK32:
- dst.move(0, SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- dst.move(1, SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- dst.move(2, SIMD::Float(((packed[0]>>16) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- dst.move(3, SIMD::Float(((packed[0]>>24) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- break;
- case VK_FORMAT_R8G8B8A8_SRGB:
- case VK_FORMAT_A8B8G8R8_SRGB_PACK32:
- dst.move(0, ::sRGBtoLinear(SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
- dst.move(1, ::sRGBtoLinear(SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
- dst.move(2, ::sRGBtoLinear(SIMD::Float(((packed[0]>>16) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
- dst.move(3, SIMD::Float(((packed[0]>>24) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- break;
- case VK_FORMAT_B8G8R8A8_UNORM:
- dst.move(0, SIMD::Float(((packed[0]>>16) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- dst.move(1, SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- dst.move(2, SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- dst.move(3, SIMD::Float(((packed[0]>>24) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- break;
- case VK_FORMAT_B8G8R8A8_SRGB:
- dst.move(0, ::sRGBtoLinear(SIMD::Float(((packed[0]>>16) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
- dst.move(1, ::sRGBtoLinear(SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
- dst.move(2, ::sRGBtoLinear(SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
- dst.move(3, SIMD::Float(((packed[0]>>24) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- break;
- case VK_FORMAT_R8G8B8A8_UINT:
- case VK_FORMAT_A8B8G8R8_UINT_PACK32:
- dst.move(0, (As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFF)));
- dst.move(1, ((As<SIMD::UInt>(packed[0])>>8) & SIMD::UInt(0xFF)));
- dst.move(2, ((As<SIMD::UInt>(packed[0])>>16) & SIMD::UInt(0xFF)));
- dst.move(3, ((As<SIMD::UInt>(packed[0])>>24) & SIMD::UInt(0xFF)));
- break;
- case VK_FORMAT_R8G8B8A8_SINT:
- case VK_FORMAT_A8B8G8R8_SINT_PACK32:
- dst.move(0, (packed[0] << 24) >> 24);
- dst.move(1, (packed[0] << 16) >> 24);
- dst.move(2, (packed[0] << 8) >> 24);
- dst.move(3, (packed[0]) >> 24);
- break;
- case VK_FORMAT_R8_UNORM:
- dst.move(0, SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- dst.move(1, SIMD::Float(0));
- dst.move(2, SIMD::Float(0));
- dst.move(3, SIMD::Float(1));
- break;
- case VK_FORMAT_R8_UINT:
- case VK_FORMAT_S8_UINT:
- dst.move(0, (As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFF)));
- dst.move(1, SIMD::UInt(0));
- dst.move(2, SIMD::UInt(0));
- dst.move(3, SIMD::UInt(1));
- break;
- case VK_FORMAT_R8_SINT:
- dst.move(0, (packed[0] << 24) >> 24);
- dst.move(1, SIMD::Int(0));
- dst.move(2, SIMD::Int(0));
- dst.move(3, SIMD::Int(1));
- break;
- case VK_FORMAT_R8G8_UNORM:
- dst.move(0, SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- dst.move(1, SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
- dst.move(2, SIMD::Float(0));
- dst.move(3, SIMD::Float(1));
- break;
- case VK_FORMAT_R8G8_UINT:
- dst.move(0, (As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFF)));
- dst.move(1, ((As<SIMD::UInt>(packed[0])>>8) & SIMD::UInt(0xFF)));
- dst.move(2, SIMD::UInt(0));
- dst.move(3, SIMD::UInt(1));
- break;
- case VK_FORMAT_R8G8_SINT:
- dst.move(0, (packed[0] << 24) >> 24);
- dst.move(1, (packed[0] << 16) >> 24);
- dst.move(2, SIMD::Int(0));
- dst.move(3, SIMD::Int(1));
- break;
- case VK_FORMAT_R16_SFLOAT:
- dst.move(0, halfToFloatBits(As<SIMD::UInt>(packed[0]) & SIMD::UInt(0x0000FFFF)));
- dst.move(1, SIMD::Float(0));
- dst.move(2, SIMD::Float(0));
- dst.move(3, SIMD::Float(1));
- break;
- case VK_FORMAT_R16_UINT:
- dst.move(0, packed[0] & SIMD::Int(0xffff));
- dst.move(1, SIMD::UInt(0));
- dst.move(2, SIMD::UInt(0));
- dst.move(3, SIMD::UInt(1));
- break;
- case VK_FORMAT_R16_SINT:
- dst.move(0, (packed[0] << 16) >> 16);
- dst.move(1, SIMD::Int(0));
- dst.move(2, SIMD::Int(0));
- dst.move(3, SIMD::Int(1));
- break;
- case VK_FORMAT_R16G16_SFLOAT:
- dst.move(0, halfToFloatBits(As<SIMD::UInt>(packed[0]) & SIMD::UInt(0x0000FFFF)));
- dst.move(1, halfToFloatBits((As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFFFF0000)) >> 16));
- dst.move(2, SIMD::Float(0));
- dst.move(3, SIMD::Float(1));
- break;
- case VK_FORMAT_R16G16_UINT:
- dst.move(0, packed[0] & SIMD::Int(0xffff));
- dst.move(1, (packed[0] >> 16) & SIMD::Int(0xffff));
- dst.move(2, SIMD::UInt(0));
- dst.move(3, SIMD::UInt(1));
- break;
- case VK_FORMAT_R16G16_SINT:
- dst.move(0, (packed[0] << 16) >> 16);
- dst.move(1, (packed[0]) >> 16);
- dst.move(2, SIMD::Int(0));
- dst.move(3, SIMD::Int(1));
- break;
- case VK_FORMAT_R32G32_SINT:
- case VK_FORMAT_R32G32_UINT:
- dst.move(0, packed[0]);
- dst.move(1, packed[1]);
- dst.move(2, SIMD::Int(0));
- dst.move(3, SIMD::Int(1));
- break;
- case VK_FORMAT_R32G32_SFLOAT:
- dst.move(0, packed[0]);
- dst.move(1, packed[1]);
- dst.move(2, SIMD::Float(0));
- dst.move(3, SIMD::Float(1));
- break;
- case VK_FORMAT_A2B10G10R10_UINT_PACK32:
- dst.move(0, (packed[0]) & SIMD::Int(0x3FF));
- dst.move(1, (packed[0] >> 10) & SIMD::Int(0x3FF));
- dst.move(2, (packed[0] >> 20) & SIMD::Int(0x3FF));
- dst.move(3, (packed[0] >> 30) & SIMD::Int(0x3));
- break;
- case VK_FORMAT_A2B10G10R10_UNORM_PACK32:
- dst.move(0, SIMD::Float((packed[0]) & SIMD::Int(0x3FF)) * SIMD::Float(1.0f / 0x3FF));
- dst.move(1, SIMD::Float((packed[0] >> 10) & SIMD::Int(0x3FF)) * SIMD::Float(1.0f / 0x3FF));
- dst.move(2, SIMD::Float((packed[0] >> 20) & SIMD::Int(0x3FF)) * SIMD::Float(1.0f / 0x3FF));
- dst.move(3, SIMD::Float((packed[0] >> 30) & SIMD::Int(0x3)) * SIMD::Float(1.0f / 0x3));
- break;
- case VK_FORMAT_R5G6B5_UNORM_PACK16:
- dst.move(0, SIMD::Float((packed[0] >> 11) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
- dst.move(1, SIMD::Float((packed[0] >> 5) & SIMD::Int(0x3F)) * SIMD::Float(1.0f / 0x3F));
- dst.move(2, SIMD::Float((packed[0]) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
- dst.move(3, SIMD::Float(1));
- break;
- case VK_FORMAT_A1R5G5B5_UNORM_PACK16:
- dst.move(0, SIMD::Float((packed[0] >> 10) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
- dst.move(1, SIMD::Float((packed[0] >> 5) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
- dst.move(2, SIMD::Float((packed[0]) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
- dst.move(3, SIMD::Float((packed[0] >> 15) & SIMD::Int(0x1)));
- break;
- default:
- UNIMPLEMENTED("VkFormat %d", int(vkFormat));
- break;
- }
-
- return EmitResult::Continue;
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageWrite(InsnIterator insn, EmitState *state) const
- {
- auto imageId = Object::ID(insn.word(1));
- auto &image = getObject(imageId);
- auto &imageType = getType(image.type);
-
- ASSERT(imageType.definition.opcode() == spv::OpTypeImage);
-
- // TODO(b/131171141): Not handling any image operands yet.
- ASSERT(insn.wordCount() == 4);
-
- auto coordinate = GenericValue(this, state, insn.word(2));
- auto texel = GenericValue(this, state, insn.word(3));
-
- Pointer<Byte> binding = state->getPointer(imageId).base;
- Pointer<Byte> imageBase = *Pointer<Pointer<Byte>>(binding + OFFSET(vk::StorageImageDescriptor, ptr));
- auto imageSizeInBytes = *Pointer<Int>(binding + OFFSET(vk::StorageImageDescriptor, sizeInBytes));
-
- SIMD::Int packed[4];
- auto numPackedElements = 0u;
- int texelSize = 0;
- auto format = static_cast<spv::ImageFormat>(imageType.definition.word(8));
- switch (format)
- {
- case spv::ImageFormatRgba32f:
- case spv::ImageFormatRgba32i:
- case spv::ImageFormatRgba32ui:
- texelSize = 16;
- packed[0] = texel.Int(0);
- packed[1] = texel.Int(1);
- packed[2] = texel.Int(2);
- packed[3] = texel.Int(3);
- numPackedElements = 4;
- break;
- case spv::ImageFormatR32f:
- case spv::ImageFormatR32i:
- case spv::ImageFormatR32ui:
- texelSize = 4;
- packed[0] = texel.Int(0);
- numPackedElements = 1;
- break;
- case spv::ImageFormatRgba8:
- texelSize = 4;
- packed[0] = (SIMD::UInt(Round(Min(Max(texel.Float(0), SIMD::Float(0.0f)), SIMD::Float(1.0f)) * SIMD::Float(255.0f)))) |
- ((SIMD::UInt(Round(Min(Max(texel.Float(1), SIMD::Float(0.0f)), SIMD::Float(1.0f)) * SIMD::Float(255.0f)))) << 8) |
- ((SIMD::UInt(Round(Min(Max(texel.Float(2), SIMD::Float(0.0f)), SIMD::Float(1.0f)) * SIMD::Float(255.0f)))) << 16) |
- ((SIMD::UInt(Round(Min(Max(texel.Float(3), SIMD::Float(0.0f)), SIMD::Float(1.0f)) * SIMD::Float(255.0f)))) << 24);
- numPackedElements = 1;
- break;
- case spv::ImageFormatRgba8Snorm:
- texelSize = 4;
- packed[0] = (SIMD::Int(Round(Min(Max(texel.Float(0), SIMD::Float(-1.0f)), SIMD::Float(1.0f)) * SIMD::Float(127.0f))) &
- SIMD::Int(0xFF)) |
- ((SIMD::Int(Round(Min(Max(texel.Float(1), SIMD::Float(-1.0f)), SIMD::Float(1.0f)) * SIMD::Float(127.0f))) &
- SIMD::Int(0xFF)) << 8) |
- ((SIMD::Int(Round(Min(Max(texel.Float(2), SIMD::Float(-1.0f)), SIMD::Float(1.0f)) * SIMD::Float(127.0f))) &
- SIMD::Int(0xFF)) << 16) |
- ((SIMD::Int(Round(Min(Max(texel.Float(3), SIMD::Float(-1.0f)), SIMD::Float(1.0f)) * SIMD::Float(127.0f))) &
- SIMD::Int(0xFF)) << 24);
- numPackedElements = 1;
- break;
- case spv::ImageFormatRgba8i:
- case spv::ImageFormatRgba8ui:
- texelSize = 4;
- packed[0] = (SIMD::UInt(texel.UInt(0) & SIMD::UInt(0xff))) |
- (SIMD::UInt(texel.UInt(1) & SIMD::UInt(0xff)) << 8) |
- (SIMD::UInt(texel.UInt(2) & SIMD::UInt(0xff)) << 16) |
- (SIMD::UInt(texel.UInt(3) & SIMD::UInt(0xff)) << 24);
- numPackedElements = 1;
- break;
- case spv::ImageFormatRgba16f:
- texelSize = 8;
- packed[0] = FloatToHalfBits(texel.UInt(0), false) | FloatToHalfBits(texel.UInt(1), true);
- packed[1] = FloatToHalfBits(texel.UInt(2), false) | FloatToHalfBits(texel.UInt(3), true);
- numPackedElements = 2;
- break;
- case spv::ImageFormatRgba16i:
- case spv::ImageFormatRgba16ui:
- texelSize = 8;
- packed[0] = SIMD::UInt(texel.UInt(0) & SIMD::UInt(0xffff)) | (SIMD::UInt(texel.UInt(1) & SIMD::UInt(0xffff)) << 16);
- packed[1] = SIMD::UInt(texel.UInt(2) & SIMD::UInt(0xffff)) | (SIMD::UInt(texel.UInt(3) & SIMD::UInt(0xffff)) << 16);
- numPackedElements = 2;
- break;
- case spv::ImageFormatRg32f:
- case spv::ImageFormatRg32i:
- case spv::ImageFormatRg32ui:
- texelSize = 8;
- packed[0] = texel.Int(0);
- packed[1] = texel.Int(1);
- numPackedElements = 2;
- break;
-
- case spv::ImageFormatRg16f:
- case spv::ImageFormatR11fG11fB10f:
- case spv::ImageFormatR16f:
- case spv::ImageFormatRgba16:
- case spv::ImageFormatRgb10A2:
- case spv::ImageFormatRg16:
- case spv::ImageFormatRg8:
- case spv::ImageFormatR16:
- case spv::ImageFormatR8:
- case spv::ImageFormatRgba16Snorm:
- case spv::ImageFormatRg16Snorm:
- case spv::ImageFormatRg8Snorm:
- case spv::ImageFormatR16Snorm:
- case spv::ImageFormatR8Snorm:
- case spv::ImageFormatRg16i:
- case spv::ImageFormatRg8i:
- case spv::ImageFormatR16i:
- case spv::ImageFormatR8i:
- case spv::ImageFormatRgb10a2ui:
- case spv::ImageFormatRg16ui:
- case spv::ImageFormatRg8ui:
- case spv::ImageFormatR16ui:
- case spv::ImageFormatR8ui:
- UNIMPLEMENTED("spv::ImageFormat %d", int(format));
- break;
-
- default:
- UNREACHABLE("spv::ImageFormat %d", int(format));
- break;
- }
-
- auto basePtr = SIMD::Pointer(imageBase, imageSizeInBytes);
- auto texelPtr = GetTexelAddress(state, basePtr, coordinate, imageType, binding, texelSize, 0, false);
-
- // SPIR-V 1.4: "If the coordinates are outside the image, the memory location that is accessed is undefined."
- auto robustness = OutOfBoundsBehavior::UndefinedValue;
-
- for (auto i = 0u; i < numPackedElements; i++)
- {
- texelPtr.Store(packed[i], robustness, state->activeLaneMask());
- texelPtr += sizeof(float);
- }
-
- return EmitResult::Continue;
- }
-
- SpirvShader::EmitResult SpirvShader::EmitImageTexelPointer(InsnIterator insn, EmitState *state) const
- {
- auto &resultType = getType(Type::ID(insn.word(1)));
- auto imageId = Object::ID(insn.word(3));
- auto &image = getObject(imageId);
- // Note: OpImageTexelPointer is unusual in that the image is passed by pointer.
- // Look through to get the actual image type.
- auto &imageType = getType(getType(image.type).element);
- Object::ID resultId = insn.word(2);
-
- ASSERT(imageType.opcode() == spv::OpTypeImage);
- ASSERT(resultType.storageClass == spv::StorageClassImage);
- ASSERT(getType(resultType.element).opcode() == spv::OpTypeInt);
-
- auto coordinate = GenericValue(this, state, insn.word(4));
-
- Pointer<Byte> binding = state->getPointer(imageId).base;
- Pointer<Byte> imageBase = *Pointer<Pointer<Byte>>(binding + OFFSET(vk::StorageImageDescriptor, ptr));
- auto imageSizeInBytes = *Pointer<Int>(binding + OFFSET(vk::StorageImageDescriptor, sizeInBytes));
-
- auto basePtr = SIMD::Pointer(imageBase, imageSizeInBytes);
- auto ptr = GetTexelAddress(state, basePtr, coordinate, imageType, binding, sizeof(uint32_t), 0, false);
-
- state->createPointer(resultId, ptr);
-
- return EmitResult::Continue;
- }
-
- SpirvShader::EmitResult SpirvShader::EmitSampledImageCombineOrSplit(InsnIterator insn, EmitState *state) const
- {
- // Propagate the image pointer in both cases.
- // Consumers of OpSampledImage will look through to find the sampler pointer.
-
- Object::ID resultId = insn.word(2);
- Object::ID imageId = insn.word(3);
-
- state->createPointer(resultId, state->getPointer(imageId));
-
- return EmitResult::Continue;
- }
-
SpirvShader::EmitResult SpirvShader::EmitAtomicOp(InsnIterator insn, EmitState *state) const
{
auto &resultType = getType(Type::ID(insn.word(1)));
diff --git a/src/Pipeline/SpirvShaderImage.cpp b/src/Pipeline/SpirvShaderImage.cpp
new file mode 100644
index 0000000..51903af
--- /dev/null
+++ b/src/Pipeline/SpirvShaderImage.cpp
@@ -0,0 +1,1011 @@
+// Copyright 2019 The SwiftShader Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "SpirvShader.hpp"
+
+#include "System/Types.hpp"
+
+#include "Vulkan/VkDescriptorSetLayout.hpp"
+#include "Vulkan/VkPipelineLayout.hpp"
+
+#include <spirv/unified1/spirv.hpp>
+#include <spirv/unified1/GLSL.std.450.h>
+
+namespace {
+
+VkFormat SpirvFormatToVulkanFormat(spv::ImageFormat format)
+{
+ switch (format)
+ {
+ case spv::ImageFormatRgba32f: return VK_FORMAT_R32G32B32A32_SFLOAT;
+ case spv::ImageFormatRgba32i: return VK_FORMAT_R32G32B32A32_SINT;
+ case spv::ImageFormatRgba32ui: return VK_FORMAT_R32G32B32A32_UINT;
+ case spv::ImageFormatR32f: return VK_FORMAT_R32_SFLOAT;
+ case spv::ImageFormatR32i: return VK_FORMAT_R32_SINT;
+ case spv::ImageFormatR32ui: return VK_FORMAT_R32_UINT;
+ case spv::ImageFormatRgba8: return VK_FORMAT_R8G8B8A8_UNORM;
+ case spv::ImageFormatRgba8Snorm: return VK_FORMAT_R8G8B8A8_SNORM;
+ case spv::ImageFormatRgba8i: return VK_FORMAT_R8G8B8A8_SINT;
+ case spv::ImageFormatRgba8ui: return VK_FORMAT_R8G8B8A8_UINT;
+ case spv::ImageFormatRgba16f: return VK_FORMAT_R16G16B16A16_SFLOAT;
+ case spv::ImageFormatRgba16i: return VK_FORMAT_R16G16B16A16_SINT;
+ case spv::ImageFormatRgba16ui: return VK_FORMAT_R16G16B16A16_UINT;
+ case spv::ImageFormatRg32f: return VK_FORMAT_R32G32_SFLOAT;
+ case spv::ImageFormatRg32i: return VK_FORMAT_R32G32_SINT;
+ case spv::ImageFormatRg32ui: return VK_FORMAT_R32G32_UINT;
+
+ default:
+ UNIMPLEMENTED("SPIR-V ImageFormat %u", format);
+ return VK_FORMAT_UNDEFINED;
+ }
+}
+
+sw::SIMD::Float sRGBtoLinear(sw::SIMD::Float c)
+{
+ sw::SIMD::Float lc = c * sw::SIMD::Float(1.0f / 12.92f);
+ sw::SIMD::Float ec = sw::power((c + sw::SIMD::Float(0.055f)) * sw::SIMD::Float(1.0f / 1.055f), sw::SIMD::Float(2.4f));
+
+ sw::SIMD::Int linear = CmpLT(c, sw::SIMD::Float(0.04045f));
+
+ return rr::As<sw::SIMD::Float>((linear & rr::As<sw::SIMD::Int>(lc)) | (~linear & rr::As<sw::SIMD::Int>(ec))); // TODO: IfThenElse()
+}
+
+} // anonymous namespace
+
+namespace sw {
+
+SpirvShader::EmitResult SpirvShader::EmitImageSampleImplicitLod(Variant variant, InsnIterator insn, EmitState *state) const
+{
+ return EmitImageSample({variant, Implicit}, insn, state);
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageGather(Variant variant, InsnIterator insn, EmitState *state) const
+{
+ ImageInstruction instruction = {variant, Gather};
+ instruction.gatherComponent = !instruction.isDref() ? getObject(insn.word(5)).constantValue[0] : 0;
+
+ return EmitImageSample(instruction, insn, state);
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageSampleExplicitLod(Variant variant, InsnIterator insn, EmitState *state) const
+{
+ auto isDref = (variant == Dref) || (variant == ProjDref);
+ uint32_t imageOperands = static_cast<spv::ImageOperandsMask>(insn.word(isDref ? 6 : 5));
+ imageOperands &= ~spv::ImageOperandsConstOffsetMask; // Dealt with later.
+
+ if((imageOperands & spv::ImageOperandsLodMask) == imageOperands)
+ {
+ return EmitImageSample({variant, Lod}, insn, state);
+ }
+ else if((imageOperands & spv::ImageOperandsGradMask) == imageOperands)
+ {
+ return EmitImageSample({variant, Grad}, insn, state);
+ }
+ else UNIMPLEMENTED("Image Operands %x", imageOperands);
+ return EmitResult::Continue;
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageFetch(InsnIterator insn, EmitState *state) const
+{
+ return EmitImageSample({None, Fetch}, insn, state);
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageSample(ImageInstruction instruction, InsnIterator insn, EmitState *state) const
+{
+ Type::ID resultTypeId = insn.word(1);
+ Object::ID resultId = insn.word(2);
+ Object::ID sampledImageId = insn.word(3); // For OpImageFetch this is just an Image, not a SampledImage.
+ Object::ID coordinateId = insn.word(4);
+ auto &resultType = getType(resultTypeId);
+
+ auto &result = state->createIntermediate(resultId, resultType.sizeInComponents);
+ auto imageDescriptor = state->getPointer(sampledImageId).base; // vk::SampledImageDescriptor*
+
+ // If using a separate sampler, look through the OpSampledImage instruction to find the sampler descriptor
+ auto &sampledImage = getObject(sampledImageId);
+ auto samplerDescriptor = (sampledImage.opcode() == spv::OpSampledImage) ?
+ state->getPointer(sampledImage.definition.word(4)).base : imageDescriptor;
+
+ auto coordinate = GenericValue(this, state, coordinateId);
+ auto &coordinateType = getType(coordinate.type);
+
+ Pointer<Byte> sampler = samplerDescriptor + OFFSET(vk::SampledImageDescriptor, sampler); // vk::Sampler*
+ Pointer<Byte> texture = imageDescriptor + OFFSET(vk::SampledImageDescriptor, texture); // sw::Texture*
+
+ // Above we assumed that if the SampledImage operand is not the result of an OpSampledImage,
+ // it must be a combined image sampler loaded straight from the descriptor set. For OpImageFetch
+ // it's just an Image operand, so there's no sampler descriptor data.
+ if(getType(sampledImage.type).opcode() != spv::OpTypeSampledImage)
+ {
+ sampler = Pointer<Byte>(nullptr);
+ }
+
+ uint32_t imageOperands = spv::ImageOperandsMaskNone;
+ bool lodOrBias = false;
+ Object::ID lodOrBiasId = 0;
+ bool grad = false;
+ Object::ID gradDxId = 0;
+ Object::ID gradDyId = 0;
+ bool constOffset = false;
+ Object::ID offsetId = 0;
+ bool sample = false;
+ Object::ID sampleId = 0;
+
+ uint32_t operand = (instruction.isDref() || instruction.samplerMethod == Gather) ? 6 : 5;
+
+ if(insn.wordCount() > operand)
+ {
+ imageOperands = static_cast<spv::ImageOperandsMask>(insn.word(operand++));
+
+ if(imageOperands & spv::ImageOperandsBiasMask)
+ {
+ lodOrBias = true;
+ lodOrBiasId = insn.word(operand);
+ operand++;
+ imageOperands &= ~spv::ImageOperandsBiasMask;
+
+ ASSERT(instruction.samplerMethod == Implicit);
+ instruction.samplerMethod = Bias;
+ }
+
+ if(imageOperands & spv::ImageOperandsLodMask)
+ {
+ lodOrBias = true;
+ lodOrBiasId = insn.word(operand);
+ operand++;
+ imageOperands &= ~spv::ImageOperandsLodMask;
+ }
+
+ if(imageOperands & spv::ImageOperandsGradMask)
+ {
+ ASSERT(!lodOrBias); // SPIR-V 1.3: "It is invalid to set both the Lod and Grad bits." Bias is for ImplicitLod, Grad for ExplicitLod.
+ grad = true;
+ gradDxId = insn.word(operand + 0);
+ gradDyId = insn.word(operand + 1);
+ operand += 2;
+ imageOperands &= ~spv::ImageOperandsGradMask;
+ }
+
+ if(imageOperands & spv::ImageOperandsConstOffsetMask)
+ {
+ constOffset = true;
+ offsetId = insn.word(operand);
+ operand++;
+ imageOperands &= ~spv::ImageOperandsConstOffsetMask;
+ }
+
+ if(imageOperands & spv::ImageOperandsSampleMask)
+ {
+ sample = true;
+ sampleId = insn.word(operand);
+ imageOperands &= ~spv::ImageOperandsSampleMask;
+
+ ASSERT(instruction.samplerMethod == Fetch);
+ instruction.sample = true;
+ }
+
+ if(imageOperands != 0)
+ {
+ UNSUPPORTED("Image operand %x", imageOperands);
+ }
+ }
+
+ Array<SIMD::Float> in(16); // Maximum 16 input parameter components.
+
+ uint32_t coordinates = coordinateType.sizeInComponents - instruction.isProj();
+ instruction.coordinates = coordinates;
+
+ uint32_t i = 0;
+ for( ; i < coordinates; i++)
+ {
+ if(instruction.isProj())
+ {
+ in[i] = coordinate.Float(i) / coordinate.Float(coordinates); // TODO(b/129523279): Optimize using reciprocal.
+ }
+ else
+ {
+ in[i] = coordinate.Float(i);
+ }
+ }
+
+ if(instruction.isDref())
+ {
+ auto drefValue = GenericValue(this, state, insn.word(5));
+
+ if(instruction.isProj())
+ {
+ in[i] = drefValue.Float(0) / coordinate.Float(coordinates); // TODO(b/129523279): Optimize using reciprocal.
+ }
+ else
+ {
+ in[i] = drefValue.Float(0);
+ }
+
+ i++;
+ }
+
+ if(lodOrBias)
+ {
+ auto lodValue = GenericValue(this, state, lodOrBiasId);
+ in[i] = lodValue.Float(0);
+ i++;
+ }
+ else if(grad)
+ {
+ auto dxValue = GenericValue(this, state, gradDxId);
+ auto dyValue = GenericValue(this, state, gradDyId);
+ auto &dxyType = getType(dxValue.type);
+ ASSERT(dxyType.sizeInComponents == getType(dyValue.type).sizeInComponents);
+
+ instruction.grad = dxyType.sizeInComponents;
+
+ for(uint32_t j = 0; j < dxyType.sizeInComponents; j++, i++)
+ {
+ in[i] = dxValue.Float(j);
+ }
+
+ for(uint32_t j = 0; j < dxyType.sizeInComponents; j++, i++)
+ {
+ in[i] = dyValue.Float(j);
+ }
+ }
+ else if (instruction.samplerMethod == Fetch)
+ {
+ // The instruction didn't provide a lod operand, but the sampler's Fetch
+ // function requires one to be present. If no lod is supplied, the default
+ // is zero.
+ in[i] = As<SIMD::Float>(SIMD::Int(0));
+ i++;
+ }
+
+ if(constOffset)
+ {
+ auto offsetValue = GenericValue(this, state, offsetId);
+ auto &offsetType = getType(offsetValue.type);
+
+ instruction.offset = offsetType.sizeInComponents;
+
+ for(uint32_t j = 0; j < offsetType.sizeInComponents; j++, i++)
+ {
+ in[i] = As<SIMD::Float>(offsetValue.Int(j)); // Integer values, but transfered as float.
+ }
+ }
+
+ if(sample)
+ {
+ auto sampleValue = GenericValue(this, state, sampleId);
+ in[i] = As<SIMD::Float>(sampleValue.Int(0));
+ }
+
+ auto cacheIt = state->routine->samplerCache.find(resultId);
+ ASSERT(cacheIt != state->routine->samplerCache.end());
+ auto &cache = cacheIt->second;
+ auto cacheHit = cache.imageDescriptor == imageDescriptor && cache.sampler == sampler;
+
+ If(!cacheHit)
+ {
+ cache.function = Call(getImageSampler, instruction.parameters, imageDescriptor, sampler);
+ cache.imageDescriptor = imageDescriptor;
+ cache.sampler = sampler;
+ }
+
+ Array<SIMD::Float> out(4);
+ Call<ImageSampler>(cache.function, texture, sampler, &in[0], &out[0], state->routine->constants);
+
+ for (auto i = 0u; i < resultType.sizeInComponents; i++) { result.move(i, out[i]); }
+
+ return EmitResult::Continue;
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageQuerySizeLod(InsnIterator insn, EmitState *state) const
+{
+ auto &resultTy = getType(Type::ID(insn.word(1)));
+ auto resultId = Object::ID(insn.word(2));
+ auto imageId = Object::ID(insn.word(3));
+ auto lodId = Object::ID(insn.word(4));
+
+ auto &dst = state->createIntermediate(resultId, resultTy.sizeInComponents);
+ GetImageDimensions(state, resultTy, imageId, lodId, dst);
+
+ return EmitResult::Continue;
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageQuerySize(InsnIterator insn, EmitState *state) const
+{
+ auto &resultTy = getType(Type::ID(insn.word(1)));
+ auto resultId = Object::ID(insn.word(2));
+ auto imageId = Object::ID(insn.word(3));
+ auto lodId = Object::ID(0);
+
+ auto &dst = state->createIntermediate(resultId, resultTy.sizeInComponents);
+ GetImageDimensions(state, resultTy, imageId, lodId, dst);
+
+ return EmitResult::Continue;
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageQueryLod(InsnIterator insn, EmitState *state) const
+{
+ return EmitImageSample({None, Query}, insn, state);
+}
+
+void SpirvShader::GetImageDimensions(EmitState const *state, Type const &resultTy, Object::ID imageId, Object::ID lodId, Intermediate &dst) const
+{
+ auto routine = state->routine;
+ auto &image = getObject(imageId);
+ auto &imageType = getType(image.type);
+
+ ASSERT(imageType.definition.opcode() == spv::OpTypeImage);
+ bool isArrayed = imageType.definition.word(5) != 0;
+ bool isCubeMap = imageType.definition.word(3) == spv::DimCube;
+
+ const DescriptorDecorations &d = descriptorDecorations.at(imageId);
+ auto setLayout = routine->pipelineLayout->getDescriptorSetLayout(d.DescriptorSet);
+ auto &bindingLayout = setLayout->getBindingLayout(d.Binding);
+
+ Pointer<Byte> descriptor = state->getPointer(imageId).base;
+
+ Pointer<Int> extent;
+ Int arrayLayers;
+
+ switch (bindingLayout.descriptorType)
+ {
+ case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
+ case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
+ {
+ extent = descriptor + OFFSET(vk::StorageImageDescriptor, extent); // int[3]*
+ arrayLayers = *Pointer<Int>(descriptor + OFFSET(vk::StorageImageDescriptor, arrayLayers)); // uint32_t
+ break;
+ }
+ case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
+ case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
+ case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
+ {
+ extent = descriptor + OFFSET(vk::SampledImageDescriptor, extent); // int[3]*
+ arrayLayers = *Pointer<Int>(descriptor + OFFSET(vk::SampledImageDescriptor, arrayLayers)); // uint32_t
+ break;
+ }
+ default:
+ UNREACHABLE("Image descriptorType: %d", int(bindingLayout.descriptorType));
+ }
+
+ auto dimensions = resultTy.sizeInComponents - (isArrayed ? 1 : 0);
+ std::vector<Int> out;
+ if (lodId != 0)
+ {
+ auto lodVal = GenericValue(this, state, lodId);
+ ASSERT(getType(lodVal.type).sizeInComponents == 1);
+ auto lod = lodVal.Int(0);
+ auto one = SIMD::Int(1);
+ for (uint32_t i = 0; i < dimensions; i++)
+ {
+ dst.move(i, Max(SIMD::Int(extent[i]) >> lod, one));
+ }
+ }
+ else
+ {
+ for (uint32_t i = 0; i < dimensions; i++)
+ {
+ dst.move(i, SIMD::Int(extent[i]));
+ }
+ }
+
+ if (isArrayed)
+ {
+ auto numElements = isCubeMap ? (arrayLayers / 6) : RValue<Int>(arrayLayers);
+ dst.move(dimensions, SIMD::Int(numElements));
+ }
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageQueryLevels(InsnIterator insn, EmitState *state) const
+{
+ auto &resultTy = getType(Type::ID(insn.word(1)));
+ ASSERT(resultTy.sizeInComponents == 1);
+ auto resultId = Object::ID(insn.word(2));
+ auto imageId = Object::ID(insn.word(3));
+
+ const DescriptorDecorations &d = descriptorDecorations.at(imageId);
+ auto setLayout = state->routine->pipelineLayout->getDescriptorSetLayout(d.DescriptorSet);
+ auto &bindingLayout = setLayout->getBindingLayout(d.Binding);
+
+ Pointer<Byte> descriptor = state->getPointer(imageId).base;
+ Int mipLevels = 0;
+ switch (bindingLayout.descriptorType)
+ {
+ case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
+ case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
+ case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
+ mipLevels = *Pointer<Int>(descriptor + OFFSET(vk::SampledImageDescriptor, mipLevels)); // uint32_t
+ break;
+ default:
+ UNREACHABLE("Image descriptorType: %d", int(bindingLayout.descriptorType));
+ }
+
+ auto &dst = state->createIntermediate(resultId, 1);
+ dst.move(0, SIMD::Int(mipLevels));
+
+ return EmitResult::Continue;
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageQuerySamples(InsnIterator insn, EmitState *state) const
+{
+ auto &resultTy = getType(Type::ID(insn.word(1)));
+ ASSERT(resultTy.sizeInComponents == 1);
+ auto resultId = Object::ID(insn.word(2));
+ auto imageId = Object::ID(insn.word(3));
+ auto imageTy = getType(getObject(imageId).type);
+ ASSERT(imageTy.definition.opcode() == spv::OpTypeImage);
+ ASSERT(imageTy.definition.word(3) == spv::Dim2D);
+ ASSERT(imageTy.definition.word(6 /* MS */) == 1);
+
+ const DescriptorDecorations &d = descriptorDecorations.at(imageId);
+ auto setLayout = state->routine->pipelineLayout->getDescriptorSetLayout(d.DescriptorSet);
+ auto &bindingLayout = setLayout->getBindingLayout(d.Binding);
+
+ Pointer<Byte> descriptor = state->getPointer(imageId).base;
+ Int sampleCount = 0;
+ switch (bindingLayout.descriptorType)
+ {
+ case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
+ sampleCount = *Pointer<Int>(descriptor + OFFSET(vk::StorageImageDescriptor, sampleCount)); // uint32_t
+ break;
+ case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
+ case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
+ case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
+ sampleCount = *Pointer<Int>(descriptor + OFFSET(vk::SampledImageDescriptor, sampleCount)); // uint32_t
+ break;
+ default:
+ UNREACHABLE("Image descriptorType: %d", int(bindingLayout.descriptorType));
+ }
+
+ auto &dst = state->createIntermediate(resultId, 1);
+ dst.move(0, SIMD::Int(sampleCount));
+
+ return EmitResult::Continue;
+}
+
+SIMD::Pointer SpirvShader::GetTexelAddress(EmitState const *state, SIMD::Pointer ptr, GenericValue const & coordinate, Type const & imageType, Pointer<Byte> descriptor, int texelSize, Object::ID sampleId, bool useStencilAspect) const
+{
+ auto routine = state->routine;
+ bool isArrayed = imageType.definition.word(5) != 0;
+ auto dim = static_cast<spv::Dim>(imageType.definition.word(3));
+ int dims = getType(coordinate.type).sizeInComponents - (isArrayed ? 1 : 0);
+
+ SIMD::Int u = coordinate.Int(0);
+ SIMD::Int v = SIMD::Int(0);
+
+ if (getType(coordinate.type).sizeInComponents > 1)
+ {
+ v = coordinate.Int(1);
+ }
+
+ if (dim == spv::DimSubpassData)
+ {
+ u += routine->windowSpacePosition[0];
+ v += routine->windowSpacePosition[1];
+ }
+
+ auto rowPitch = SIMD::Int(*Pointer<Int>(descriptor + (useStencilAspect
+ ? OFFSET(vk::StorageImageDescriptor, stencilRowPitchBytes)
+ : OFFSET(vk::StorageImageDescriptor, rowPitchBytes))));
+ auto slicePitch = SIMD::Int(
+ *Pointer<Int>(descriptor + (useStencilAspect
+ ? OFFSET(vk::StorageImageDescriptor, stencilSlicePitchBytes)
+ : OFFSET(vk::StorageImageDescriptor, slicePitchBytes))));
+ auto samplePitch = SIMD::Int(
+ *Pointer<Int>(descriptor + (useStencilAspect
+ ? OFFSET(vk::StorageImageDescriptor, stencilSamplePitchBytes)
+ : OFFSET(vk::StorageImageDescriptor, samplePitchBytes))));
+
+ ptr += u * SIMD::Int(texelSize);
+ if (dims > 1)
+ {
+ ptr += v * rowPitch;
+ }
+ if (dims > 2)
+ {
+ ptr += coordinate.Int(2) * slicePitch;
+ }
+ if (isArrayed)
+ {
+ ptr += coordinate.Int(dims) * slicePitch;
+ }
+
+ if (dim == spv::DimSubpassData)
+ {
+ // Multiview input attachment access is to the layer corresponding to the current view
+ ptr += SIMD::Int(routine->viewID) * slicePitch;
+ }
+
+ if (sampleId.value())
+ {
+ GenericValue sample(this, state, sampleId);
+ ptr += sample.Int(0) * samplePitch;
+ }
+
+ return ptr;
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageRead(InsnIterator insn, EmitState *state) const
+{
+ auto &resultType = getType(Type::ID(insn.word(1)));
+ auto imageId = Object::ID(insn.word(3));
+ auto &image = getObject(imageId);
+ auto &imageType = getType(image.type);
+ Object::ID resultId = insn.word(2);
+
+ Object::ID sampleId = 0;
+
+ if (insn.wordCount() > 5)
+ {
+ int operand = 6;
+ auto imageOperands = insn.word(5);
+ if (imageOperands & spv::ImageOperandsSampleMask)
+ {
+ sampleId = insn.word(operand++);
+ imageOperands &= ~spv::ImageOperandsSampleMask;
+ }
+
+ // Should be no remaining image operands.
+ ASSERT(!imageOperands);
+ }
+
+ ASSERT(imageType.definition.opcode() == spv::OpTypeImage);
+ auto dim = static_cast<spv::Dim>(imageType.definition.word(3));
+
+ auto coordinate = GenericValue(this, state, insn.word(4));
+ const DescriptorDecorations &d = descriptorDecorations.at(imageId);
+
+ // For subpass data, format in the instruction is spv::ImageFormatUnknown. Get it from
+ // the renderpass data instead. In all other cases, we can use the format in the instruction.
+ auto vkFormat = (dim == spv::DimSubpassData)
+ ? inputAttachmentFormats[d.InputAttachmentIndex]
+ : SpirvFormatToVulkanFormat(static_cast<spv::ImageFormat>(imageType.definition.word(8)));
+
+ // Depth+Stencil image attachments select aspect based on the Sampled Type of the
+ // OpTypeImage. If float, then we want the depth aspect. If int, we want the stencil aspect.
+ auto useStencilAspect = (vkFormat == VK_FORMAT_D32_SFLOAT_S8_UINT &&
+ getType(imageType.definition.word(2)).opcode() == spv::OpTypeInt);
+
+ if (useStencilAspect)
+ {
+ vkFormat = VK_FORMAT_S8_UINT;
+ }
+
+ auto pointer = state->getPointer(imageId);
+ Pointer<Byte> binding = pointer.base;
+ Pointer<Byte> imageBase = *Pointer<Pointer<Byte>>(binding + (useStencilAspect
+ ? OFFSET(vk::StorageImageDescriptor, stencilPtr)
+ : OFFSET(vk::StorageImageDescriptor, ptr)));
+
+ auto imageSizeInBytes = *Pointer<Int>(binding + OFFSET(vk::StorageImageDescriptor, sizeInBytes));
+
+ auto &dst = state->createIntermediate(resultId, resultType.sizeInComponents);
+
+ auto texelSize = vk::Format(vkFormat).bytes();
+ auto basePtr = SIMD::Pointer(imageBase, imageSizeInBytes);
+ auto texelPtr = GetTexelAddress(state, basePtr, coordinate, imageType, binding, texelSize, sampleId, useStencilAspect);
+
+ // "The value returned by a read of an invalid texel is undefined,
+ // unless that read operation is from a buffer resource and the robustBufferAccess feature is enabled."
+ // TODO: Don't always assume a buffer resource.
+ auto robustness = OutOfBoundsBehavior::RobustBufferAccess;
+
+ SIMD::Int packed[4];
+ // Round up texel size: for formats smaller than 32 bits per texel, we will emit a bunch
+ // of (overlapping) 32b loads here, and each lane will pick out what it needs from the low bits.
+ // TODO: specialize for small formats?
+ for (auto i = 0; i < (texelSize + 3)/4; i++)
+ {
+ packed[i] = texelPtr.Load<SIMD::Int>(robustness, state->activeLaneMask(), false, std::memory_order_relaxed, std::min(texelSize, 4));
+ texelPtr += sizeof(float);
+ }
+
+ // Format support requirements here come from two sources:
+ // - Minimum required set of formats for loads from storage images
+ // - Any format supported as a color or depth/stencil attachment, for input attachments
+ switch(vkFormat)
+ {
+ case VK_FORMAT_R32G32B32A32_SFLOAT:
+ case VK_FORMAT_R32G32B32A32_SINT:
+ case VK_FORMAT_R32G32B32A32_UINT:
+ dst.move(0, packed[0]);
+ dst.move(1, packed[1]);
+ dst.move(2, packed[2]);
+ dst.move(3, packed[3]);
+ break;
+ case VK_FORMAT_R32_SINT:
+ case VK_FORMAT_R32_UINT:
+ dst.move(0, packed[0]);
+ // Fill remaining channels with 0,0,1 (of the correct type)
+ dst.move(1, SIMD::Int(0));
+ dst.move(2, SIMD::Int(0));
+ dst.move(3, SIMD::Int(1));
+ break;
+ case VK_FORMAT_R32_SFLOAT:
+ case VK_FORMAT_D32_SFLOAT:
+ case VK_FORMAT_D32_SFLOAT_S8_UINT:
+ dst.move(0, packed[0]);
+ // Fill remaining channels with 0,0,1 (of the correct type)
+ dst.move(1, SIMD::Float(0));
+ dst.move(2, SIMD::Float(0));
+ dst.move(3, SIMD::Float(1));
+ break;
+ case VK_FORMAT_D16_UNORM:
+ dst.move(0, SIMD::Float(packed[0] & SIMD::Int(0xffff)) * SIMD::Float(1.0f / 65535.0f));
+ dst.move(1, SIMD::Float(0));
+ dst.move(2, SIMD::Float(0));
+ dst.move(3, SIMD::Float(1));
+ break;
+ case VK_FORMAT_R16G16B16A16_SINT:
+ dst.move(0, (packed[0] << 16) >> 16);
+ dst.move(1, (packed[0]) >> 16);
+ dst.move(2, (packed[1] << 16) >> 16);
+ dst.move(3, (packed[1]) >> 16);
+ break;
+ case VK_FORMAT_R16G16B16A16_UINT:
+ dst.move(0, packed[0] & SIMD::Int(0xffff));
+ dst.move(1, (packed[0] >> 16) & SIMD::Int(0xffff));
+ dst.move(2, packed[1] & SIMD::Int(0xffff));
+ dst.move(3, (packed[1] >> 16) & SIMD::Int(0xffff));
+ break;
+ case VK_FORMAT_R16G16B16A16_SFLOAT:
+ dst.move(0, halfToFloatBits(As<SIMD::UInt>(packed[0]) & SIMD::UInt(0x0000FFFF)));
+ dst.move(1, halfToFloatBits((As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFFFF0000)) >> 16));
+ dst.move(2, halfToFloatBits(As<SIMD::UInt>(packed[1]) & SIMD::UInt(0x0000FFFF)));
+ dst.move(3, halfToFloatBits((As<SIMD::UInt>(packed[1]) & SIMD::UInt(0xFFFF0000)) >> 16));
+ break;
+ case VK_FORMAT_R8G8B8A8_SNORM:
+ dst.move(0, Min(Max(SIMD::Float(((packed[0]<<24) & SIMD::Int(0xFF000000))) * SIMD::Float(1.0f / float(0x7f000000)), SIMD::Float(-1.0f)), SIMD::Float(1.0f)));
+ dst.move(1, Min(Max(SIMD::Float(((packed[0]<<16) & SIMD::Int(0xFF000000))) * SIMD::Float(1.0f / float(0x7f000000)), SIMD::Float(-1.0f)), SIMD::Float(1.0f)));
+ dst.move(2, Min(Max(SIMD::Float(((packed[0]<<8) & SIMD::Int(0xFF000000))) * SIMD::Float(1.0f / float(0x7f000000)), SIMD::Float(-1.0f)), SIMD::Float(1.0f)));
+ dst.move(3, Min(Max(SIMD::Float(((packed[0]) & SIMD::Int(0xFF000000))) * SIMD::Float(1.0f / float(0x7f000000)), SIMD::Float(-1.0f)), SIMD::Float(1.0f)));
+ break;
+ case VK_FORMAT_R8G8B8A8_UNORM:
+ case VK_FORMAT_A8B8G8R8_UNORM_PACK32:
+ dst.move(0, SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ dst.move(1, SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ dst.move(2, SIMD::Float(((packed[0]>>16) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ dst.move(3, SIMD::Float(((packed[0]>>24) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ break;
+ case VK_FORMAT_R8G8B8A8_SRGB:
+ case VK_FORMAT_A8B8G8R8_SRGB_PACK32:
+ dst.move(0, ::sRGBtoLinear(SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
+ dst.move(1, ::sRGBtoLinear(SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
+ dst.move(2, ::sRGBtoLinear(SIMD::Float(((packed[0]>>16) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
+ dst.move(3, SIMD::Float(((packed[0]>>24) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ break;
+ case VK_FORMAT_B8G8R8A8_UNORM:
+ dst.move(0, SIMD::Float(((packed[0]>>16) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ dst.move(1, SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ dst.move(2, SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ dst.move(3, SIMD::Float(((packed[0]>>24) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ break;
+ case VK_FORMAT_B8G8R8A8_SRGB:
+ dst.move(0, ::sRGBtoLinear(SIMD::Float(((packed[0]>>16) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
+ dst.move(1, ::sRGBtoLinear(SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
+ dst.move(2, ::sRGBtoLinear(SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f)));
+ dst.move(3, SIMD::Float(((packed[0]>>24) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ break;
+ case VK_FORMAT_R8G8B8A8_UINT:
+ case VK_FORMAT_A8B8G8R8_UINT_PACK32:
+ dst.move(0, (As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFF)));
+ dst.move(1, ((As<SIMD::UInt>(packed[0])>>8) & SIMD::UInt(0xFF)));
+ dst.move(2, ((As<SIMD::UInt>(packed[0])>>16) & SIMD::UInt(0xFF)));
+ dst.move(3, ((As<SIMD::UInt>(packed[0])>>24) & SIMD::UInt(0xFF)));
+ break;
+ case VK_FORMAT_R8G8B8A8_SINT:
+ case VK_FORMAT_A8B8G8R8_SINT_PACK32:
+ dst.move(0, (packed[0] << 24) >> 24);
+ dst.move(1, (packed[0] << 16) >> 24);
+ dst.move(2, (packed[0] << 8) >> 24);
+ dst.move(3, (packed[0]) >> 24);
+ break;
+ case VK_FORMAT_R8_UNORM:
+ dst.move(0, SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ dst.move(1, SIMD::Float(0));
+ dst.move(2, SIMD::Float(0));
+ dst.move(3, SIMD::Float(1));
+ break;
+ case VK_FORMAT_R8_UINT:
+ case VK_FORMAT_S8_UINT:
+ dst.move(0, (As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFF)));
+ dst.move(1, SIMD::UInt(0));
+ dst.move(2, SIMD::UInt(0));
+ dst.move(3, SIMD::UInt(1));
+ break;
+ case VK_FORMAT_R8_SINT:
+ dst.move(0, (packed[0] << 24) >> 24);
+ dst.move(1, SIMD::Int(0));
+ dst.move(2, SIMD::Int(0));
+ dst.move(3, SIMD::Int(1));
+ break;
+ case VK_FORMAT_R8G8_UNORM:
+ dst.move(0, SIMD::Float((packed[0] & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ dst.move(1, SIMD::Float(((packed[0]>>8) & SIMD::Int(0xFF))) * SIMD::Float(1.0f / 255.f));
+ dst.move(2, SIMD::Float(0));
+ dst.move(3, SIMD::Float(1));
+ break;
+ case VK_FORMAT_R8G8_UINT:
+ dst.move(0, (As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFF)));
+ dst.move(1, ((As<SIMD::UInt>(packed[0])>>8) & SIMD::UInt(0xFF)));
+ dst.move(2, SIMD::UInt(0));
+ dst.move(3, SIMD::UInt(1));
+ break;
+ case VK_FORMAT_R8G8_SINT:
+ dst.move(0, (packed[0] << 24) >> 24);
+ dst.move(1, (packed[0] << 16) >> 24);
+ dst.move(2, SIMD::Int(0));
+ dst.move(3, SIMD::Int(1));
+ break;
+ case VK_FORMAT_R16_SFLOAT:
+ dst.move(0, halfToFloatBits(As<SIMD::UInt>(packed[0]) & SIMD::UInt(0x0000FFFF)));
+ dst.move(1, SIMD::Float(0));
+ dst.move(2, SIMD::Float(0));
+ dst.move(3, SIMD::Float(1));
+ break;
+ case VK_FORMAT_R16_UINT:
+ dst.move(0, packed[0] & SIMD::Int(0xffff));
+ dst.move(1, SIMD::UInt(0));
+ dst.move(2, SIMD::UInt(0));
+ dst.move(3, SIMD::UInt(1));
+ break;
+ case VK_FORMAT_R16_SINT:
+ dst.move(0, (packed[0] << 16) >> 16);
+ dst.move(1, SIMD::Int(0));
+ dst.move(2, SIMD::Int(0));
+ dst.move(3, SIMD::Int(1));
+ break;
+ case VK_FORMAT_R16G16_SFLOAT:
+ dst.move(0, halfToFloatBits(As<SIMD::UInt>(packed[0]) & SIMD::UInt(0x0000FFFF)));
+ dst.move(1, halfToFloatBits((As<SIMD::UInt>(packed[0]) & SIMD::UInt(0xFFFF0000)) >> 16));
+ dst.move(2, SIMD::Float(0));
+ dst.move(3, SIMD::Float(1));
+ break;
+ case VK_FORMAT_R16G16_UINT:
+ dst.move(0, packed[0] & SIMD::Int(0xffff));
+ dst.move(1, (packed[0] >> 16) & SIMD::Int(0xffff));
+ dst.move(2, SIMD::UInt(0));
+ dst.move(3, SIMD::UInt(1));
+ break;
+ case VK_FORMAT_R16G16_SINT:
+ dst.move(0, (packed[0] << 16) >> 16);
+ dst.move(1, (packed[0]) >> 16);
+ dst.move(2, SIMD::Int(0));
+ dst.move(3, SIMD::Int(1));
+ break;
+ case VK_FORMAT_R32G32_SINT:
+ case VK_FORMAT_R32G32_UINT:
+ dst.move(0, packed[0]);
+ dst.move(1, packed[1]);
+ dst.move(2, SIMD::Int(0));
+ dst.move(3, SIMD::Int(1));
+ break;
+ case VK_FORMAT_R32G32_SFLOAT:
+ dst.move(0, packed[0]);
+ dst.move(1, packed[1]);
+ dst.move(2, SIMD::Float(0));
+ dst.move(3, SIMD::Float(1));
+ break;
+ case VK_FORMAT_A2B10G10R10_UINT_PACK32:
+ dst.move(0, (packed[0]) & SIMD::Int(0x3FF));
+ dst.move(1, (packed[0] >> 10) & SIMD::Int(0x3FF));
+ dst.move(2, (packed[0] >> 20) & SIMD::Int(0x3FF));
+ dst.move(3, (packed[0] >> 30) & SIMD::Int(0x3));
+ break;
+ case VK_FORMAT_A2B10G10R10_UNORM_PACK32:
+ dst.move(0, SIMD::Float((packed[0]) & SIMD::Int(0x3FF)) * SIMD::Float(1.0f / 0x3FF));
+ dst.move(1, SIMD::Float((packed[0] >> 10) & SIMD::Int(0x3FF)) * SIMD::Float(1.0f / 0x3FF));
+ dst.move(2, SIMD::Float((packed[0] >> 20) & SIMD::Int(0x3FF)) * SIMD::Float(1.0f / 0x3FF));
+ dst.move(3, SIMD::Float((packed[0] >> 30) & SIMD::Int(0x3)) * SIMD::Float(1.0f / 0x3));
+ break;
+ case VK_FORMAT_R5G6B5_UNORM_PACK16:
+ dst.move(0, SIMD::Float((packed[0] >> 11) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
+ dst.move(1, SIMD::Float((packed[0] >> 5) & SIMD::Int(0x3F)) * SIMD::Float(1.0f / 0x3F));
+ dst.move(2, SIMD::Float((packed[0]) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
+ dst.move(3, SIMD::Float(1));
+ break;
+ case VK_FORMAT_A1R5G5B5_UNORM_PACK16:
+ dst.move(0, SIMD::Float((packed[0] >> 10) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
+ dst.move(1, SIMD::Float((packed[0] >> 5) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
+ dst.move(2, SIMD::Float((packed[0]) & SIMD::Int(0x1F)) * SIMD::Float(1.0f / 0x1F));
+ dst.move(3, SIMD::Float((packed[0] >> 15) & SIMD::Int(0x1)));
+ break;
+ default:
+ UNIMPLEMENTED("VkFormat %d", int(vkFormat));
+ break;
+ }
+
+ return EmitResult::Continue;
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageWrite(InsnIterator insn, EmitState *state) const
+{
+ auto imageId = Object::ID(insn.word(1));
+ auto &image = getObject(imageId);
+ auto &imageType = getType(image.type);
+
+ ASSERT(imageType.definition.opcode() == spv::OpTypeImage);
+
+ // TODO(b/131171141): Not handling any image operands yet.
+ ASSERT(insn.wordCount() == 4);
+
+ auto coordinate = GenericValue(this, state, insn.word(2));
+ auto texel = GenericValue(this, state, insn.word(3));
+
+ Pointer<Byte> binding = state->getPointer(imageId).base;
+ Pointer<Byte> imageBase = *Pointer<Pointer<Byte>>(binding + OFFSET(vk::StorageImageDescriptor, ptr));
+ auto imageSizeInBytes = *Pointer<Int>(binding + OFFSET(vk::StorageImageDescriptor, sizeInBytes));
+
+ SIMD::Int packed[4];
+ auto numPackedElements = 0u;
+ int texelSize = 0;
+ auto format = static_cast<spv::ImageFormat>(imageType.definition.word(8));
+ switch (format)
+ {
+ case spv::ImageFormatRgba32f:
+ case spv::ImageFormatRgba32i:
+ case spv::ImageFormatRgba32ui:
+ texelSize = 16;
+ packed[0] = texel.Int(0);
+ packed[1] = texel.Int(1);
+ packed[2] = texel.Int(2);
+ packed[3] = texel.Int(3);
+ numPackedElements = 4;
+ break;
+ case spv::ImageFormatR32f:
+ case spv::ImageFormatR32i:
+ case spv::ImageFormatR32ui:
+ texelSize = 4;
+ packed[0] = texel.Int(0);
+ numPackedElements = 1;
+ break;
+ case spv::ImageFormatRgba8:
+ texelSize = 4;
+ packed[0] = (SIMD::UInt(Round(Min(Max(texel.Float(0), SIMD::Float(0.0f)), SIMD::Float(1.0f)) * SIMD::Float(255.0f)))) |
+ ((SIMD::UInt(Round(Min(Max(texel.Float(1), SIMD::Float(0.0f)), SIMD::Float(1.0f)) * SIMD::Float(255.0f)))) << 8) |
+ ((SIMD::UInt(Round(Min(Max(texel.Float(2), SIMD::Float(0.0f)), SIMD::Float(1.0f)) * SIMD::Float(255.0f)))) << 16) |
+ ((SIMD::UInt(Round(Min(Max(texel.Float(3), SIMD::Float(0.0f)), SIMD::Float(1.0f)) * SIMD::Float(255.0f)))) << 24);
+ numPackedElements = 1;
+ break;
+ case spv::ImageFormatRgba8Snorm:
+ texelSize = 4;
+ packed[0] = (SIMD::Int(Round(Min(Max(texel.Float(0), SIMD::Float(-1.0f)), SIMD::Float(1.0f)) * SIMD::Float(127.0f))) &
+ SIMD::Int(0xFF)) |
+ ((SIMD::Int(Round(Min(Max(texel.Float(1), SIMD::Float(-1.0f)), SIMD::Float(1.0f)) * SIMD::Float(127.0f))) &
+ SIMD::Int(0xFF)) << 8) |
+ ((SIMD::Int(Round(Min(Max(texel.Float(2), SIMD::Float(-1.0f)), SIMD::Float(1.0f)) * SIMD::Float(127.0f))) &
+ SIMD::Int(0xFF)) << 16) |
+ ((SIMD::Int(Round(Min(Max(texel.Float(3), SIMD::Float(-1.0f)), SIMD::Float(1.0f)) * SIMD::Float(127.0f))) &
+ SIMD::Int(0xFF)) << 24);
+ numPackedElements = 1;
+ break;
+ case spv::ImageFormatRgba8i:
+ case spv::ImageFormatRgba8ui:
+ texelSize = 4;
+ packed[0] = (SIMD::UInt(texel.UInt(0) & SIMD::UInt(0xff))) |
+ (SIMD::UInt(texel.UInt(1) & SIMD::UInt(0xff)) << 8) |
+ (SIMD::UInt(texel.UInt(2) & SIMD::UInt(0xff)) << 16) |
+ (SIMD::UInt(texel.UInt(3) & SIMD::UInt(0xff)) << 24);
+ numPackedElements = 1;
+ break;
+ case spv::ImageFormatRgba16f:
+ texelSize = 8;
+ packed[0] = FloatToHalfBits(texel.UInt(0), false) | FloatToHalfBits(texel.UInt(1), true);
+ packed[1] = FloatToHalfBits(texel.UInt(2), false) | FloatToHalfBits(texel.UInt(3), true);
+ numPackedElements = 2;
+ break;
+ case spv::ImageFormatRgba16i:
+ case spv::ImageFormatRgba16ui:
+ texelSize = 8;
+ packed[0] = SIMD::UInt(texel.UInt(0) & SIMD::UInt(0xffff)) | (SIMD::UInt(texel.UInt(1) & SIMD::UInt(0xffff)) << 16);
+ packed[1] = SIMD::UInt(texel.UInt(2) & SIMD::UInt(0xffff)) | (SIMD::UInt(texel.UInt(3) & SIMD::UInt(0xffff)) << 16);
+ numPackedElements = 2;
+ break;
+ case spv::ImageFormatRg32f:
+ case spv::ImageFormatRg32i:
+ case spv::ImageFormatRg32ui:
+ texelSize = 8;
+ packed[0] = texel.Int(0);
+ packed[1] = texel.Int(1);
+ numPackedElements = 2;
+ break;
+
+ case spv::ImageFormatRg16f:
+ case spv::ImageFormatR11fG11fB10f:
+ case spv::ImageFormatR16f:
+ case spv::ImageFormatRgba16:
+ case spv::ImageFormatRgb10A2:
+ case spv::ImageFormatRg16:
+ case spv::ImageFormatRg8:
+ case spv::ImageFormatR16:
+ case spv::ImageFormatR8:
+ case spv::ImageFormatRgba16Snorm:
+ case spv::ImageFormatRg16Snorm:
+ case spv::ImageFormatRg8Snorm:
+ case spv::ImageFormatR16Snorm:
+ case spv::ImageFormatR8Snorm:
+ case spv::ImageFormatRg16i:
+ case spv::ImageFormatRg8i:
+ case spv::ImageFormatR16i:
+ case spv::ImageFormatR8i:
+ case spv::ImageFormatRgb10a2ui:
+ case spv::ImageFormatRg16ui:
+ case spv::ImageFormatRg8ui:
+ case spv::ImageFormatR16ui:
+ case spv::ImageFormatR8ui:
+ UNIMPLEMENTED("spv::ImageFormat %d", int(format));
+ break;
+
+ default:
+ UNREACHABLE("spv::ImageFormat %d", int(format));
+ break;
+ }
+
+ auto basePtr = SIMD::Pointer(imageBase, imageSizeInBytes);
+ auto texelPtr = GetTexelAddress(state, basePtr, coordinate, imageType, binding, texelSize, 0, false);
+
+ // SPIR-V 1.4: "If the coordinates are outside the image, the memory location that is accessed is undefined."
+ auto robustness = OutOfBoundsBehavior::UndefinedValue;
+
+ for (auto i = 0u; i < numPackedElements; i++)
+ {
+ texelPtr.Store(packed[i], robustness, state->activeLaneMask());
+ texelPtr += sizeof(float);
+ }
+
+ return EmitResult::Continue;
+}
+
+SpirvShader::EmitResult SpirvShader::EmitImageTexelPointer(InsnIterator insn, EmitState *state) const
+{
+ auto &resultType = getType(Type::ID(insn.word(1)));
+ auto imageId = Object::ID(insn.word(3));
+ auto &image = getObject(imageId);
+ // Note: OpImageTexelPointer is unusual in that the image is passed by pointer.
+ // Look through to get the actual image type.
+ auto &imageType = getType(getType(image.type).element);
+ Object::ID resultId = insn.word(2);
+
+ ASSERT(imageType.opcode() == spv::OpTypeImage);
+ ASSERT(resultType.storageClass == spv::StorageClassImage);
+ ASSERT(getType(resultType.element).opcode() == spv::OpTypeInt);
+
+ auto coordinate = GenericValue(this, state, insn.word(4));
+
+ Pointer<Byte> binding = state->getPointer(imageId).base;
+ Pointer<Byte> imageBase = *Pointer<Pointer<Byte>>(binding + OFFSET(vk::StorageImageDescriptor, ptr));
+ auto imageSizeInBytes = *Pointer<Int>(binding + OFFSET(vk::StorageImageDescriptor, sizeInBytes));
+
+ auto basePtr = SIMD::Pointer(imageBase, imageSizeInBytes);
+ auto ptr = GetTexelAddress(state, basePtr, coordinate, imageType, binding, sizeof(uint32_t), 0, false);
+
+ state->createPointer(resultId, ptr);
+
+ return EmitResult::Continue;
+}
+
+SpirvShader::EmitResult SpirvShader::EmitSampledImageCombineOrSplit(InsnIterator insn, EmitState *state) const
+{
+ // Propagate the image pointer in both cases.
+ // Consumers of OpSampledImage will look through to find the sampler pointer.
+
+ Object::ID resultId = insn.word(2);
+ Object::ID imageId = insn.word(3);
+
+ state->createPointer(resultId, state->getPointer(imageId));
+
+ return EmitResult::Continue;
+}
+
+} // namespace sw
\ No newline at end of file
diff --git a/src/Vulkan/vulkan.vcxproj b/src/Vulkan/vulkan.vcxproj
index d575588..f15f7de 100644
--- a/src/Vulkan/vulkan.vcxproj
+++ b/src/Vulkan/vulkan.vcxproj
@@ -168,6 +168,7 @@
<ClCompile Include="..\Pipeline\SpirvShaderControlFlow.cpp" />
<ClCompile Include="..\Pipeline\SpirvShaderGLSLstd450.cpp" />
<ClCompile Include="..\Pipeline\SpirvShaderGroup.cpp" />
+ <ClCompile Include="..\Pipeline\SpirvShaderImage.cpp" />
<ClCompile Include="..\Pipeline\SpirvShaderMemory.cpp" />
<ClCompile Include="..\Pipeline\SpirvShaderSampling.cpp" />
<ClCompile Include="..\Pipeline\SpirvShaderSpec.cpp" />
diff --git a/src/Vulkan/vulkan.vcxproj.filters b/src/Vulkan/vulkan.vcxproj.filters
index 1117b53..4407b65 100644
--- a/src/Vulkan/vulkan.vcxproj.filters
+++ b/src/Vulkan/vulkan.vcxproj.filters
@@ -255,6 +255,9 @@
<ClCompile Include="..\Pipeline\SpirvShaderGroup.cpp">
<Filter>Source Files\Pipeline</Filter>
</ClCompile>
+ <ClCompile Include="..\Pipeline\SpirvShaderImage.cpp">
+ <Filter>Source Files\Pipeline</Filter>
+ </ClCompile>
<ClCompile Include="..\Pipeline\SpirvShaderMemory.cpp">
<Filter>Source Files\Pipeline</Filter>
</ClCompile>
