commit 5830d745b1b23de124f043b0018d74be3b2b5a04
author Nicolas Capens <capn@google.com> Wed Jan 27 23:51:02 2021 -0500
committer Nicolas Capens <nicolascapens@google.com> Fri Jan 29 07:36:35 2021 +0000
tree b6a0535e0ab99d3c36d319532b7484a37eacc069
parent 0cbf89c7520e5d27076f74659b28636e0456ef68

Enable named mmap usage for CMake builds

Naming 'anonymous' mmap memory, which we use for Reactor's executable
memory, enables profilers to attribute JIT-compiled routine execution
to SwiftShader.

Also suppress a GCC warning about not using the result of ftruncate().

Bug: b/174801963
Bug: b/178614275
Change-Id: Iac4938f332f0e75a9b1d995c83f0cbaaf3532651
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/52228
Tested-by: Nicolas Capens <nicolascapens@google.com>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

src/Reactor/CMakeLists.txt

diff --git a/src/Reactor/CMakeLists.txt b/src/Reactor/CMakeLists.txt
index 0717fb9..268c1f7 100644
--- a/src/Reactor/CMakeLists.txt
+++ b/src/Reactor/CMakeLists.txt
@@ -72,6 +72,8 @@
     list(APPEND REACTOR_PUBLIC_COMPILE_DEFINITIONS "REACTOR_ENABLE_MEMORY_SANITIZER_INSTRUMENTATION")
 endif()
 
+list(APPEND REACTOR_PRIVATE_COMPILE_DEFINITIONS "REACTOR_ANONYMOUS_MMAP_NAME=swiftshader_jit")
+
 # SubzeroReactor library
 
 add_library(ReactorSubzero STATIC EXCLUDE_FROM_ALL

src/Reactor/ExecutableMemory.cpp

diff --git a/src/Reactor/ExecutableMemory.cpp b/src/Reactor/ExecutableMemory.cpp
index 38b73b7..46b4480 100644
--- a/src/Reactor/ExecutableMemory.cpp
+++ b/src/Reactor/ExecutableMemory.cpp
@@ -172,7 +172,8 @@
 	static size_t fileSize = 0;
 	if(length > fileSize)
 	{
-		ftruncate(anonFd, length);
+		[[maybe_unused]] int result = ftruncate(anonFd, length);
+		ASSERT(result == 0);
 		fileSize = length;
 	}
 }