Clarify DepthGreater/Less/Unchanged execution modes are unused
These SPIR-V execution modes can be used to optimize early depth test,
but are currently ignored, which is fine from a correctness point of
view.
We need to handle these execution modes because they can appear in any
shader, without the implementation having to support using them for
optimizations. Also, we can keep the SpirvShader::Modes fields that
correspond to them for debugging purposes (e.g. an application might
incorrectly rely on early depth test optimization to happen).
Bug: b/177915067
Change-Id: I851fdfbcdde5be6287bc4ee689fdbd6549e2900f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/51908
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
diff --git a/src/Pipeline/SpirvShader.cpp b/src/Pipeline/SpirvShader.cpp
index d7a3069..ce3b0cb 100644
--- a/src/Pipeline/SpirvShader.cpp
+++ b/src/Pipeline/SpirvShader.cpp
@@ -936,12 +936,15 @@
modes.DepthReplacing = true;
break;
case spv::ExecutionModeDepthGreater:
+ // TODO(b/177915067): Can be used to optimize depth test, currently unused.
modes.DepthGreater = true;
break;
case spv::ExecutionModeDepthLess:
+ // TODO(b/177915067): Can be used to optimize depth test, currently unused.
modes.DepthLess = true;
break;
case spv::ExecutionModeDepthUnchanged:
+ // TODO(b/177915067): Can be used to optimize depth test, currently unused.
modes.DepthUnchanged = true;
break;
case spv::ExecutionModeLocalSize:
