commit 41b7748432efe3163e0ca3d586d88ba4dd6fb22f
author Alexis Hetu <sugoi@google.com> Fri Jun 22 16:02:55 2018 -0400
committer Nicolas Capens <nicolascapens@google.com> Fri Jun 22 20:08:13 2018 +0000
tree 891ef9dae5b181d07571be2500d2676582b33699
parent 932640b2d9cd2611ff60907a3d3d1ba0ad966c14

Memory leak fix

Early returns were erroneous and were causing memory leaks

Change-Id: Ifd6e37d79b6abd3f7d8d8899c951f1a0b4a66fb0
Reviewed-on: https://swiftshader-review.googlesource.com/19588
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

src/Reactor/Optimizer.cpp

diff --git a/src/Reactor/Optimizer.cpp b/src/Reactor/Optimizer.cpp
index 15c5f84..aac8c04 100644
--- a/src/Reactor/Optimizer.cpp
+++ b/src/Reactor/Optimizer.cpp
@@ -150,14 +150,14 @@
 
 			if(!llvm::isa<Ice::InstAlloca>(alloca))
 			{
-				return;   // Allocas are all at the top
+				break;   // Allocas are all at the top
 			}
 
 			Ice::Operand *address = alloca.getDest();
 
 			if(!hasUses(address))
 			{
-				return;
+				continue;
 			}
 
 			const auto &addressUses = *getUses(address);
@@ -213,14 +213,14 @@
 
 			if(!llvm::isa<Ice::InstAlloca>(alloca))
 			{
-				return;   // Allocas are all at the top
+				break;   // Allocas are all at the top
 			}
 
 			Ice::Operand *address = alloca.getDest();
 
 			if(!hasUses(address))
 			{
-				return;
+				continue;
 			}
 
 			auto &addressUses = *getUses(address);
@@ -324,14 +324,14 @@
 
 			if(!llvm::isa<Ice::InstAlloca>(alloca))
 			{
-				return;   // Allocas are all at the top
+				break;   // Allocas are all at the top
 			}
 
 			Ice::Operand *address = alloca.getDest();
 
 			if(!hasUses(address))
 			{
-				return;
+				continue;
 			}
 
 			const auto &addressUses = *getUses(address);