Replace use of ASSERT(false) with UNIMPLEMENTED ... along with a message saying what switch case wasn't handled. Helps identify what needs fixing for the daily Regres reports. Change-Id: I79448135fc84190d6e803e90e7995ae83058f663 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28400 Reviewed-by: Nicolas Capens <nicolascapens@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by: Ben Clayton <bclayton@google.com>
diff --git a/src/Pipeline/PixelProgram.cpp b/src/Pipeline/PixelProgram.cpp index c64c7ae..45b5348 100644 --- a/src/Pipeline/PixelProgram.cpp +++ b/src/Pipeline/PixelProgram.cpp
@@ -173,7 +173,7 @@ } break; default: - ASSERT(false); + UNIMPLEMENTED("VkFormat: %d", int(state.targetFormat[index])); } } } @@ -227,7 +227,7 @@ case VK_FORMAT_R8G8B8A8_UINT: break; default: - ASSERT(false); + UNIMPLEMENTED("VkFormat: %d", int(state.targetFormat[index])); } } }
diff --git a/src/Pipeline/PixelRoutine.cpp b/src/Pipeline/PixelRoutine.cpp index 7e841e0..57cbf4e 100644 --- a/src/Pipeline/PixelRoutine.cpp +++ b/src/Pipeline/PixelRoutine.cpp
@@ -363,7 +363,7 @@ value ^= Byte8(0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF); break; default: - ASSERT(false); + UNIMPLEMENTED("VkCompareOp: %d", int(stencilCompareMode)); } } @@ -439,7 +439,7 @@ zTest = CmpLT(zValue, Z); break; default: - ASSERT(false); + UNIMPLEMENTED("VkCompareOp: %d", int(state.depthCompareMode)); } switch(state.depthCompareMode) @@ -539,7 +539,7 @@ zTest = Int4(CmpGT(Z, zValue)); break; default: - ASSERT(false); + UNIMPLEMENTED("VkCompareOp: %d", int(state.depthCompareMode)); } switch(state.depthCompareMode) @@ -855,7 +855,7 @@ output = bufferValue - Byte8(1, 1, 1, 1, 1, 1, 1, 1); break; default: - ASSERT(false); + UNIMPLEMENTED("VkStencilOp: %d", int(operation)); } } @@ -936,7 +936,7 @@ blendFactor.z = *Pointer<Short4>(data + OFFSET(DrawData,factor.invBlendConstant4W[3])); break; default: - ASSERT(false); + UNIMPLEMENTED("VkBlendFactor: %d", int(blendFactorActive)); } } @@ -986,7 +986,7 @@ blendFactor.w = *Pointer<Short4>(data + OFFSET(DrawData,factor.invBlendConstant4W[3])); break; default: - ASSERT(false); + UNIMPLEMENTED("VkBlendFactor: %d", int(blendFactorAlphaActive)); } } @@ -1097,7 +1097,7 @@ pixel.w = Short4(0xFFFFu); break; default: - ASSERT(false); + UNIMPLEMENTED("VkFormat %d", state.targetFormat[index]); } if((postBlendSRGB && state.writeSRGB) || isSRGB(index)) @@ -1178,7 +1178,7 @@ current.z = Short4(0x0000); break; default: - ASSERT(false); + UNIMPLEMENTED("VkBlendOp: %d", int(state.blendOperation)); } blendFactorAlpha(sourceFactor, current, pixel, state.sourceBlendFactorAlpha); @@ -1221,7 +1221,7 @@ current.w = Short4(0x0000); break; default: - ASSERT(false); + UNIMPLEMENTED("VkBlendOp: %d", int(state.blendOperationAlpha)); } } @@ -1362,7 +1362,7 @@ transpose4x4(current.x, current.y, current.z, current.w); break; default: - ASSERT(false); + UNIMPLEMENTED("VkFormat: %d", int(state.targetFormat[index])); } Short4 c01 = current.z; @@ -1653,7 +1653,7 @@ } break; default: - ASSERT(false); + UNIMPLEMENTED("VkFormat: %d", int(state.targetFormat[index])); } } @@ -1724,7 +1724,7 @@ blendFactor.z = *Pointer<Float4>(data + OFFSET(DrawData,factor.invBlendConstant4F[2])); break; default: - ASSERT(false); + UNIMPLEMENTED("VkBlendFactor: %d", int(blendFactorActive)); } } @@ -1772,7 +1772,7 @@ blendFactor.w = *Pointer<Float4>(data + OFFSET(DrawData,factor.invBlendConstant4F[3])); break; default: - ASSERT(false); + UNIMPLEMENTED("VkBlendFactor: %d", int(blendFactorAlphaActive)); } } @@ -1841,7 +1841,7 @@ transpose4x4(pixel.x, pixel.y, pixel.z, pixel.w); break; default: - ASSERT(false); + UNIMPLEMENTED("VkFormat: %d", int(state.targetFormat[index])); } if((postBlendSRGB && state.writeSRGB) || isSRGB(index)) @@ -1913,7 +1913,7 @@ oC.z = Float4(0.0f); break; default: - ASSERT(false); + UNIMPLEMENTED("VkBlendOp: %d", int(state.blendOperation)); } blendFactorAlpha(sourceFactor, oC, pixel, state.sourceBlendFactorAlpha); @@ -1957,7 +1957,7 @@ oC.w = Float4(0.0f); break; default: - ASSERT(false); + UNIMPLEMENTED("VkBlendOp: %d", int(state.blendOperationAlpha)); } } @@ -1995,7 +1995,7 @@ transpose4x4(oC.x, oC.y, oC.z, oC.w); break; default: - ASSERT(false); + UNIMPLEMENTED("VkFormat: %d", int(state.targetFormat[index])); } int rgbaWriteMask = state.colorWriteActive(index); @@ -2386,7 +2386,7 @@ } break; default: - ASSERT(false); + UNIMPLEMENTED("VkFormat: %d", int(state.targetFormat[index])); } }