Regres: Test changes from external contributors if reviewed by Googler
Previously only changes authored by Googlers would be tested, leaving
external contributions untested until the next 'daily' run.
This change enables testing of external contributions when a Googler
added a Code-Review+1, Code-Review+2, or Presubmit-Ready+1 vote.
Change-Id: I2f5c327848ad507d75967c9fd7f16085d0729a1a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45508
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
diff --git a/tests/regres/cmd/regres/main.go b/tests/regres/cmd/regres/main.go
index af8ca15..be074c8 100644
--- a/tests/regres/cmd/regres/main.go
+++ b/tests/regres/cmd/regres/main.go
@@ -989,8 +989,11 @@
c.priority++
}
- // Is the change from a Googler?
- canTest := strings.HasSuffix(current.Commit.Committer.Email, "@google.com")
+ // Is the change from a Googler or reviewed by a Googler?
+ canTest := strings.HasSuffix(current.Commit.Committer.Email, "@google.com") ||
+ strings.HasSuffix(change.Labels["Code-Review"].Approved.Email, "@google.com") ||
+ strings.HasSuffix(change.Labels["Code-Review"].Recommended.Email, "@google.com") ||
+ strings.HasSuffix(change.Labels["Presubmit-Ready"].Approved.Email, "@google.com")
// Has the latest patchset already been tested?
if canTest {
