commit 24530cae538d9933459c898134d8d3b0c0e59022
author Nico Weber <thakis@chromium.org> Wed Oct 06 14:38:24 2021 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 08 16:19:35 2021 +0000
tree 871c47e6a7ab81cc5b308800e7dc49de42fb8fe1
parent a1594b97ef0c7cb4425cd45634d58b141fc505f5

Disable C4244 when building LLVM for swiftshader

MSVC STL headers contain
`#pragma warning(disable : _STL_DISABLED_WARNINGS)`, where
_STL_DISABLED_WARNINGS defaults to 4 and is forced to be at least 3.
So we get C4244 all over the place even though we don't pass /W3 or /W4.

Bug: chromium:1257173
Change-Id: I486c9814ab995227937870823f7da9c7c71ecddc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/57968
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Tested-by: Nico Weber <thakis@chromium.org>

src/Reactor/BUILD.gn

diff --git a/src/Reactor/BUILD.gn b/src/Reactor/BUILD.gn
index eb72fd9..6846797 100644
--- a/src/Reactor/BUILD.gn
+++ b/src/Reactor/BUILD.gn
@@ -21,6 +21,7 @@
       "/wd4141",  # 'inline' used more than once. (LLVM 7.0)
       "/wd4146",  # unary minus operator applied to unsigned type. (LLVM 7.0)
       "/wd4201",  # nameless struct/union
+      "/wd4244",  # conversion' conversion from 'type1' to 'type2'
       "/wd4245",  # conversion from int to unsigned int (llvm)
       "/wd4624",  # destructor was implicitly defined as deleted (LLVM 7.0)
     ]

third_party/llvm-10.0/BUILD.gn

diff --git a/third_party/llvm-10.0/BUILD.gn b/third_party/llvm-10.0/BUILD.gn
index 25e84e5..bc6116a 100644
--- a/third_party/llvm-10.0/BUILD.gn
+++ b/third_party/llvm-10.0/BUILD.gn
@@ -25,6 +25,7 @@
       "/wd4065",
       "/wd4141",
       "/wd4146",
+      "/wd4244",
       "/wd4245",
       "/wd4267",
       "/wd4310",