commit 09a91e48c066c1584619ae0009e72fe09329115e
author Ben Clayton <bclayton@google.com> Tue Feb 05 17:58:38 2019 +0000
committer Ben Clayton <bclayton@google.com> Tue Feb 05 19:11:36 2019 +0000
tree 6d59e855fa1ddb4fa88bdb665fb2854e83222a1e
parent 4b9e06d6a2df76966ca38ddba48985b71814c057

Silence clang warning spewed by every .cpp compile

clang: warning: argument unused during compilation: '-s' [-Wunused-command-line-argument]

Bug: b/123933266
Change-Id: I809458fa08b9b6b3af7d31c19a90206462d0b0c6
Reviewed-on: https://swiftshader-review.googlesource.com/c/24429
Kokoro-Presubmit: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 6616893..054ad5b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -248,7 +248,10 @@
     # Use -g3 to have even more debug info
     set_cpp_flag("-g -g3" DEBUG)
     set_cpp_flag("-g -g3" RELWITHDEBINFO)
-    set_cpp_flag("-s" RELEASE)
+    if(NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+        # Treated as an unused argument with clang
+        set_cpp_flag("-s" RELEASE)
+    endif()
 
     # For distribution it is more important to be slim than super optimized
     set_cpp_flag("-Os" RELEASE)