commit 04e6b3b21be9e26ff7c4550ecc927501e2257205
author Nicolas Capens <capn@google.com> Wed May 13 16:14:15 2020 -0400
committer Nicolas Capens <nicolascapens@google.com> Mon May 25 21:41:47 2020 +0000
tree d76d382458b01f5152f1853d9a7966fbac62f703
parent 3b655b655f21f560a2ed3ea06893cdcd796b7122

Unconditionally define the RValue copy constructor

Previously we relied on the default copy constructor to be generated
when ENABLE_RR_DEBUG_INFO is disabled. This is not necessary as we can
just use the straightforward manual definition of it in either case.
Note RR_DEBUG_INFO_EMIT_VAR() is a no-op when ENABLE_RR_DEBUG_INFO is
disabled.

Bug: b/155302798
Change-Id: I04c020a795b4333e3c3d0a7ed375d21d9382e3d1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45152
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>

src/Reactor/Reactor.hpp

diff --git a/src/Reactor/Reactor.hpp b/src/Reactor/Reactor.hpp
index 2cef4df..83e4a64 100644
--- a/src/Reactor/Reactor.hpp
+++ b/src/Reactor/Reactor.hpp
@@ -247,10 +247,7 @@
 
 	explicit RValue(Value *rvalue);
 
-#ifdef ENABLE_RR_DEBUG_INFO
 	RValue(const RValue<T> &rvalue);
-#endif  // ENABLE_RR_DEBUG_INFO
-
 	RValue(const T &lvalue);
 	RValue(typename BoolLiteral<T>::type i);
 	RValue(typename IntLiteral<T>::type i);
@@ -2737,14 +2734,12 @@
 	return alignment;
 }
 
-#ifdef ENABLE_RR_DEBUG_INFO
 template<class T>
 RValue<T>::RValue(const RValue<T> &rvalue)
     : val(rvalue.val)
 {
 	RR_DEBUG_INFO_EMIT_VAR(val);
 }
-#endif  // ENABLE_RR_DEBUG_INFO
 
 template<class T>
 RValue<T>::RValue(Value *value)