commit f52cea4bb987e8c43a881f243dbb8f41f31797d5
author Nicolas Capens <capn@google.com> Fri Oct 14 16:29:11 2016 -0400
committer Nicolas Capens <nicolascapens@google.com> Mon Oct 17 17:04:32 2016 +0000
tree adf6d9728918168812fb7c6ac2ed6a2605f46614
parent 3a01f337a848f4200542393d60d32c7e79ff42ea

Fix unpacking from a single vector.

Both vector arguments were being used in a punpckl instruction, while
the shuffle mask repeats elements from just the first vector.

BUG=swiftshader:15

Change-Id: I8e29c252ee4957692c4949e724ae67253b423e89
Reviewed-on: https://chromium-review.googlesource.com/399419
Reviewed-by: Jim Stichnoth <stichnot@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@google.com>

src/IceTargetLoweringX86BaseImpl.h

diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h
index 260366b..72ed7aa 100644
--- a/src/IceTargetLoweringX86BaseImpl.h
+++ b/src/IceTargetLoweringX86BaseImpl.h
@@ -6022,9 +6022,8 @@
         Index12 == 6 && Index13 == 6 && Index14 == 7 && Index15 == 7) {
       auto *T = makeReg(DestTy);
       auto *Src0RM = legalize(Src0, Legal_Reg | Legal_Mem);
-      auto *Src1RM = legalize(Src1, Legal_Reg | Legal_Mem);
       _movp(T, Src0RM);
-      _punpckl(T, Src1RM);
+      _punpckl(T, Src0RM);
       _movp(Dest, T);
       return;
     }
@@ -6058,9 +6057,8 @@
         Index4 == 2 && Index5 == 2 && Index6 == 3 && Index7 == 3) {
       auto *T = makeReg(DestTy);
       auto *Src0RM = legalize(Src0, Legal_Reg | Legal_Mem);
-      auto *Src1RM = legalize(Src1, Legal_Reg | Legal_Mem);
       _movp(T, Src0RM);
-      _punpckl(T, Src1RM);
+      _punpckl(T, Src0RM);
       _movp(Dest, T);
       return;
     }