commit d0bfd91562ad116319fbc0b896d7e01f326aa9de
author Nicolas Capens <capn@google.com> Wed May 24 10:20:24 2017 -0400
committer Nicolas Capens <capn@google.com> Wed May 24 14:46:47 2017 +0000
tree 9106d3f272ebeed62bbbf8c59d7738e362d54f3a
parent ec92f3cd1ef96bfa45526bc90cb6e44dd9f36773

Fix null dereference on uninitialized loop variable.

Bug swiftshader:52

Change-Id: I972c769551acf19898f10579685f45f3192612c4
Reviewed-on: https://swiftshader-review.googlesource.com/9810
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <capn@google.com>
Tested-by: Nicolas Capens <capn@google.com>

src/OpenGL/compiler/OutputASM.cpp

diff --git a/src/OpenGL/compiler/OutputASM.cpp b/src/OpenGL/compiler/OutputASM.cpp
index a0b5500..da87532 100644
--- a/src/OpenGL/compiler/OutputASM.cpp
+++ b/src/OpenGL/compiler/OutputASM.cpp
@@ -3521,7 +3521,7 @@
 				{
 					TIntermBinary *assign = variable->getAsBinaryNode();
 
-					if(assign->getOp() == EOpInitialize)
+					if(assign && assign->getOp() == EOpInitialize)
 					{
 						TIntermSymbol *symbol = assign->getLeft()->getAsSymbolNode();
 						TIntermConstantUnion *constant = assign->getRight()->getAsConstantUnion();