tree 96a4f030ca2683c86b757178d8ff4e248f8d980f
parent 3aec8a3be749e60fd8c093f046dae929ced23650
author Ben Clayton <bclayton@google.com> 1565285621 +0100
committer Nicolas Capens <nicolascapens@google.com> 1565289309 +0000

VkDevice: Fix sample cache hash collisions that caused spurious test failures.

Keying off a single size_t is likely to cause collisions, more so when the hash function is simple shift-xors of 3 32-bit integers.

Use a proper cache key comparision and a better hash function while we're at it.

Bug: b/137649247
Change-Id: I1e0deefb0976102714d43dcb9dcedf6aa809bf7f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34909
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
(cherry picked from commit f046402b1480245c3c17e91131f11f066f53b289)
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34928