tree 2fc7f83f66be37e648d52ed0ef2b5c6051ae7317
parent 20b950a2520dfd30e84bd5e45153e6bce362752d
author Ben Clayton <bclayton@google.com> 1553598616 +0000
committer Ben Clayton <bclayton@google.com> 1553891324 +0000

SpirvShader: Handle dead code branches.

Given the following situation:

```

>->- alive >->->->
                  \
                    >-> alive
                  /
   unreachable >->

```

We would attempt to codegen the dead block (all blocks ensure their in's are processed first).

However dEQP-VK.spirv_assembly.instruction.graphics.conditional_branch.same_labels_false_frag seems to have dead blocks that use values from blocks it couldn't possibly use (as it has no ins).

While this is probably just a broken test, it is still good to harden up the compiler to pathological cases like this.

Tests: dEQP-VK.spirv_assembly.instruction.compute.*
Tests: dEQP-VK.spirv_assembly.instruction.graphics.*
Bug: b/128527271
Change-Id: Ibaacf6a58cf7ab6e73771b58cfe67f0c394e53c6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27948
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>