commit fe23c66f215b8048f78e6905ce7903b37b9400a0
author Jamie Madill <jmadill@chromium.org> Fri Aug 30 17:38:24 2019 -0400
committer Jamie Madill <jmadill@chromium.org> Mon Sep 02 20:39:46 2019 +0000
tree 06c945888fce4b61b3093fe62c7d141115404a5a
parent 39a9f1bdcd0eb45cb8813993ae0221b672afaa1c

Fix GN Header checks.

This fixes a few missing dependencies for the Chromium uses of
SwiftShader. It will allow us to turn on the 'gn check' in
Chromium.

Bug: angleproject:3876
Bug: b/140251624
Change-Id: I875a59701a4437cf94b503f6430d858a5285a961
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35811
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Jamie Madill <jmadill@chromium.org>

src/Vulkan/BUILD.gn

diff --git a/src/Vulkan/BUILD.gn b/src/Vulkan/BUILD.gn
index b90e231..7da1c59 100644
--- a/src/Vulkan/BUILD.gn
+++ b/src/Vulkan/BUILD.gn
@@ -42,75 +42,80 @@
   ]
 }
 
-swiftshader_shared_library("swiftshader_libvulkan") {
+swiftshader_source_set("swiftshader_libvulkan_headers") {
   sources = [
     "Version.h",
-    "VkBuffer.cpp",
     "VkBuffer.hpp",
-    "VkBufferView.cpp",
     "VkBufferView.hpp",
-    "VkCommandBuffer.cpp",
     "VkCommandBuffer.hpp",
-    "VkCommandPool.cpp",
     "VkCommandPool.hpp",
     "VkConfig.h",
-    "VkDebug.cpp",
     "VkDebug.hpp",
-    "VkDescriptorPool.cpp",
     "VkDescriptorPool.hpp",
     "VkDescriptorSet.hpp",
-    "VkDescriptorSetLayout.cpp",
     "VkDescriptorSetLayout.hpp",
-    "VkDescriptorUpdateTemplate.cpp",
     "VkDescriptorUpdateTemplate.hpp",
     "VkDestroy.h",
-    "VkDevice.cpp",
     "VkDevice.hpp",
-    "VkDeviceMemory.cpp",
     "VkDeviceMemory.hpp",
     "VkEvent.hpp",
     "VkFence.hpp",
-    "VkFormat.cpp",
     "VkFormat.h",
-    "VkFramebuffer.cpp",
     "VkFramebuffer.hpp",
-    "VkGetProcAddress.cpp",
     "VkGetProcAddress.h",
-    "VkImage.cpp",
     "VkImage.hpp",
-    "VkImageView.cpp",
     "VkImageView.hpp",
-    "VkInstance.cpp",
     "VkInstance.hpp",
-    "VkMemory.cpp",
     "VkMemory.h",
     "VkObject.hpp",
-    "VkPhysicalDevice.cpp",
     "VkPhysicalDevice.hpp",
-    "VkPipeline.cpp",
     "VkPipeline.hpp",
-    "VkPipelineCache.cpp",
     "VkPipelineCache.hpp",
-    "VkPipelineLayout.cpp",
     "VkPipelineLayout.hpp",
-    "VkPromotedExtensions.cpp",
-    "VkQueryPool.cpp",
     "VkQueryPool.hpp",
-    "VkQueue.cpp",
     "VkQueue.hpp",
-    "VkRenderPass.cpp",
     "VkRenderPass.hpp",
-    "VkSampler.cpp",
     "VkSampler.hpp",
     "VkSemaphore.hpp",
-    "VkShaderModule.cpp",
     "VkShaderModule.hpp",
-    "Vulkan.rc",
     "VulkanPlatform.h",
+  ]
+}
+
+swiftshader_shared_library("swiftshader_libvulkan") {
+  sources = [
+    "VkBuffer.cpp",
+    "VkBufferView.cpp",
+    "VkCommandBuffer.cpp",
+    "VkCommandPool.cpp",
+    "VkDebug.cpp",
+    "VkDescriptorPool.cpp",
+    "VkDescriptorSetLayout.cpp",
+    "VkDescriptorUpdateTemplate.cpp",
+    "VkDevice.cpp",
+    "VkDeviceMemory.cpp",
+    "VkFormat.cpp",
+    "VkFramebuffer.cpp",
+    "VkGetProcAddress.cpp",
+    "VkImage.cpp",
+    "VkImageView.cpp",
+    "VkInstance.cpp",
+    "VkMemory.cpp",
+    "VkPhysicalDevice.cpp",
+    "VkPipeline.cpp",
+    "VkPipelineCache.cpp",
+    "VkPipelineLayout.cpp",
+    "VkPromotedExtensions.cpp",
+    "VkQueryPool.cpp",
+    "VkQueue.cpp",
+    "VkRenderPass.cpp",
+    "VkSampler.cpp",
+    "VkShaderModule.cpp",
+    "Vulkan.rc",
     "libVulkan.cpp",
-    "vk_swiftshader.def",
     "main.cpp",
     "resource.h",
+    "vk_swiftshader.def",
   ]
 
   configs = [ ":swiftshader_libvulkan_private_config" ]
@@ -133,13 +138,13 @@
   }
 
   deps = [
+    "${swiftshader_spirv_tools_dir}:SPIRV-Tools",
     "../Device",
     "../Pipeline",
     "../Reactor:swiftshader_llvm_reactor",
     "../System",
     "../WSI",
     "../Yarn",
-    "$swiftshader_spirv_tools_dir:SPIRV-Tools",
   ]
 
   include_dirs = [
@@ -148,4 +153,8 @@
     "$swiftshader_spirv_tools_dir/include",
     "$spirv_tools_spirv_headers_dir/include",
   ]
+
+  public_deps = [
+    ":swiftshader_libvulkan_headers",
+  ]
 }