commit f91d9c1c98c30b887cfa1a4d39ddf64d6459e621
author Nicolas Capens <capn@google.com> Tue Apr 26 14:18:31 2016 +0000
committer Nicolas Capens <capn@google.com> Sat Apr 30 05:32:42 2016 +0000
tree 9357b442aad080cd5044a0bea376176a706654c4
parent c431041d283c7c3fad218c02999db266bcd6d58b

Fix scoping of function parameters for GLSL ES 1.0

This reverts commit 0637eac3b8fd276596b303aaa7e5d59a3accccf8.
It's considered a spec bug:
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=8656

Change-Id: Id49121d5adf91ecab3d261c3c12e2f879f47e856
Reviewed-on: https://swiftshader-review.googlesource.com/5192
Reviewed-by: Shannon Woods <shannonwoods@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <capn@google.com>
Tested-by: Nicolas Capens <capn@google.com>

src/OpenGL/compiler/glslang.y

diff --git a/src/OpenGL/compiler/glslang.y b/src/OpenGL/compiler/glslang.y
index 1ecf468..3030144 100644
--- a/src/OpenGL/compiler/glslang.y
+++ b/src/OpenGL/compiler/glslang.y
@@ -1591,11 +1591,9 @@
 function_definition
     : function_prototype {
         context->parseFunctionPrototype(@1, $1.function, &$1.intermAggregate);
-        if (context->getShaderVersion() == 100) context->symbolTable.push();
     }
     compound_statement_no_new_scope {
         $$ = context->addFunctionDefinition(*($1.function), $1.intermAggregate, $3, @1);
-        if (context->getShaderVersion() == 100) context->symbolTable.pop();
     }
     ;
 

src/OpenGL/compiler/glslang_tab.cpp

diff --git a/src/OpenGL/compiler/glslang_tab.cpp b/src/OpenGL/compiler/glslang_tab.cpp
index ad7bd4d..2e23afe 100644
--- a/src/OpenGL/compiler/glslang_tab.cpp
+++ b/src/OpenGL/compiler/glslang_tab.cpp
@@ -4831,7 +4831,6 @@
 
     {
         context->parseFunctionPrototype((yylsp[0]), (yyvsp[0].interm).function, &(yyvsp[0].interm).intermAggregate);
-        if (context->getShaderVersion() == 100) context->symbolTable.push();
     }
 
     break;
@@ -4840,7 +4839,6 @@
 
     {
         (yyval.interm.intermNode) = context->addFunctionDefinition(*((yyvsp[-2].interm).function), (yyvsp[-2].interm).intermAggregate, (yyvsp[0].interm.intermAggregate), (yylsp[-2]));
-        if (context->getShaderVersion() == 100) context->symbolTable.pop();
     }
 
     break;