commit f4fbf7fdff5a40c54a932073209ae9c224d729e3
author Jim Stichnoth <stichnot@chromium.org> Sat Aug 08 08:37:02 2015 -0700
committer Jim Stichnoth <stichnot@chromium.org> Sat Aug 08 08:37:02 2015 -0700
tree 934993e3f4548f2ce44fdc71aaea380d0f49dc2b
parent aa0ce790f7426ad3be6e3c648ba84abbf1928378

Subzero: Fix a memory leak.

The problem was that Translator and subclasses need to have virtual destructors since they are used as unique_ptr<>.  As a result, only the Translator base class destructor was being invoked.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4290
TEST= make -f Makefile.standalone ASAN=1 check-lit
R=ascull@google.com

Review URL: https://codereview.chromium.org/1281003003.

src/IceTranslator.h

diff --git a/src/IceTranslator.h b/src/IceTranslator.h
index 9fe46ee..449b216 100644
--- a/src/IceTranslator.h
+++ b/src/IceTranslator.h
@@ -41,7 +41,7 @@
 public:
   explicit Translator(GlobalContext *Ctx);
 
-  ~Translator();
+  virtual ~Translator() = default;
   const ErrorCode &getErrorStatus() const { return ErrorStatus; }
 
   GlobalContext *getContext() const { return Ctx; }