tree 6544260b39abd17e3f097a7e612431dc331cc5a9
parent 2933d312696949646f52616df81d5b29601edc4e
author Alexis Hetu <sugoi@google.com> 1652714453 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> 1652964521 +0000

Fix using uninitialized blend constants

Renderer::draw() unconditionally calls:
pixelProcessor.setBlendConstant(pipelineState.getBlendConstants());

which means the blend constants must be initialized before
Renderer::draw() is called. If blend constants are marked as being
dynamic in the pipeline, but vkCmdSetBlendConstants() is never
called, then blend constants are used before being initialized.

This CL adds initializers for the remaining uninitialized members of
DynamicState in order to fix this issue.

Bug: chromium:1325636
Change-Id: I940559f3fc4c0d0d52c6ebfe5ceae4706fe6906e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/65868
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Commit-Queue: Alexis Hétu <sugoi@google.com>