commit efe9232cdbe5feb74b970811fddfac3563671286
author Nicolas Capens <capn@google.com> Thu Jun 11 16:44:39 2015 -0400
committer Nicolas Capens <capn@google.com> Thu Jun 11 20:46:08 2015 +0000
tree ac1922d8409ca01fc3da246a133a4ff1660f4882
parent b2b498e7beb4dcc32930bf6e97475ae8cb8a51be

Fix unintended switch case fall-through.

Bug 21766174

Change-Id: I1428bcceb2fbf6c649632112f773c3a0625e3775
Reviewed-on: https://swiftshader-review.googlesource.com/3479
Reviewed-by: Nicolas Capens <capn@google.com>
Tested-by: Nicolas Capens <capn@google.com>

src/OpenGL/libGLES_CM/Context.cpp

diff --git a/src/OpenGL/libGLES_CM/Context.cpp b/src/OpenGL/libGLES_CM/Context.cpp
index 4151de7..8cacba3 100644
--- a/src/OpenGL/libGLES_CM/Context.cpp
+++ b/src/OpenGL/libGLES_CM/Context.cpp
@@ -1881,6 +1881,7 @@
 						// Cv = Cs, Av = Ap

 						device->setStageOperation(unit, sw::TextureStage::STAGE_SELECTARG1);

 						device->setStageOperationAlpha(unit, sw::TextureStage::STAGE_SELECTARG2);

+						break;

 					case GL_LUMINANCE_ALPHA:

 					case GL_RGBA:

 					case GL_BGRA_EXT:

@@ -1904,6 +1905,7 @@
 						// Cv = CpCs, Av = Ap

 						device->setStageOperation(unit, sw::TextureStage::STAGE_MODULATE);

 						device->setStageOperationAlpha(unit, sw::TextureStage::STAGE_SELECTARG2);

+						break;

 					case GL_LUMINANCE_ALPHA:

 					case GL_RGBA:

 					case GL_BGRA_EXT:

@@ -1928,6 +1930,7 @@
 						// Cv = Cs, Av = Ap

 						device->setStageOperation(unit, sw::TextureStage::STAGE_SELECTARG1);

 						device->setStageOperationAlpha(unit, sw::TextureStage::STAGE_SELECTARG2);

+						break;

 					case GL_RGBA:

 					case GL_BGRA_EXT:

 						// Cv = Cp(1 ? As) + CsAs, Av = Ap

@@ -1950,6 +1953,7 @@
 						// Cv = Cp(1 ? Cs) + CcCs, Av = Ap

 						device->setStageOperation(unit, sw::TextureStage::STAGE_LERP);   // Arg3 * (Arg1 - Arg2) + Arg2

 						device->setStageOperationAlpha(unit, sw::TextureStage::STAGE_SELECTARG2);

+						break;

 					case GL_LUMINANCE_ALPHA:

 					case GL_RGBA:

 					case GL_BGRA_EXT:

@@ -1973,6 +1977,7 @@
 						// Cv = Cp + Cs, Av = Ap

 						device->setStageOperation(unit, sw::TextureStage::STAGE_ADD);

 						device->setStageOperationAlpha(unit, sw::TextureStage::STAGE_SELECTARG2);

+						break;

 					case GL_LUMINANCE_ALPHA:

 					case GL_RGBA:

 					case GL_BGRA_EXT: