Subzero: Use C++11 member initializers where practical.
Also change the pattern "foo() {}" into "foo() = default;" for ctors and dtors.
Generally avoids initializing unique_ptr<> members to nullptr in a .h file, because that requires knowing the definition of the underlying class which may not be available to all includers.
BUG= none
R=jpp@chromium.org
Review URL: https://codereview.chromium.org/1197223002
diff --git a/src/IceClFlagsExtra.h b/src/IceClFlagsExtra.h
index 9346d6e..6f39336 100644
--- a/src/IceClFlagsExtra.h
+++ b/src/IceClFlagsExtra.h
@@ -25,9 +25,7 @@
ClFlagsExtra &operator=(const ClFlagsExtra &) = delete;
public:
- ClFlagsExtra()
- : AlwaysExitSuccess(false), BuildOnRead(false), GenerateBuildAtts(false),
- LLVMVerboseErrors(false), InputFileFormat(llvm::LLVMFormat) {}
+ ClFlagsExtra() = default;
bool getAlwaysExitSuccess() const { return AlwaysExitSuccess; }
void setAlwaysExitSuccess(bool NewValue) { AlwaysExitSuccess = NewValue; }
@@ -61,17 +59,17 @@
}
private:
- bool AlwaysExitSuccess;
- bool BuildOnRead;
- bool GenerateBuildAtts;
- bool LLVMVerboseErrors;
+ bool AlwaysExitSuccess = false;
+ bool BuildOnRead = false;
+ bool GenerateBuildAtts = false;
+ bool LLVMVerboseErrors = false;
- llvm::NaClFileFormat InputFileFormat;
+ llvm::NaClFileFormat InputFileFormat = llvm::LLVMFormat;
- IceString AppName;
- IceString IRFilename;
- IceString LogFilename;
- IceString OutputFilename;
+ IceString AppName = "";
+ IceString IRFilename = "";
+ IceString LogFilename = "";
+ IceString OutputFilename = "";
};
} // end of namespace Ice
