Use official headers to define GL_ARB_texture_rectangle. Fixing https://github.com/KhronosGroup/OpenGL-Registry/pull/149 and https://github.com/KhronosGroup/OpenGL-Registry/pull/183 enabled including desktop OpenGL headers without conflicts, so we no longer have to define enums for ARB extensions ourselves. Change-Id: I4f2e2d3b79a6f5cacf53f2a8ace78b6d124cb5d1 Reviewed-on: https://swiftshader-review.googlesource.com/19029 Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com>
diff --git a/src/OpenGL/compiler/Compiler.h b/src/OpenGL/compiler/Compiler.h index 89acc04..c778626 100644 --- a/src/OpenGL/compiler/Compiler.h +++ b/src/OpenGL/compiler/Compiler.h
@@ -67,29 +67,6 @@ #define GL_FRAGMENT_SHADER 0x8B30 #define GL_VERTEX_SHADER 0x8B31 -// Note: GL_ARB_texture_rectangle is part of gl2extchromium.h in the Chromium repo -// GL_ARB_texture_rectangle -#ifndef GL_ARB_texture_rectangle -#define GL_ARB_texture_rectangle 1 - -#ifndef GL_SAMPLER_2D_RECT_ARB -#define GL_SAMPLER_2D_RECT_ARB 0x8B63 -#endif - -#ifndef GL_TEXTURE_BINDING_RECTANGLE_ARB -#define GL_TEXTURE_BINDING_RECTANGLE_ARB 0x84F6 -#endif - -#ifndef GL_TEXTURE_RECTANGLE_ARB -#define GL_TEXTURE_RECTANGLE_ARB 0x84F5 -#endif - -#ifndef GL_MAX_RECTANGLE_TEXTURE_SIZE_ARB -#define GL_MAX_RECTANGLE_TEXTURE_SIZE_ARB 0x84F8 -#endif - -#endif // GL_ARB_texture_rectangle - // // The base class for the machine dependent compiler to derive from // for managing object code from the compile.
diff --git a/src/OpenGL/compiler/OutputASM.cpp b/src/OpenGL/compiler/OutputASM.cpp index 8b20758..9ed34b2 100644 --- a/src/OpenGL/compiler/OutputASM.cpp +++ b/src/OpenGL/compiler/OutputASM.cpp
@@ -23,6 +23,8 @@ #include <GLES2/gl2.h> #include <GLES2/gl2ext.h> #include <GLES3/gl3.h> +#include <GL/glcorearb.h> +#include <GL/glext.h> #include <stdlib.h>
diff --git a/src/OpenGL/libGLESv2/Renderbuffer.cpp b/src/OpenGL/libGLESv2/Renderbuffer.cpp index 48a61e9..a970dcf 100644 --- a/src/OpenGL/libGLESv2/Renderbuffer.cpp +++ b/src/OpenGL/libGLESv2/Renderbuffer.cpp
@@ -22,8 +22,6 @@ #include "Texture.h" #include "utilities.h" -#include "compiler/Compiler.h" - namespace es2 { RenderbufferInterface::RenderbufferInterface()
diff --git a/src/OpenGL/libGLESv2/utilities.h b/src/OpenGL/libGLESv2/utilities.h index 321dbc8..f0fdb4b 100644 --- a/src/OpenGL/libGLESv2/utilities.h +++ b/src/OpenGL/libGLESv2/utilities.h
@@ -23,6 +23,8 @@ #include <GLES2/gl2.h> #include <GLES2/gl2ext.h> +#include <GL/glcorearb.h> +#include <GL/glext.h> #include <string>
diff --git a/tests/unittests/unittests.cpp b/tests/unittests/unittests.cpp index d75d9ba..89a24a0 100644 --- a/tests/unittests/unittests.cpp +++ b/tests/unittests/unittests.cpp
@@ -19,6 +19,8 @@ #include <GLES2/gl2.h> #include <GLES2/gl2ext.h> #include <GLES3/gl3.h> +#include <GL/glcorearb.h> +#include <GL/glext.h> #if defined(_WIN32) #include <Windows.h> @@ -636,29 +638,6 @@ } } -// Note: GL_ARB_texture_rectangle is part of gl2extchromium.h in the Chromium repo -// GL_ARB_texture_rectangle -#ifndef GL_ARB_texture_rectangle -#define GL_ARB_texture_rectangle 1 - -#ifndef GL_SAMPLER_2D_RECT_ARB -#define GL_SAMPLER_2D_RECT_ARB 0x8B63 -#endif - -#ifndef GL_TEXTURE_BINDING_RECTANGLE_ARB -#define GL_TEXTURE_BINDING_RECTANGLE_ARB 0x84F6 -#endif - -#ifndef GL_TEXTURE_RECTANGLE_ARB -#define GL_TEXTURE_RECTANGLE_ARB 0x84F5 -#endif - -#ifndef GL_MAX_RECTANGLE_TEXTURE_SIZE_ARB -#define GL_MAX_RECTANGLE_TEXTURE_SIZE_ARB 0x84F8 -#endif - -#endif // GL_ARB_texture_rectangle - // Test using TexImage2D to define a rectangle texture TEST_F(SwiftShaderTest, TextureRectangle_TexImage2D)