commit e70c3514e5a0019a94260557c0ace269321e9a02
author Alexis Hetu <sugoi@google.com> Wed Oct 17 13:18:04 2018 -0400
committer Alexis Hétu <sugoi@google.com> Thu Oct 18 14:17:43 2018 +0000
tree 696f5836858491bd8b5d5c1fdeba8414689db4c1
parent b83d4911baaeb514eb9376c16f5250ef2bdba68d

Linux build fix

On linux, clang is unable to find the Cast() function used in the
templated destroy() function unless it has already been defined
before the template function. This forces us to make sure all
Cast() functions are available, but simply adding the vulkan objects'
header files in VkMemory.h would cause a circular dependency, which,
while it would be properly guarded by the preprocessor directives,
wouldn't guarantee any include order, due to the nature of circular
dependencies. So, to fix the issue, a new header file, called
VkDestroy.h was added, which can depend on all vulkan objects' header
files without creating a circular dependency.

Also fixed some warnings.

Change-Id: I1f343a8c476d6308d4555009848a234b0695661e
Reviewed-on: https://swiftshader-review.googlesource.com/c/21668
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

src/Reactor/Reactor.vcxproj

diff --git a/src/Reactor/Reactor.vcxproj b/src/Reactor/Reactor.vcxproj
index 8b54ce5..b26b32f 100644
--- a/src/Reactor/Reactor.vcxproj
+++ b/src/Reactor/Reactor.vcxproj
@@ -124,6 +124,7 @@
       <ExceptionHandling>false</ExceptionHandling>

       <MultiProcessorCompilation>true</MultiProcessorCompilation>

       <TreatSpecificWarningsAsErrors>4018;5038;4838</TreatSpecificWarningsAsErrors>

+      <AdditionalOptions>/permissive- %(AdditionalOptions)</AdditionalOptions>

     </ClCompile>

     <ProjectReference>

       <LinkLibraryDependencies>false</LinkLibraryDependencies>

@@ -150,6 +151,7 @@
       <TreatWarningAsError>true</TreatWarningAsError>

       <MultiProcessorCompilation>true</MultiProcessorCompilation>

       <TreatSpecificWarningsAsErrors>4018;5038;4838</TreatSpecificWarningsAsErrors>

+      <AdditionalOptions>/permissive- %(AdditionalOptions)</AdditionalOptions>

     </ClCompile>

     <ProjectReference>

       <LinkLibraryDependencies>false</LinkLibraryDependencies>

@@ -180,6 +182,7 @@
       <TreatWarningAsError>true</TreatWarningAsError>

       <MultiProcessorCompilation>true</MultiProcessorCompilation>

       <TreatSpecificWarningsAsErrors>4018;5038;4838</TreatSpecificWarningsAsErrors>

+      <AdditionalOptions>/permissive- %(AdditionalOptions)</AdditionalOptions>

     </ClCompile>

     <ProjectReference>

       <LinkLibraryDependencies>false</LinkLibraryDependencies>

@@ -208,6 +211,7 @@
       <FloatingPointExceptions>false</FloatingPointExceptions>

       <TreatWarningAsError>true</TreatWarningAsError>

       <TreatSpecificWarningsAsErrors>4018;5038;4838</TreatSpecificWarningsAsErrors>

+      <AdditionalOptions>/permissive- %(AdditionalOptions)</AdditionalOptions>

     </ClCompile>

     <ProjectReference>

       <LinkLibraryDependencies>false</LinkLibraryDependencies>

@@ -240,6 +244,7 @@
       <TreatWarningAsError>true</TreatWarningAsError>

       <MultiProcessorCompilation>true</MultiProcessorCompilation>

       <TreatSpecificWarningsAsErrors>4018;5038;4838</TreatSpecificWarningsAsErrors>

+      <AdditionalOptions>/permissive- %(AdditionalOptions)</AdditionalOptions>

     </ClCompile>

     <ProjectReference>

       <LinkLibraryDependencies>false</LinkLibraryDependencies>

@@ -271,6 +276,7 @@
       <FloatingPointExceptions>false</FloatingPointExceptions>

       <TreatWarningAsError>true</TreatWarningAsError>

       <TreatSpecificWarningsAsErrors>4018;5038;4838</TreatSpecificWarningsAsErrors>

+      <AdditionalOptions>/permissive- %(AdditionalOptions)</AdditionalOptions>

     </ClCompile>

     <ProjectReference>

       <LinkLibraryDependencies>false</LinkLibraryDependencies>