tree b3010c87102eb85ba127bbcab7c08ab368566cf3
parent cd9da0fefcefa6fc6d5ba7a2d29d173fef87801e
author Bruno Pitrus <brunopitrus@hotmail.com> 1666292759 +0200
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> 1667233362 +0000

Use sw::bit_cast<> for type punning

Type punning through pointer or reference type cast breaks strict
aliasing rules which can lead to undefined behavior.

Note that sw::bit_cast<> makes use of a union to perform type punning,
which is also in violation of strict C++ rules, but is supported by
extension in at least the Visual Studio, Clang, and GCC compilers. It
will also be trivial to replace with std::bit_cast<> once we can upgrade
to C++20.

Bug: b/227975743
Change-Id: I4b94764aa6445d7c8d6463ba3a4b23a09ac975ef
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/69169
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Commit-Queue: Alexis Hétu <sugoi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>