tree d889ce42dfb269c312309f17970ae09b6fe191ad
parent 15f39445da55d75c72c6d5539e68fe00b5879fd0
author Nicolas Capens <capn@google.com> 1628024981 -0400
committer Nicolas Capens <nicolascapens@google.com> 1628104081 +0000

Remove unimplemented MaskedStore/MaskedLoad usage

Reactor's MaskedStore and MaskedLoad intrinsics were only implemented
for the LLVM backend, and would lead to asserts when they're used with
the Subzero backend.

This patch addresses this issue by falling back to using scatter/gather
operations. While slower, this is justified by how rarely this code path
was being used.

Note these Reactor functions have been marked with the [[deprecated]]
C++ attribute to cause a warning, which we treat as an error, if they
would be used again. They must be implemented in Subzero (note an
'emulated' implementation is acceptable, which is what we already do for
gather/scatter), before using them again.

Bug: b/192310780
Change-Id: I42b3691f6c09ee4f884ad8960492558e372abe6c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/56110
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Sean Risser <srisser@google.com>