tree d3ce5bae00e0d4d0fc63af6cb38fdc36a76c41fe
parent 8b09c1078a2b0f37dcb7e83ec91c8b7538905b86
author Alexis Hetu <sugoi@google.com> 1620410340 -0400
committer Alexis Hétu <sugoi@google.com> 1620413879 +0000

Obtain all sampler parameters through SamplingRoutineCache::Key

This change ensures that the descriptor state identifiers used to
perform lookups in the sampling routine cache are all that is used to
obtain the state itself which is used for specializing sampling
routine generation.

The createSamplingRoutine lambda function is made to capture only the
'device' variable, instead of allowing access to all local variables.
The device is required to obtain the sampler state from the sampler
identifier.

Compared to the original CL:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/53068
This reorders the arguments to SpirvShader::getImageSampler().
Locally, at least, this makes the msan error go away.

Bug: b/152227757
Bug: b/187467599
Change-Id: Id8488f3718a29bb53c9eb409e404a49ce2995987
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/54108
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>