commit db04c0645e0757854962acc45bfcb32aea70ad3a
author Ping-Hao Wu <pinghao@google.com> Fri Mar 20 11:41:49 2015 -0400
committer Nicolas Capens <capn@google.com> Fri Mar 20 16:33:39 2015 +0000
tree f866b84b37c6cffc262e9a7cb0f4756676d7af59
parent df84738c019d798737bc8744a551c407d44cdc2b

Use a string format for safer printing.

The string was directly used as the string format, which would have caused
printf to expect additional arguments when it contains formatting elements.

Bug 18720257

Change-Id: Ie4391097e58d4cab2793a05eda2b03acd02d7f22
Reviewed-on: https://swiftshader-review.googlesource.com/2656
Reviewed-by: Greg Hartman <ghartman@google.com>
Tested-by: Greg Hartman <ghartman@google.com>
Reviewed-by: Nicolas Capens <capn@google.com>

src/OpenGL/libGL/Shader.cpp

diff --git a/src/OpenGL/libGL/Shader.cpp b/src/OpenGL/libGL/Shader.cpp
index a39e7ca..bb574a3 100644
--- a/src/OpenGL/libGL/Shader.cpp
+++ b/src/OpenGL/libGL/Shader.cpp
@@ -208,7 +208,7 @@
 		char buffer[256];
 		sprintf(buffer, "shader-input-%d-%d.txt", getName(), serial);
 		FILE *file = fopen(buffer, "wt");
-		fprintf(file, mSource);
+		fprintf(file, "%s", mSource);
 		fclose(file);
 		getShader()->print("shader-output-%d-%d.txt", getName(), serial);
 		serial++;

src/OpenGL/libGLESv2/Shader.cpp

diff --git a/src/OpenGL/libGLESv2/Shader.cpp b/src/OpenGL/libGLESv2/Shader.cpp
index 3a39ba2..81616c3 100644
--- a/src/OpenGL/libGLESv2/Shader.cpp
+++ b/src/OpenGL/libGLESv2/Shader.cpp
@@ -208,7 +208,7 @@
 		char buffer[256];
 		sprintf(buffer, "shader-input-%d-%d.txt", getName(), serial);
 		FILE *file = fopen(buffer, "wt");
-		fprintf(file, mSource);
+		fprintf(file, "%s", mSource);
 		fclose(file);
 		getShader()->print("shader-output-%d-%d.txt", getName(), serial);
 		serial++;

src/Radiance/libRAD/Shader.cpp

diff --git a/src/Radiance/libRAD/Shader.cpp b/src/Radiance/libRAD/Shader.cpp
index 0b85533..155e237 100644
--- a/src/Radiance/libRAD/Shader.cpp
+++ b/src/Radiance/libRAD/Shader.cpp
@@ -387,7 +387,7 @@
 		char buffer[256];
 		sprintf(buffer, "vertex-input-%d-%d.txt", getName(), serial);
 		FILE *file = fopen(buffer, "wt");
-		fprintf(file, mSource);
+		fprintf(file, "%s", mSource);
 		fclose(file);
 		vertexShader->print("vertex-output-%d-%d.txt", getName(), serial);
 		serial++;
@@ -472,7 +472,7 @@
 		char buffer[256];
 		sprintf(buffer, "pixel-input-%d-%d.txt", getName(), serial);
 		FILE *file = fopen(buffer, "wt");
-		fprintf(file, mSource);
+		fprintf(file, "%s", mSource);
 		fclose(file);
 		pixelShader->print("pixel-output-%d-%d.txt", getName(), serial);
 		serial++;